search for: tmfifo

...linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp at intel.com> All errors (new ones prefixed by >>): drivers/platform/mellanox/mlxbf-tmfifo.c: In function 'mlxbf_tmfifo_probe': drivers/platform/mellanox/mlxbf-tmfifo.c:1237:70: warning: value computed is not used [-Wunused-value] 1237 | #define MLXBF_TMFIFO_LITTLE_ENDIAN (virtio_legacy_is_little_endian() || \ | ~~~~~~~~~~~~~~~~...

...linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp at intel.com> All errors (new ones prefixed by >>): drivers/platform/mellanox/mlxbf-tmfifo.c: In function 'mlxbf_tmfifo_probe': >> drivers/platform/mellanox/mlxbf-tmfifo.c:1237:2: error: invalid preprocessing directive #defined; did you mean #define? 1237 | #defined MLXBF_TMFIFO_LITTLE_ENDIAN (virtio_legacy_is_little_endian() || | ^~~~~~~ | define...

mlxbf-tmfifo accesses config space using native types - which works for it since the legacy virtio native types. This will break if it ever needs to support modern virtio, so with new tags previously introduced for virtio net config, sparse now warns for this in drivers. Since this is a legacy only device, fi...

On Mon, 3 Aug 2020 17:00:01 -0400 "Michael S. Tsirkin" <mst at redhat.com> wrote: > mlxbf-tmfifo accesses config space using native types - > which works for it since the legacy virtio native types. > > This will break if it ever needs to support modern virtio, > so with new tags previously introduced for virtio net config, > sparse now warns for this in drivers. > > Sin...

...s and introduce different > drivers on top. See the other mail, it seems struct virtio_device serves this purpose already, confused why a struct vdpa_device and another bus is being introduced > There're several examples that a bus is needed on top. > > A good example is Mellanox TmFIFO driver which is a platform device driver > but register itself as a virtio device in order to be used by virito-console > driver on the virtio bus. How is that another bus? The platform bus is the HW bus, the TmFIFO is the HW driver, and virtio_device is the subsystem. This seems reasonable...

...particular, the APIs actually assume the legacy layout. Add struct vring_s (identical ATM) and supporting legacy APIs and switch everyone to use that. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/misc/mic/vop/vop_main.c | 2 +- drivers/platform/mellanox/mlxbf-tmfifo.c | 10 ++++----- drivers/virtio/virtio_ring.c | 10 ++++----- include/linux/virtio.h | 2 +- include/linux/virtio_ring.h | 28 ++++++++++++++++++++++++ include/linux/vringh.h | 2 +- tools/virtio/ringtest/virtio_ring_0_9.c | 6 ++---...

...particular, the APIs actually assume the legacy layout. Add struct vring_s (identical ATM) and supporting legacy APIs and switch everyone to use that. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/misc/mic/vop/vop_main.c | 2 +- drivers/platform/mellanox/mlxbf-tmfifo.c | 10 ++++----- drivers/virtio/virtio_ring.c | 10 ++++----- include/linux/virtio.h | 2 +- include/linux/virtio_ring.h | 28 ++++++++++++++++++++++++ include/linux/vringh.h | 2 +- tools/virtio/ringtest/virtio_ring_0_9.c | 6 ++---...

On Thu, Feb 13, 2020 at 10:56:00AM -0500, Michael S. Tsirkin wrote: > On Thu, Feb 13, 2020 at 11:51:54AM -0400, Jason Gunthorpe wrote: > > > That bus is exactly what Greg KH proposed. There are other ways > > > to solve this I guess but this bikeshedding is getting tiring. > > > > This discussion was for a different goal, IMHO. > > Hmm couldn't find it

On Thu, Feb 13, 2020 at 10:56:00AM -0500, Michael S. Tsirkin wrote: > On Thu, Feb 13, 2020 at 11:51:54AM -0400, Jason Gunthorpe wrote: > > > That bus is exactly what Greg KH proposed. There are other ways > > > to solve this I guess but this bikeshedding is getting tiring. > > > > This discussion was for a different goal, IMHO. > > Hmm couldn't find it

...mu: correct tags for config space fields virtio_mem: correct tags for config space fields virtio_net: correct tags for config space fields virtio_pmem: correct tags for config space fields virtio_scsi: correct tags for config space fields virtio_config: disallow native type fields mlxbf-tmfifo: sparse tags for config access vdpa: make sure set_features in invoked for legacy vhost/vdpa: switch to new helpers virtio_vdpa: legacy features handling vdpa_sim: fix endian-ness of config space virtio_config: cread/write cleanup virtio_config: rewrite using _Generic drivers/platform...

...fig space fields virtio_mem: correct tags for config space fields virtio_net: correct tags for config space fields virtio_pmem: correct tags for config space fields virtio_scsi: correct tags for config space fields virtio_config: disallow native type fields mlxbf-tmfifo: sparse tags for config access vdpa: make sure set_features is invoked for legacy vhost/vdpa: switch to new helpers virtio_vdpa: legacy features handling vdpa_sim: fix endian-ness of config space virtio_config: cread/write cleanup virtio_config: rewrite using _Ge...

...struct XXX_device { struct vdpa_device vdpa; struct adi_device/pci_device *lowerdev; } ... > - An existing PCI, platform, or other bus and device. No need for an > extra bus here, PCI is the bus. There're several examples that a bus is needed on top. A good example is Mellanox TmFIFO driver which is a platform device driver but register itself as a virtio device in order to be used by virito-console driver on the virtio bus. But it's a pity that the device can not be used by userspace driver due to the limitation of virito bus which is designed for kernel driver. That&...

...| 1 + drivers/char/hw_random/virtio-rng.c | 1 + drivers/gpu/drm/virtio/virtgpu_ioctl.c | 1 + drivers/gpu/drm/virtio/virtgpu_kms.c | 1 + drivers/misc/mic/vop/vop_main.c | 5 +- drivers/misc/mic/vop/vop_vringh.c | 8 ++- drivers/platform/mellanox/mlxbf-tmfifo.c | 6 +- drivers/remoteproc/remoteproc_core.c | 2 +- drivers/remoteproc/remoteproc_sysfs.c | 1 + drivers/remoteproc/remoteproc_virtio.c | 2 +- drivers/remoteproc/stm32_rproc.c | 1 + drivers/rpmsg/mtk_rpmsg.c | 1 + drivers/vdpa/Kconfig...

...| 1 + drivers/char/hw_random/virtio-rng.c | 1 + drivers/gpu/drm/virtio/virtgpu_ioctl.c | 1 + drivers/gpu/drm/virtio/virtgpu_kms.c | 1 + drivers/misc/mic/vop/vop_main.c | 5 +- drivers/misc/mic/vop/vop_vringh.c | 8 ++- drivers/platform/mellanox/mlxbf-tmfifo.c | 6 +- drivers/remoteproc/remoteproc_core.c | 2 +- drivers/remoteproc/remoteproc_sysfs.c | 1 + drivers/remoteproc/remoteproc_virtio.c | 2 +- drivers/remoteproc/stm32_rproc.c | 1 + drivers/rpmsg/mtk_rpmsg.c | 1 + drivers/vdpa/Kconfig...

...ristate "Backlight LED support for Chrome OS keyboards" diff --git a/drivers/platform/mellanox/Kconfig b/drivers/platform/mellanox/Kconfig index 530fe7e31397..a4746bba7e9f 100644 --- a/drivers/platform/mellanox/Kconfig +++ b/drivers/platform/mellanox/Kconfig @@ -41,7 +41,7 @@ config MLXBF_TMFIFO depends on VIRTIO_CONSOLE && VIRTIO_NET help Say y here to enable TmFifo support. The TmFifo driver provides - platform driver support for the TmFifo which supports console - and networking based on the virtio framework. + platform driver support for the TmFifo w...

...ristate "Backlight LED support for Chrome OS keyboards" diff --git a/drivers/platform/mellanox/Kconfig b/drivers/platform/mellanox/Kconfig index 530fe7e31397..a4746bba7e9f 100644 --- a/drivers/platform/mellanox/Kconfig +++ b/drivers/platform/mellanox/Kconfig @@ -41,7 +41,7 @@ config MLXBF_TMFIFO depends on VIRTIO_CONSOLE && VIRTIO_NET help Say y here to enable TmFifo support. The TmFifo driver provides - platform driver support for the TmFifo which supports console - and networking based on the virtio framework. + platform driver support for the TmFifo w...