search for: temp1_auto_point1_pwm

https://bugs.freedesktop.org/show_bug.cgi?id=66022 Priority: medium Bug ID: 66022 Assignee: nouveau at lists.freedesktop.org Summary: pwm1[_enable] faults after hibernate/restore related to automatic (or otherwise) fan management QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified

...o strong opinions on this patch. I guess the numeric representation is easier to read, so I will give you my R-b for this and let others decide what to do: Reviewed-by: Martin Peres <martin.peres at free.fr> > */ > > #ifdef CONFIG_ACPI > @@ -56,7 +56,7 @@ nouveau_hwmon_show_temp1_auto_point1_pwm(struct device *d, > { > return snprintf(buf, PAGE_SIZE, "%d\n", 100); > } > -static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, S_IRUGO, > +static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, 0444, > nouveau_hwmon_show_temp1_auto_point1_pwm, NULL, 0); > > s...

...of this software and associated documentation files (the "Software"), @@ -19,7 +20,6 @@ * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR * OTHER DEALINGS IN THE SOFTWARE. * - * Authors: Ben Skeggs */ #ifdef CONFIG_ACPI @@ -56,7 +56,7 @@ nouveau_hwmon_show_temp1_auto_point1_pwm { return snprintf(buf, PAGE_SIZE, "%d\n", 100); } -static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, S_IRUGO, +static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, 0444, nouveau_hwmon_show_temp1_auto_point1_pwm, NULL, 0); static ssize_t @@ -88,7 +88,7 @@ nouveau_hwmon_set_temp1_au...

...of this software and associated documentation files (the "Software"), @@ -19,7 +20,6 @@ * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR * OTHER DEALINGS IN THE SOFTWARE. * - * Authors: Ben Skeggs */ #ifdef CONFIG_ACPI @@ -56,7 +56,7 @@ nouveau_hwmon_show_temp1_auto_point1_pwm(struct device *d, { return snprintf(buf, PAGE_SIZE, "%d\n", 100); } -static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, S_IRUGO, +static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, 0444, nouveau_hwmon_show_temp1_auto_point1_pwm, NULL, 0); static ssize_t @@ -88,7 +88,7 @@ nouveau_...

...+), 5 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c b/drivers/gpu/drm/nouveau/nouveau_hwmon.c index a7db7c31064b..e844be49e11e 100644 --- a/drivers/gpu/drm/nouveau/nouveau_hwmon.c +++ b/drivers/gpu/drm/nouveau/nouveau_hwmon.c @@ -41,7 +41,7 @@ static ssize_t nouveau_hwmon_show_temp1_auto_point1_pwm(struct device *d, struct device_attribute *a, char *buf) { - return snprintf(buf, PAGE_SIZE, "%d\n", 100); + return sysfs_emit(buf, "%d\n", 100); } static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, 0444, nouveau_hwmon_show_temp1_auto_point1_pwm, NULL, 0); @@ -54,8...

...har *buf) return snprintf(buf, PAGE_SIZE, "%d\n", temp * 1000); } -static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, nouveau_hwmon_show_temp, +static SENSOR_DEVICE_ATTR(temp1_input, 0444, nouveau_hwmon_show_temp, NULL, 0); static ssize_t @@ -60,7 +60,7 @@ nouveau_hwmon_show_temp1_auto_point1_pwm(struct device *d, { return snprintf(buf, PAGE_SIZE, "%d\n", 100); } -static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, S_IRUGO, +static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, 0444, nouveau_hwmon_show_temp1_auto_point1_pwm, NULL, 0); static ssize_t @@ -92,7 +92,7 @@ nouveau_...

...--git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c b/drivers/gpu/drm/nouveau/nouveau_hwmon.c > index a7db7c31064b..e844be49e11e 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_hwmon.c > +++ b/drivers/gpu/drm/nouveau/nouveau_hwmon.c > @@ -41,7 +41,7 @@ static ssize_t > nouveau_hwmon_show_temp1_auto_point1_pwm(struct device *d, > struct device_attribute *a, char *buf) > { > - return snprintf(buf, PAGE_SIZE, "%d\n", 100); > + return sysfs_emit(buf, "%d\n", 100); > } > static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, 0444, > nouveau_hwmon_show_temp1_...

...are: Other Status: NEW Version: unspecified Component: Driver/nouveau Product: xorg When I have done the following: echo 1 > /sys/class/hwmon/hwmon0/pwm1_enable echo 30 > /sys/class/hwmon/hwmon0/pwm1 pwm1=30 pwm1_enable=1 pwm1_max=100 pwm1_min=0 temp1_auto_point1_pwm=100 temp1_auto_point1_temp=90000 temp1_auto_point1_temp_hyst=3000 temp1_crit=115000 temp1_crit_hyst=2000 temp1_emergency=135000 temp1_emergency_hyst=5000 temp1_input=41000 temp1_max=95000 temp1_max_hyst=3000 update_rate=1000 and then do hibernate/restore, I get this: pwm1=100 pwm1_enable=1 pwm1_m...

...t temp = nvkm_therm_temp_get(therm); if (temp < 0) return temp; - return snprintf(buf, PAGE_SIZE, "%d\n", temp * 1000); + return (temp * 1000); } -static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, nouveau_hwmon_show_temp, - NULL, 0); static ssize_t nouveau_hwmon_show_temp1_auto_point1_pwm(struct device *d, @@ -60,7 +56,7 @@ nouveau_hwmon_show_temp1_auto_point1_pwm { return snprintf(buf, PAGE_SIZE, "%d\n", 100); } -static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, S_IRUGO, +static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, 0444, nouveau_hwmon_show_temp1_auto_point1_...

This v5 drops a check for attr_set. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4: * Rever const to struct attribute. Kbuild complains. v4 -> v5: * Drops a check for attr_set in

...turn snprintf(buf, PAGE_SIZE, "%d\n", temp * 1000); > + return (temp * 1000); > } > -static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, nouveau_hwmon_show_temp, > - NULL, 0); > > static ssize_t > nouveau_hwmon_show_temp1_auto_point1_pwm(struct device *d, > @@ -60,7 +56,7 @@ nouveau_hwmon_show_temp1_auto_point1_pwm > { > return snprintf(buf, PAGE_SIZE, "%d\n", 100); > } > -static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, S_IRUGO, > +static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, 0444, >...

This v6 fixes some comments pointed out by Martin Peres. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4: * Rever const to struct attribute. Kbuild complains. v4 -> v5: * Drops a check for

Kbuild sent me an e-mail due to a fixup I introduced in v3. It complains due to an incompatible pointer type and it doesn't build. This version reverts it. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4:

Hi, this is version v3 with some fix-ups: Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits This patchseries replaces the deprecated hwmon_device_register function with the new one hwmon_device_register_with_info. It also does some cleanup. Here

This v8 fixes removes dummy functions which only had a return and moves the code into the switch statements. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4: * Rever const to struct attribute. Kbuild

This v7 fixes removes dummy functions which only had a return and moves the code into the switch statements. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4: * Rever const to struct attribute. Kbuild

Hi! This patchseries replaces the deprecated hwmon_device_register function with the new one hwmon_device_register_with_info. It also does some cleanup. Here is the list of patches and what they do: 1/ Adds config structures for all sensors and their possible settings. This patch and the next one are just preparing the code for what it comes. 2/ Now everything goes through