Deepak R Varma
2023-Mar-01 19:35 UTC
[Nouveau] [PATCH RESEND] drm/nouveau/hwmon: Use sysfs_emit in show function callsbacks
According to Documentation/filesystems/sysfs.rst, the show() callback function of kobject attributes should strictly use sysfs_emit() instead of sprintf() family functions. So, make this change. Issue identified using the coccinelle device_attr_show.cocci script. Signed-off-by: Deepak R Varma <drv at mailo.com> --- Note: Resending the patch for review and feedback. No functional changes. drivers/gpu/drm/nouveau/nouveau_hwmon.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c b/drivers/gpu/drm/nouveau/nouveau_hwmon.c index a7db7c31064b..e844be49e11e 100644 --- a/drivers/gpu/drm/nouveau/nouveau_hwmon.c +++ b/drivers/gpu/drm/nouveau/nouveau_hwmon.c @@ -41,7 +41,7 @@ static ssize_t nouveau_hwmon_show_temp1_auto_point1_pwm(struct device *d, struct device_attribute *a, char *buf) { - return snprintf(buf, PAGE_SIZE, "%d\n", 100); + return sysfs_emit(buf, "%d\n", 100); } static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, 0444, nouveau_hwmon_show_temp1_auto_point1_pwm, NULL, 0); @@ -54,8 +54,8 @@ nouveau_hwmon_temp1_auto_point1_temp(struct device *d, struct nouveau_drm *drm = nouveau_drm(dev); struct nvkm_therm *therm = nvxx_therm(&drm->client.device); - return snprintf(buf, PAGE_SIZE, "%d\n", - therm->attr_get(therm, NVKM_THERM_ATTR_THRS_FAN_BOOST) * 1000); + return sysfs_emit(buf, "%d\n", + therm->attr_get(therm, NVKM_THERM_ATTR_THRS_FAN_BOOST) * 1000); } static ssize_t nouveau_hwmon_set_temp1_auto_point1_temp(struct device *d, @@ -87,8 +87,8 @@ nouveau_hwmon_temp1_auto_point1_temp_hyst(struct device *d, struct nouveau_drm *drm = nouveau_drm(dev); struct nvkm_therm *therm = nvxx_therm(&drm->client.device); - return snprintf(buf, PAGE_SIZE, "%d\n", - therm->attr_get(therm, NVKM_THERM_ATTR_THRS_FAN_BOOST_HYST) * 1000); + return sysfs_emit(buf, "%d\n", + therm->attr_get(therm, NVKM_THERM_ATTR_THRS_FAN_BOOST_HYST) * 1000); } static ssize_t nouveau_hwmon_set_temp1_auto_point1_temp_hyst(struct device *d, -- 2.34.1
Lyude Paul
2023-Mar-07 00:20 UTC
[Nouveau] [PATCH RESEND] drm/nouveau/hwmon: Use sysfs_emit in show function callsbacks
Reviewed-by: Lyude Paul <lyude at redhat.com> Will push upstream in a moment On Thu, 2023-03-02 at 01:05 +0530, Deepak R Varma wrote:> According to Documentation/filesystems/sysfs.rst, the show() callback > function of kobject attributes should strictly use sysfs_emit() instead > of sprintf() family functions. So, make this change. > Issue identified using the coccinelle device_attr_show.cocci script. > > Signed-off-by: Deepak R Varma <drv at mailo.com> > --- > Note: > Resending the patch for review and feedback. No functional changes. > > > drivers/gpu/drm/nouveau/nouveau_hwmon.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c b/drivers/gpu/drm/nouveau/nouveau_hwmon.c > index a7db7c31064b..e844be49e11e 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_hwmon.c > +++ b/drivers/gpu/drm/nouveau/nouveau_hwmon.c > @@ -41,7 +41,7 @@ static ssize_t > nouveau_hwmon_show_temp1_auto_point1_pwm(struct device *d, > struct device_attribute *a, char *buf) > { > - return snprintf(buf, PAGE_SIZE, "%d\n", 100); > + return sysfs_emit(buf, "%d\n", 100); > } > static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, 0444, > nouveau_hwmon_show_temp1_auto_point1_pwm, NULL, 0); > @@ -54,8 +54,8 @@ nouveau_hwmon_temp1_auto_point1_temp(struct device *d, > struct nouveau_drm *drm = nouveau_drm(dev); > struct nvkm_therm *therm = nvxx_therm(&drm->client.device); > > - return snprintf(buf, PAGE_SIZE, "%d\n", > - therm->attr_get(therm, NVKM_THERM_ATTR_THRS_FAN_BOOST) * 1000); > + return sysfs_emit(buf, "%d\n", > + therm->attr_get(therm, NVKM_THERM_ATTR_THRS_FAN_BOOST) * 1000); > } > static ssize_t > nouveau_hwmon_set_temp1_auto_point1_temp(struct device *d, > @@ -87,8 +87,8 @@ nouveau_hwmon_temp1_auto_point1_temp_hyst(struct device *d, > struct nouveau_drm *drm = nouveau_drm(dev); > struct nvkm_therm *therm = nvxx_therm(&drm->client.device); > > - return snprintf(buf, PAGE_SIZE, "%d\n", > - therm->attr_get(therm, NVKM_THERM_ATTR_THRS_FAN_BOOST_HYST) * 1000); > + return sysfs_emit(buf, "%d\n", > + therm->attr_get(therm, NVKM_THERM_ATTR_THRS_FAN_BOOST_HYST) * 1000); > } > static ssize_t > nouveau_hwmon_set_temp1_auto_point1_temp_hyst(struct device *d,-- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat
Possibly Parallel Threads
- [PATCH RESEND] drm/nouveau/hwmon: Use sysfs_emit in show function callsbacks
- [PATCH] drm/nouveau/hwmon: Uninitialized variables in sysfs
- [PATCH] drm/nouveau/hwmon: Uninitialized variables in sysfs
- [PATCH] drm/nouveau/hwmon: potential uninitialized variables
- [PATCH 0/3] Several hwmon fixes