search for: tblx

...trying to use clang as a drop-in replacement for the gcc come with Android NDK. I found that MC/ELF doesn't not handle Thumb functions properly, e.g., bit 0 of the function name in the .symtab is not set to 1, and some thumb instructions are not generated correctly, e.g., the addresses for tBL/tBLX are not calculated right. With that attached patch, we can compile and run some (not all) Android NDK samples without problem. The attached initial patch 1. sets bit 0 of the function address of thumb function in .symtab ("T is 1 if the target symbol S has type STT_FUNC and the symbol...

...clang as a drop-in replacement for the gcc come with > Android NDK. I found that MC/ELF doesn't not handle Thumb functions properly, > e.g., bit 0 of the function name in the .symtab is not set to 1, and some thumb > instructions are not generated correctly, e.g., the addresses for tBL/tBLX are > not calculated right. > > With that attached patch, we can compile and run some (not all) Android > NDK samples without problem. > > The attached initial patch > 1. sets bit 0 of the function address of thumb function in .symtab > ("T is 1 if the target symbol...

...get its own tests once it is able to. .ll -> .s test added. As far as I can tell .ll -> .s and .ll -> .o go different paths, so I have both .ll->.s and .ll -> .o in the test case The revised patches (with tests in .diff) are attached. patch-2-3.diff: fixes target address tBL and tBLX and sets relocation type of tBL/tBLX to R_ARM_THM_CALL (ARM ELF 4.7.1.6) patch-4.diff: adds some attributes to attribute section when cpu is "xscale" (this is what used in Android NDK, when architecture is ARMv5) Thanks, // koan-sin tan -------------- next part -------------- A no...

> Thanks for the review and checkin. Thanks for the patch! > Regarding elf-thumbfunc-reloc.ll, it seems to me that current ARMAsmParser > doesn't recognize "(PLT)", so something like "bl foo(PLT)" doesn't work > consequently. And I don't know how to write .s to test this without (PLT). NP. Can you just add that as a FIXME in elf-thumbfunc-reloc.ll?

...clang as a drop-in replacement for the gcc come with > Android NDK. I found that MC/ELF doesn't not handle Thumb functions properly, > e.g., bit 0 of the function name in the .symtab is not set to 1, and some thumb > instructions are not generated correctly, e.g., the addresses for tBL/tBLX are > not calculated right. > > With that attached patch, we can compile and run some (not all) Android > NDK samples without problem. > > The attached initial patch > 1. sets bit 0 of the function address of thumb function in .symtab >   ("T is 1 if the target symbol S...

Hi, While working on https://reviews.llvm.org/D79785, we wanted to define foldMemoryOperandImpl hook for Thumb1, that folds load, indirect call to direct call tLDRpci, tBLX -> tBL. This triggered an assertion error with expensive checks turned on in MachineVerifier because the newly created tBL insn by Thumb1InstrInfo::foldMemoryOperandImpl had memory operands of LoadMI attached by TargetInstrInfo::foldMemoryOperand, which is done unconditionally: // Copy the memo...

...t; On Sep 7, 2020, at 2:17 AM, Prathamesh Kulkarni via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Hi, > While working on https://reviews.llvm.org/D79785, we wanted to define > foldMemoryOperandImpl hook for Thumb1, that folds load, indirect call > to direct call tLDRpci, tBLX -> tBL. This triggered an assertion > error with expensive checks turned on in MachineVerifier because the > newly created tBL insn by > Thumb1InstrInfo::foldMemoryOperandImpl had memory operands of LoadMI > attached by TargetInstrInfo::foldMemoryOperand, which is done > unconditi...