search for: subtargetmap

...ctiveRelocModel(TT, RM), getEffectiveCodeModel(CM), OL), TargetABI(computeTargetABI(TT, CPU, Options)), TLOF(createTLOF(getTargetTriple())), isLittle(isLittle) { ... } It does not create a separate Subtarget, and its getSubtargetImpl() tries to get the value from SubtargetMap. Is there any downside to keep BPFTargetMachine as is? Or it is worthwhile to implement it in a similar way to X86/ARM? Thanks! Yonghong -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20170822/d77e879a/atta...

...deModel(CM), OL), >> TargetABI(computeTargetABI(TT, CPU, Options)), >> TLOF(createTLOF(getTargetTriple())), isLittle(isLittle) { >> ... >> } >> It does not create a separate Subtarget, and its getSubtargetImpl() tries to >> get the value >> from SubtargetMap. >> >> Is there any downside to keep BPFTargetMachine as is? Or it is worthwhile to >> implement it in a similar way to X86/ARM? > > My understanding is that SubtargetMap is used to allow different > subtargets to be returned for different functions/modules based on >...

...alue is known to be "false". I also made the following changes in the patch: 1. In the constructor of MachineFunction, call the version of getSubtargetImpl that takes a Function parameter, so that it gets the Subtarget specific to the Function being compiled. 2. Change ARMTargetMachine::SubtargetMap to be a DenseMap<Function*, unique_ptr<ARMSubtarget>>. This is just a temporary change to ease debugging and should be reverted to a StringMap or changed to another type of map later. On Mon, Nov 17, 2014 at 11:40 AM, Eric Christopher <echristo at gmail.com> wrote: > > &g...

...d discussion. A couple of other questions: - Subtarget lookup in XXXTargetMachine::getSubtargetImpl(const Function &F) seems a bit error-prone to me. If you add an option that is needed for subtargert creation as an attribute to Function, but forget to add it to the key that is used to search SubtargetMap, it can incorrectly return a cached subtarget when it should be creating a new one. Would it be better to generate a string key from the whole AttributeSet of the function (along with CPU and FeaturesStr and other options in TargetOptions, if necessary) and use it to do the lookup? The downside of...

...so made the following changes in the patch: >> >> 1. In the constructor of MachineFunction, call the version of >> getSubtargetImpl that takes a Function parameter, so that it gets the >> Subtarget specific to the Function being compiled. >> 2. Change ARMTargetMachine::SubtargetMap to be a DenseMap<Function*, >> unique_ptr<ARMSubtarget>>. This is just a temporary change to ease >> debugging and should be reverted to a StringMap or changed to another type >> of map later. >> >> >> On Mon, Nov 17, 2014 at 11:40 AM, Eric Christophe...

...;false". > > I also made the following changes in the patch: > > 1. In the constructor of MachineFunction, call the version of getSubtargetImpl that takes a Function parameter, so that it gets the Subtarget specific to the Function being compiled. > 2. Change ARMTargetMachine::SubtargetMap to be a DenseMap<Function*, unique_ptr<ARMSubtarget>>. This is just a temporary change to ease debugging and should be reverted to a StringMap or changed to another type of map later. > > > On Mon, Nov 17, 2014 at 11:40 AM, Eric Christopher <echristo at gmail.com <mailt...

...constructor of MachineFunction, call the version of >>>>>>>> getSubtargetImpl that takes a Function parameter, so that it gets the >>>>>>>> Subtarget specific to the Function being compiled. >>>>>>>> 2. Change ARMTargetMachine::SubtargetMap to be a >>>>>>>> DenseMap<Function*, unique_ptr<ARMSubtarget>>. This is just a temporary >>>>>>>> change to ease debugging and should be reverted to a StringMap or changed >>>>>>>> to another type of map later. >...

...t; >> I also made the following changes in the patch: >> >> 1. In the constructor of MachineFunction, call the version of getSubtargetImpl that takes a Function parameter, so that it gets the Subtarget specific to the Function being compiled. >> 2. Change ARMTargetMachine::SubtargetMap to be a DenseMap<Function*, unique_ptr<ARMSubtarget>>. This is just a temporary change to ease debugging and should be reverted to a StringMap or changed to another type of map later. >> >> >> On Mon, Nov 17, 2014 at 11:40 AM, Eric Christopher <echristo at gmail.c...

...;>>> 1. In the constructor of MachineFunction, call the version of >>>>>> getSubtargetImpl that takes a Function parameter, so that it gets the >>>>>> Subtarget specific to the Function being compiled. >>>>>> 2. Change ARMTargetMachine::SubtargetMap to be a DenseMap<Function*, >>>>>> unique_ptr<ARMSubtarget>>. This is just a temporary change to ease >>>>>> debugging and should be reverted to a StringMap or changed to another type >>>>>> of map later. >>>>>> &gt...

> On Nov 14, 2014, at 2:44 PM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote: > > +chrisb > >> On 2014-Nov-13, at 16:33, Akira Hatanaka <ahatanak at gmail.com> wrote: >> >> I'm working on fixing PR21471, which is about embedding codegen command line options into the bitcode as function or module-level attributes so that they don't get