search for: stream_encoder_asm

They are not needed since the section is defined in nasm.h. --- src/libFLAC/ia32/bitreader_asm.nasm | 4 ---- src/libFLAC/ia32/cpu_asm.nasm | 4 ---- src/libFLAC/ia32/fixed_asm.nasm | 4 ---- src/libFLAC/ia32/lpc_asm.nasm | 4 ---- src/libFLAC/ia32/stream_encoder_asm.nasm | 4 ---- 5 files changed, 20 deletions(-) diff --git a/src/libFLAC/ia32/bitreader_asm.nasm b/src/libFLAC/ia32/bitreader_asm.nasm index 4cd0ea2..b0f5ed6 100644 --- a/src/libFLAC/ia32/bitreader_asm.nasm +++ b/src/libFLAC/ia32/bitreader_asm.nasm @@ -590,7 +590,3 @@ cident FLAC__bitreader_read_r...

...type (7) does not match previous archive members cputype (16777223) (all members must match) /usr/bin/ranlib: archive member: .libs/libFLAC.a(lpc_asm.o) cputype (7) does not match previous archive members cputype (16777223) (all members must match) /usr/bin/ranlib: archive member: .libs/libFLAC.a(stream_encoder_asm.o) cputype (7) does not match previous archive members cputype (16777223) (all members must match) ranlib .libs/libFLAC.a ranlib: archive member: .libs/libFLAC.a(bitreader_asm.o) cputype (7) does not match previous archive members cputype (16777223) (all members must match) ranlib: archive member:...

...em. > 2) > VC projects contain relative paths such as "..\..\include". Is it better to > leave them as is or to change to something like "$(SolutionDir)include"? That sounds like a good idea. > 3) > Currently there are two ia32 asm files (bitreader_asm.nasm and stream_encoder_asm.nasm) > that are unused and not necessary to compile libFLAC: they offer no speed benefit > and the corresponding functions were commented out (*after* the release of 1.3.0): > > http://git.xiph.org/?p=flac.git;a=commitdiff;h=4eab6313cd2198b5647d925bdb3847590505fa21 > http...

...at if needed the files can be easily retrieved from the Git history. > > Should these patches also remove those .nasm files from the source tree or not? Yes. > (currently src/libFLAC/ia32 folder contains unused lpc_asm-unrolled.nasm > file, so why remove unused bitreader_asm.nasm and stream_encoder_asm.nasm files?) I don't see any point in keeping files in release tarballs or in Git that provide no value. Documentation provides value, but unused source code does not. All the various build system files should be cleansed of references to these files and then we need a single commit that rem...

...is 15, so it's not a problem) 2) "mov cl, ..." was replaced with "mov ecx, ..." (again Agner Fog, optimizing_assembly.pdf) summary: write to a partial register may result in false dependencies between instructions, so it is better to avoid it. (also bitreader_asm.nasm and stream_encoder_asm.nasm both have "mov ecx, ..." instructions, and no "mov cl, ..."). -------------- next part -------------- A non-text attachment was scrubbed... Name: cl_to_ecx.patch Type: application/octet-stream Size: 2822 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-d...

...one on a line without a colon might be in error cpu_asm.nasm:118: warning: label alone on a line without a colon might be in error fixed_asm.nasm:309: warning: label alone on a line without a colon might be in error lpc_asm.nasm:1508: warning: label alone on a line without a colon might be in error stream_encoder_asm.nasm:156: warning: label alone on a line without a colon might be in error ... all of which are for "end" and actually harmless (just annoying.) I suggest that .note.GNU-stack be limited to elf targets, like: diff --git a/src/libFLAC/ia32/nasm.h b/src/libFLAC/ia32/nasm.h index abd01c4...

Hi all, It sees that the most serious bug in the flac bug tracker: https://sourceforge.net/p/flac/bugs/413/ has been fixed in git. This fix alone is worth a new release so its time to work towards one. Things I need to do for this new release: * Deal with all current patches on the mailing list. * Review all bugs reported against 1.3.0 on the sf.net. * Testing and coordination of testing

Previously I wrote that precompute_partition_info_sums_32bit_asm_ia32_() only makes encoding slower. Now I managed to compile flac with GCC 4.8.1, with this function enabled and disabled. NASM was enabled, SSE intrinsics disabled. Then I added -msse option (so that all C code was compiled with -msse), then -msse2 and so on. Input file for test: 44.1kHz/16bit/stereo; best compression mode (flac

...o rename FLAC.sln to FLAC-vs2005.sln?) What do you think? 2) VC projects contain relative paths such as "..\..\include". Is it better to leave them as is or to change to something like "$(SolutionDir)include"? 3) Currently there are two ia32 asm files (bitreader_asm.nasm and stream_encoder_asm.nasm) that are unused and not necessary to compile libFLAC: they offer no speed benefit and the corresponding functions were commented out (*after* the release of 1.3.0): http://git.xiph.org/?p=flac.git;a=commitdiff;h=4eab6313cd2198b5647d925bdb3847590505fa21 http://git.xiph.org/?p=flac.g...

Erik de Castro Lopo <mle+la at mega-nerd.com> ?????(?) ? ????? ?????? Thu, 19 Jun 2014 17:01:26 +0400: >> (currently src/libFLAC/ia32 folder contains unused lpc_asm-unrolled.nasm >> file, so why remove unused bitreader_asm.nasm and stream_encoder_asm.nasm files?) > > I don't see any point in keeping files in release tarballs or in Git that > provide no value. Documentation provides value, but unused source code > does not. Well, lpc_asm-unrolled.nasm exists only in Git but not in any of release tarballs. And there are no signif...

Erik de Castro Lopo wrote: >> 3) >> Currently there are two ia32 asm files (bitreader_asm.nasm and stream_encoder_asm.nasm) >> that are unused and not necessary to compile libFLAC: they offer no speed benefit >> and the corresponding functions were commented out (*after* the release of 1.3.0): >> >> http://git.xiph.org/?p=flac.git;a=commitdiff;h=4eab6313cd2198b5647d925bdb3847590505fa21...

...mark that commit so > that if needed the files can be easily retrieved from the Git history. Should these patches also remove those .nasm files from the source tree or not? (currently src/libFLAC/ia32 folder contains unused lpc_asm-unrolled.nasm file, so why remove unused bitreader_asm.nasm and stream_encoder_asm.nasm files?)

...>What do you think? > > >2) >VC projects contain relative paths such as "..\..\include". Is it better to >leave them as is or to change to something like "$(SolutionDir)include"? > >3) >Currently there are two ia32 asm files (bitreader_asm.nasm and >stream_encoder_asm.nasm) that are unused and not necessary to compile libFLAC: >they offer no speed benefit and the corresponding functions were commented out >(*after* the release of 1.3.0): > > http://git.xiph.org/?p=flac.git;a=commitdiff;h=4eab6313cd2198b5647d925bdb3847590505fa21 > http://gi...

...decoder_aspect.o .libs/ogg_encoder_aspect.o .libs/ ogg_helper.o .libs/ogg_mapping.o .libs/libFLAC.lax/libFLAC-asm.a/ bitreader_asm.o .libs/libFLAC.lax/libFLAC-asm.a/cpu_asm.o .libs/ libFLAC.lax/libFLAC-asm.a/fixed_asm.o .libs/libFLAC.lax/libFLAC-asm.a/ lpc_asm.o .libs/libFLAC.lax/libFLAC-asm.a/stream_encoder_asm.o -lm / usr/local/lib/libogg.dylib -install_name /usr/local/lib/libFLAC. 8.dylib -Wl,-compatibility_version -Wl,11 -Wl,-current_version -Wl,11.0 ld: .libs/libFLAC.lax/libFLAC-asm.a/bitreader_asm.o has external relocation entries in non-writable section (__TEXT,__text) for symbols: FLAC__crc...