flac dev - Jan 2014 - PATCH for lpc_asm.nasm

1) Two comments ";ASSERT(lp_quantization <= 31)" in the new
functions ..._wide_asm_ia32()
-- just to mention this constraint.
(max. possible value of lp_quantization is 15, so it's not a problem)


2) "mov cl, ..." was replaced with "mov ecx, ..." (again
Agner Fog, optimizing_assembly.pdf)

summary: write to a partial register may result in false dependencies
between instructions, so it is better to avoid it.
(also bitreader_asm.nasm and stream_encoder_asm.nasm both have "mov ecx,
..."
instructions, and no "mov cl, ...").
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cl_to_ecx.patch
Type: application/octet-stream
Size: 2822 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20140114/10cb006b/attachment.obj

lvqcl wrote:
> 1) Two comments ";ASSERT(lp_quantization <= 31)" in the new
functions ..._wide_asm_ia32()
> -- just to mention this constraint.
> (max. possible value of lp_quantization is 15, so it's not a problem)
> 
> 
> 2) "mov cl, ..." was replaced with "mov ecx, ..."
(again Agner Fog, optimizing_assembly.pdf)
> 
> summary: write to a partial register may result in false dependencies
> between instructions, so it is better to avoid it.
> (also bitreader_asm.nasm and stream_encoder_asm.nasm both have "mov
ecx, ..."
> instructions, and no "mov cl, ...").
Applied. Thanks.

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/