search for: std_utils_test

--- common/mlstdutils/std_utils_tests.ml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/common/mlstdutils/std_utils_tests.ml b/common/mlstdutils/std_utils_tests.ml index 81f512cbf..f7b0247a4 100644 --- a/common/mlstdutils/std_utils_tests.ml +++ b/common/mlstdutils/std_utils_tests.ml @@ -29,6 +29,11 @@ let assert_equ...

...\n from the end of a string if present, else leaves the string alone. I believe I found the only (two) places where such a function is used, but there may be a few more lurking. --- common/mlstdutils/std_utils.ml | 7 +++++++ common/mlstdutils/std_utils.mli | 2 ++ common/mlstdutils/std_utils_tests.ml | 10 ++++++++++ mllib/common_utils.ml | 10 ++-------- v2v/linux_bootloaders.ml | 8 ++------ 5 files changed, 23 insertions(+), 14 deletions(-) diff --git a/common/mlstdutils/std_utils.ml b/common/mlstdutils/std_utils.ml index 374507662..b731b8fd5 100644 --- a/com...

...ls/Makefile.am b/mlstdutils/Makefile.am index d29255e..2b4aed8 100644 --- a/mlstdutils/Makefile.am +++ b/mlstdutils/Makefile.am @@ -19,9 +19,12 @@ include $(top_srcdir)/subdir-rules.mk EXTRA_DIST = \ $(SOURCES_MLI) \ - $(SOURCES_ML) \ + $(filter-out $(CONFIGURE_GENERATED_ML),$(SOURCES_ML)) \ std_utils_tests.ml +CONFIGURE_GENERATED_ML = \ + guestfs_config.ml + SOURCES_MLI = if HAVE_BYTES_COMPAT_ML @@ -41,7 +44,7 @@ SOURCES_ML += bytes.ml endif SOURCES_ML += \ - guestfs_config.ml \ + $(CONFIGURE_GENERATED_ML) \ stringMap.ml \ stringSet.ml \ std_utils.ml -- 2.23.0

...POTFILES-ml +++ b/po/POTFILES-ml @@ -3,32 +3,23 @@ common/mlcustomize/customize_cmdline.ml common/mlcustomize/firstboot.ml common/mlgettext/common_gettext.ml common/mlpcre/PCRE.ml -common/mlpcre/pcre_tests.ml common/mlstdutils/guestfs_config.ml common/mlstdutils/std_utils.ml -common/mlstdutils/std_utils_tests.ml common/mlstdutils/stringMap.ml common/mlstdutils/stringSet.ml common/mltools/JSON.ml common/mltools/JSON_parser.ml -common/mltools/JSON_parser_tests.ml -common/mltools/JSON_tests.ml common/mltools/URI.ml common/mltools/checksums.ml common/mltools/curl.ml common/mltools/getopt.ml -common...

...a/.gitignore b/.gitignore index 302aa2d81..3aca17f67 100644 --- a/.gitignore +++ b/.gitignore @@ -130,7 +130,6 @@ Makefile.in /common/mlstdutils/.depend /common/mlstdutils/bytes.ml /common/mlstdutils/guestfs_config.ml -/common/mlstdutils/libdir.ml /common/mlstdutils/oUnit-* /common/mlstdutils/std_utils_tests /common/mlutils/.depend diff --git a/common/mlstdutils/Makefile.am b/common/mlstdutils/Makefile.am index 5208e491f..2376ac6a6 100644 --- a/common/mlstdutils/Makefile.am +++ b/common/mlstdutils/Makefile.am @@ -35,7 +35,6 @@ endif SOURCES_ML += \ guestfs_config.ml \ - libdir.ml \ stringMap.m...

...ndex 233a8c536..bb7026537 100644 --- a/.gitignore +++ b/.gitignore @@ -139,6 +139,7 @@ Makefile.in /common/mlprogress/.depend /common/mlstdutils/.depend /common/mlstdutils/bytes.ml +/common/mlstdutils/bytes.mli /common/mlstdutils/guestfs_config.ml /common/mlstdutils/oUnit-* /common/mlstdutils/std_utils_tests diff --git a/m4/guestfs-ocaml.m4 b/m4/guestfs-ocaml.m4 index 94c24bc04..e08f40a02 100644 --- a/m4/guestfs-ocaml.m4 +++ b/m4/guestfs-ocaml.m4 @@ -175,7 +175,7 @@ AM_CONDITIONAL([HAVE_OCAML_GETTEXT], dnl Create the backwards compatibility Bytes module for OCaml < 4.02. mkdir -p common/mlstdut...

...-3,32 +3,23 @@ common/mlcustomize/customize_cmdline.ml > common/mlcustomize/firstboot.ml > common/mlgettext/common_gettext.ml > common/mlpcre/PCRE.ml > -common/mlpcre/pcre_tests.ml > common/mlstdutils/guestfs_config.ml > common/mlstdutils/std_utils.ml > -common/mlstdutils/std_utils_tests.ml > common/mlstdutils/stringMap.ml > common/mlstdutils/stringSet.ml > common/mltools/JSON.ml > common/mltools/JSON_parser.ml > -common/mltools/JSON_parser_tests.ml > -common/mltools/JSON_tests.ml > common/mltools/URI.ml > common/mltools/checksums.ml > common/mlto...

...@@ -23,37 +22,27 @@ common/mlcustomize/customize_cmdline.ml common/mlcustomize/firstboot.ml common/mlgettext/common_gettext.ml common/mlpcre/PCRE.ml -common/mlpcre/pcre_tests.ml common/mlprogress/progress.ml common/mlstdutils/guestfs_config.ml common/mlstdutils/std_utils.ml -common/mlstdutils/std_utils_tests.ml common/mlstdutils/stringMap.ml common/mlstdutils/stringSet.ml common/mltools/JSON.ml common/mltools/JSON_parser.ml -common/mltools/JSON_parser_tests.ml -common/mltools/JSON_tests.ml common/mltools/URI.ml common/mltools/checksums.ml common/mltools/curl.ml common/mltools/getopt.ml -common...

...| 151 +++++ common/mlstdutils/dummy.c | 2 + {mllib => common/mlstdutils}/guestfs_config.ml.in | 0 common/mlstdutils/std_utils.ml | 664 +++++++++++++++++++++ common/mlstdutils/std_utils.mli | 338 +++++++++++ common/mlstdutils/std_utils_tests.ml | 95 +++ {mllib => common/mlstdutils}/stringMap.ml | 0 {mllib => common/mlstdutils}/stringMap.mli | 0 configure.ac | 3 +- customize/Makefile.am | 8 +- customize/SELinux_relabel.ml...

The previously selected 'atomic' recipe resulted in 2GB swap in a 6GB volume. Also, we don't really need the boot partition, so just create a partition using the whole disk space. --- builder/templates/debian.preseed | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/builder/templates/debian.preseed b/builder/templates/debian.preseed index

Commit 0a94cae15bae7cecb725e78e485708694d347612 added useful headings to parts of the configure script. This refactors the code by adding a common macro (‘HEADING’), and also changes the output so it's clearer at a glance: --- Checking for Haskell --- checking for ghc... (cached) ghc --- Checking for PHP --- checking for php... (cached) php checking for phpize... (cached) phpize

This is just the utilities part of the patch series from: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html I believe this addresses everything raised in comments on that patch series. Rich.

v1: https://www.redhat.com/archives/libguestfs/2017-September/msg00135.html v2: https://www.redhat.com/archives/libguestfs/2017-September/msg00158.html v3 is almost identical to v2, but I have added 4 extra commits to almost finish the job of replacing Str everywhere possible (note it's not possible to replace Str in common/mlstdutils or the generator because those are pure OCaml). As

https://bugzilla.redhat.com/show_bug.cgi?id=1570407 This turned into quite an in-depth refactoring of how we handle OVAs. It also fixes a potential security issue. Rich.

This turned out to be rather more involved than I thought. We have lots of utility functions, spread all over the repository, with not a lot of structure. This moves many of them under common/ and structures them so there are clear dependencies. This doesn't complete the job by any means. Other items I had on my to-do list for this change were: - Split up mllib/common_utils into: -

Miscellaneous refactoring, but the main one is to rename mllib/ as common/mltools/ Rich.

...ES-ml +++ b/po/POTFILES-ml @@ -18,8 +18,6 @@ builder/sigchecker.ml builder/simplestreams_parser.ml builder/sources.ml builder/utils.ml -builder/yajl.ml -builder/yajl_tests.ml common/mlaugeas/augeas.ml common/mlgettext/common_gettext.ml common/mlpcre/PCRE.ml @@ -31,6 +29,8 @@ common/mlstdutils/std_utils_tests.ml common/mlstdutils/stringMap.ml common/mlstdutils/stringSet.ml common/mltools/JSON.ml +common/mltools/JSON_parser.ml +common/mltools/JSON_parser_tests.ml common/mltools/JSON_tests.ml common/mltools/URI.ml common/mltools/checksums.ml -- 2.18.0

Replace GUESTFSD_EXT_CMD with a command line option ‘./guestfsd --print-external-commands’

...| 46 -------- 30 files changed, 371 insertions(+), 97 deletions(-) diff --git a/.gitignore b/.gitignore index 934d9f291..b20b5f5b8 100644 --- a/.gitignore +++ b/.gitignore @@ -130,6 +130,9 @@ Makefile.in /common/mlstdutils/libdir.ml /common/mlstdutils/oUnit-* /common/mlstdutils/std_utils_tests +/common/mlutils/.depend +/common/mlutils/c_utils_unit_tests +/common/mlutils/oUnit-* /common/mlvisit/.depend /common/mlvisit/visit_tests /common/mlxml/.depend diff --git a/Makefile.am b/Makefile.am index b3eb35349..509bcae83 100644 --- a/Makefile.am +++ b/Makefile.am @@ -156,18 +156,18 @@ SUBD...

v5: https://www.redhat.com/archives/libguestfs/2017-June/msg00065.html Since v5, this now implements inspection almost completely for Linux and Windows guests. Rich.