Libguestfs - Jan 2020 - Re: [v2v PATCH] po: do not extract tests

They do not contain messages.
---
 Makefile.am    |  1 +
 po/POTFILES-ml | 11 -----------
 2 files changed, 1 insertion(+), 11 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 4dde5002..46a52ca3 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -115,6 +115,7 @@ po/POTFILES-ml: configure.ac
 	grep -v '^common/mlprogress/' | \
 	grep -v '^common/mlvisit/' | \
 	grep -v '^v2v/config.ml$$' | \
+	grep -v -E '.*_tests\.ml$$' | \
 	LC_ALL=C sort > $@-t
 	mv $@-t $@
 
diff --git a/po/POTFILES-ml b/po/POTFILES-ml
index dae9bd1a..7512d63b 100644
--- a/po/POTFILES-ml
+++ b/po/POTFILES-ml
@@ -3,32 +3,23 @@ common/mlcustomize/customize_cmdline.ml
 common/mlcustomize/firstboot.ml
 common/mlgettext/common_gettext.ml
 common/mlpcre/PCRE.ml
-common/mlpcre/pcre_tests.ml
 common/mlstdutils/guestfs_config.ml
 common/mlstdutils/std_utils.ml
-common/mlstdutils/std_utils_tests.ml
 common/mlstdutils/stringMap.ml
 common/mlstdutils/stringSet.ml
 common/mltools/JSON.ml
 common/mltools/JSON_parser.ml
-common/mltools/JSON_parser_tests.ml
-common/mltools/JSON_tests.ml
 common/mltools/URI.ml
 common/mltools/checksums.ml
 common/mltools/curl.ml
 common/mltools/getopt.ml
-common/mltools/getopt_tests.ml
-common/mltools/machine_readable_tests.ml
 common/mltools/planner.ml
 common/mltools/regedit.ml
 common/mltools/registry.ml
-common/mltools/tools_messages_tests.ml
 common/mltools/tools_utils.ml
-common/mltools/tools_utils_tests.ml
 common/mltools/urandom.ml
 common/mltools/xpath_helpers.ml
 common/mlutils/c_utils.ml
-common/mlutils/c_utils_unit_tests.ml
 common/mlutils/unix_utils.ml
 common/mlv2v/uefi.ml
 common/mlxml/xml.ml
@@ -86,9 +77,7 @@ v2v/target_bus_assignment.ml
 v2v/types.ml
 v2v/utils.ml
 v2v/v2v.ml
-v2v/v2v_unit_tests.ml
 v2v/vCenter.ml
 v2v/var_expander.ml
-v2v/var_expander_tests.ml
 v2v/windows.ml
 v2v/windows_virtio.ml
-- 
2.24.1

On Wed, Dec 18, 2019 at 11:13:48AM +0100, Pino Toscano
wrote:
> They do not contain messages.
> ---
>  Makefile.am    |  1 +
>  po/POTFILES-ml | 11 -----------
>  2 files changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 4dde5002..46a52ca3 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -115,6 +115,7 @@ po/POTFILES-ml: configure.ac
>  	grep -v '^common/mlprogress/' | \
>  	grep -v '^common/mlvisit/' | \
>  	grep -v '^v2v/config.ml$$' | \
> +	grep -v -E '.*_tests\.ml$$' | \
>  	LC_ALL=C sort > $@-t
>  	mv $@-t $@
>  
> diff --git a/po/POTFILES-ml b/po/POTFILES-ml
> index dae9bd1a..7512d63b 100644
> --- a/po/POTFILES-ml
> +++ b/po/POTFILES-ml
> @@ -3,32 +3,23 @@ common/mlcustomize/customize_cmdline.ml
>  common/mlcustomize/firstboot.ml
>  common/mlgettext/common_gettext.ml
>  common/mlpcre/PCRE.ml
> -common/mlpcre/pcre_tests.ml
>  common/mlstdutils/guestfs_config.ml
>  common/mlstdutils/std_utils.ml
> -common/mlstdutils/std_utils_tests.ml
>  common/mlstdutils/stringMap.ml
>  common/mlstdutils/stringSet.ml
>  common/mltools/JSON.ml
>  common/mltools/JSON_parser.ml
> -common/mltools/JSON_parser_tests.ml
> -common/mltools/JSON_tests.ml
>  common/mltools/URI.ml
>  common/mltools/checksums.ml
>  common/mltools/curl.ml
>  common/mltools/getopt.ml
> -common/mltools/getopt_tests.ml
> -common/mltools/machine_readable_tests.ml
>  common/mltools/planner.ml
>  common/mltools/regedit.ml
>  common/mltools/registry.ml
> -common/mltools/tools_messages_tests.ml
>  common/mltools/tools_utils.ml
> -common/mltools/tools_utils_tests.ml
>  common/mltools/urandom.ml
>  common/mltools/xpath_helpers.ml
>  common/mlutils/c_utils.ml
> -common/mlutils/c_utils_unit_tests.ml
>  common/mlutils/unix_utils.ml
>  common/mlv2v/uefi.ml
>  common/mlxml/xml.ml
> @@ -86,9 +77,7 @@ v2v/target_bus_assignment.ml
>  v2v/types.ml
>  v2v/utils.ml
>  v2v/v2v.ml
> -v2v/v2v_unit_tests.ml
>  v2v/vCenter.ml
>  v2v/var_expander.ml
> -v2v/var_expander_tests.ml
>  v2v/windows.ml
>  v2v/windows_virtio.ml
I guess so.  Is there some penalty with running gettext on these files?

Anyway, it's fine so ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html

On Thursday, 9 January 2020 14:30:13 CET Richard W.M. Jones
wrote:
> I guess so.  Is there some penalty with running gettext on these files?
Not really -- not parsing them saves some time (not much), and removes
the risk of accidentally adding things that are extracted as
translatable strings in tests.

-- 
Pino Toscano