search for: spagetty

There is a bug in the way which klibc/usr/utils/dmesg.c tries to strip the initial <[0-7]> from kernel messages. The bug causes every other numerical digit to be stripped from the output. Fixed. A bug report with lots of details has been filed for Debian and Ubuntu: * http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=483186 * https://bugs.launchpad.net/ubuntu/+source/klibc/+bug/235282

Hi all I am sure that there is some mention of this error in the docs somewhere but I could not find it. So, sorry for repeating it here. I have installed samba 2.0.3 on solaris 2.5.1 I carried out all the tests described in the documentation. They were all successful. Bu from an NT server I can't do this net use z: \\server_name\\tmp System error 86 has occurred The specified network

Hi, I have a little trickky thing i wanted to do with puppet, mainly this is configuring web host on servers. I have a tree like this : NODE - WEB -APACHE - 1.x - 2.x - FTP - VSFTP - PROFTPD - STATS -AWSTATS - if FTP then configure awstats for awstats - URCHIN5 So my issue is that i want to be able to have

...round = vhost_exceeds_weight(++recv_pkts, total_len))); >> + >> + if (unlikely(busyloop_intr || next_round)) >> vhost_poll_queue(&vq->poll); >> else >> vhost_net_enable_vq(net, vq); > > I'm afraid with this addition the code is too much like spagetty. What > does next_round mean? Just that we are breaking out of loop? Yes, we can have a better name of course. > That is > what goto is for... Either let's have for(;;) with goto/break to get > outside or a while loop with a condition. Both is just unreadable. > > All t...

...round = vhost_exceeds_weight(++recv_pkts, total_len))); >> + >> + if (unlikely(busyloop_intr || next_round)) >> vhost_poll_queue(&vq->poll); >> else >> vhost_net_enable_vq(net, vq); > > I'm afraid with this addition the code is too much like spagetty. What > does next_round mean? Just that we are breaking out of loop? Yes, we can have a better name of course. > That is > what goto is for... Either let's have for(;;) with goto/break to get > outside or a while loop with a condition. Both is just unreadable. > > All t...

I found an old R program I wrote som eyears back and I'd like to make work in 2.11.1 (or a more recent version), but am having two problems: 1. I can't seem to access the datafile it requires. I'm not sure where the default place that R looks to for files references within it is, or what exactly the format is for pulling in the data, by my own #comments from a few years ago

...> to be applied to -net first. It has lower risk and was much more easier to > be backported to stable trees. Then we can do the re-factor like this in > net-next. It makes the interfaces too messy. We are not in code freeze in -net - only feature freeze, so no reason to make code like spagetty, and it's only 25 lines changed as compared to 40. It's not a huge refactoring. It's just as easy to backport my patch too. You just drop the goto in the new code path we added. Let me show you (untested) - your patch is not smaller. Signed-off-by: Michael S. Tsirkin <mst at redha...

----- ???? ----- > On Wed, Nov 20, 2013 at 05:07:25PM +0800, Jason Wang wrote: > > When mergeable buffer were used, we only put the first page buf leave the > > rest > > of buffers in the virt queue. This will cause the driver could not get the > > correct head buffer any more. Fix this by dropping the rest of buffers for > > this > > packet. > > >

----- ???? ----- > On Wed, Nov 20, 2013 at 05:07:25PM +0800, Jason Wang wrote: > > When mergeable buffer were used, we only put the first page buf leave the > > rest > > of buffers in the virt queue. This will cause the driver could not get the > > correct head buffer any more. Fix this by dropping the rest of buffers for > > this > > packet. > > >

...gt; +??? if (unlikely(busyloop_intr || next_round)) > > > > ????????? vhost_poll_queue(&vq->poll); > > > > ????? else > > > > ????????? vhost_net_enable_vq(net, vq); > > > > > > I'm afraid with this addition the code is too much like spagetty. What > > > does next_round mean?? Just that we are breaking out of loop? > > > > > > Yes, we can have a better name of course. > > > > > > > That is > > > what goto is for...? Either let's have for(;;) with goto/break to get > &gt...

...gt; +??? if (unlikely(busyloop_intr || next_round)) > > > > ????????? vhost_poll_queue(&vq->poll); > > > > ????? else > > > > ????????? vhost_net_enable_vq(net, vq); > > > > > > I'm afraid with this addition the code is too much like spagetty. What > > > does next_round mean?? Just that we are breaking out of loop? > > > > > > Yes, we can have a better name of course. > > > > > > > That is > > > what goto is for...? Either let's have for(;;) with goto/break to get > &gt...

When the rx buffer is too small for a packet, we will discard the vq descriptor and retry it for the next packet: while ((sock_len = vhost_net_rx_peek_head_len(net, sock->sk, &busyloop_intr))) { ... /* On overrun, truncate and discard */ if (unlikely(headcount > UIO_MAXIOV)) { iov_iter_init(&msg.msg_iter, READ, vq->iov, 1, 1); err = sock->ops->recvmsg(sock,

When the rx buffer is too small for a packet, we will discard the vq descriptor and retry it for the next packet: while ((sock_len = vhost_net_rx_peek_head_len(net, sock->sk, &busyloop_intr))) { ... /* On overrun, truncate and discard */ if (unlikely(headcount > UIO_MAXIOV)) { iov_iter_init(&msg.msg_iter, READ, vq->iov, 1, 1); err = sock->ops->recvmsg(sock,

..._intr)) > + } while (!(next_round = vhost_exceeds_weight(++recv_pkts, total_len))); > + > + if (unlikely(busyloop_intr || next_round)) > vhost_poll_queue(&vq->poll); > else > vhost_net_enable_vq(net, vq); I'm afraid with this addition the code is too much like spagetty. What does next_round mean? Just that we are breaking out of loop? That is what goto is for... Either let's have for(;;) with goto/break to get outside or a while loop with a condition. Both is just unreadable. All these checks in 3 places are exactly the same on all paths and they are slo...

...l_len))); >>> + >>> +??? if (unlikely(busyloop_intr || next_round)) >>> ????????? vhost_poll_queue(&vq->poll); >>> ????? else >>> ????????? vhost_net_enable_vq(net, vq); >> >> I'm afraid with this addition the code is too much like spagetty. What >> does next_round mean?? Just that we are breaking out of loop? > > > Yes, we can have a better name of course. > > >> That is >> what goto is for...? Either let's have for(;;) with goto/break to get >> outside or a while loop with a condition.? Bot...

...gt;>> +??? if (unlikely(busyloop_intr || next_round)) >>>>> ????????? vhost_poll_queue(&vq->poll); >>>>> ????? else >>>>> ????????? vhost_net_enable_vq(net, vq); >>>> I'm afraid with this addition the code is too much like spagetty. What >>>> does next_round mean?? Just that we are breaking out of loop? >>> >>> Yes, we can have a better name of course. >>> >>> >>>> That is >>>> what goto is for...? Either let's have for(;;) with goto/break to get >...

...oop_intr || next_round)) > > > > > > ????????? vhost_poll_queue(&vq->poll); > > > > > > ????? else > > > > > > ????????? vhost_net_enable_vq(net, vq); > > > > > I'm afraid with this addition the code is too much like spagetty. What > > > > > does next_round mean?? Just that we are breaking out of loop? > > > > > > > > Yes, we can have a better name of course. > > > > > > > > > > > > > That is > > > > > what goto is for...? Ei...