search for: skalkoto

Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr> --- src/inspect-fs-unix.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/inspect-fs-unix.c b/src/inspect-fs-unix.c index 01a59f1..f55e53b 100644 --- a/src/inspect-fs-unix.c +++ b/src/inspect-fs-unix.c @@ -58,8 +58,8 @@ COMPILE_REGEXP (re_scie...

On 02/06/15 17:10, Richard W.M. Jones wrote: Hello, > On Fri, May 29, 2015 at 12:24:58PM +0300, Nikos Skalkotos wrote: >> + if (collect_coreos_inspection_info (g)) { >> + guestfs_int_free_inspect_info (g); >> + return NULL; >> + } > Although this is stylistic, I think it's easier to understand if > you change the if condition to: > > if (collect_coreos_inspe...

Use commandrvf() instead of commandvf() to execute e2fsck. A non-zero exit status does not always indicate a failure. Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr> --- daemon/ext2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/daemon/ext2.c b/daemon/ext2.c index 65ddae6..8ef6d5f 100644 --- a/daemon/ext2.c +++ b/daemon/ext2.c @@ -296,9 +296,9 @@ do_e2fsck (const char *device, ADD_ARG (argv, i, device)...

...bd'. Under an MBR partition table a slice will be used, so the name of the first partitions will be either `ada0s1a' or `vtbd0s1a'. Under a GPT partition table, where no slice is needed, the name of the first partition will be either `ada0p1' or `vtbd0p1'. Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr> --- src/guestfs-internal.h | 2 ++ src/inspect-fs-unix.c | 27 +++++++++++++++++++++++---- src/match.c | 25 +++++++++++++++++++++++++ 3 files changed, 50 insertions(+), 4 deletions(-) diff --git a/src/guestfs-internal.h b/src/guestfs-internal.h index 9936c...

Return it in the app2_epoch field of the guestfs_application2 struct Signed-off-by: Nikos Skalkotos <skalkoto@gmail.com> --- src/inspect-apps.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/src/inspect-apps.c b/src/inspect-apps.c index 8e645b7..bd4e6c1 100644 --- a/src/inspect-apps.c +++ b/src/inspect-apps.c @@ -439,6 +439,7 @@ list_applica...

...ou have this: for (fs = fses; *fs; fs += 2) { if (guestfs_int_check_for_filesystem_on (g, *fs)) { guestfs_int_free_inspect_info (g); return NULL; } } I don't see the bug. On 02/06/15 18:30, Richard W.M. Jones wrote: > On Tue, Jun 02, 2015 at 06:18:38PM +0300, Nikos Skalkotos wrote: >> On 02/06/15 17:10, Richard W.M. Jones wrote: >> Hello, >> >>> On Fri, May 29, 2015 at 12:24:58PM +0300, Nikos Skalkotos wrote: >>>> + if (collect_coreos_inspection_info (g)) { >>>> + guestfs_int_free_inspect_info (g); >>>&gt...

...h at all. The regular expression /dev/(ada{0,1}|vtbd) will match both: /dev/ada and /dev/ad. This is why I use "{0,1}" (=zero or one occurrence of the character a) Nikos On Tue 05 Nov 2013 01:42:44 PM EET, Richard W.M. Jones wrote: > On Tue, Nov 05, 2013 at 12:15:47PM +0200, Nikos Skalkotos wrote: >> The device name prefix for IDE hard drives used to be `ad' but now >> is `ada' (http://www.freebsd.org/doc/handbook/disks-naming.html). >> For virtio hard drives it is `vtbd'. >> >> Under an MBR partition table a slice will be used, so the name o...

Extend the guestfs_inspect_list_applications2 API call to work on Arch Linux guest images. Signed-off-by: Nikos Skalkotos <skalkoto@gmail.com> --- src/inspect-apps.c | 137 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 137 insertions(+) diff --git a/src/inspect-apps.c b/src/inspect-apps.c index 6fb9665..8e645b7 100644 --- a/src/inspect-apps.c +++ b/src/inspect-apps.c @@ -60,6 +60,7 @@...

...fs/tests/mountable' make: *** [check-am] Error 2 make: Leaving directory `/root/src/libguestfs/tests/mountable' I tried it on Debian Jessie and an updated Fedora 20 system. Any hints? Nikos On 03/12/14 01:53, Richard W.M. Jones wrote: > On Tue, Dec 02, 2014 at 07:11:55PM +0200, Nikos Skalkotos wrote: >> Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr> >> --- >> src/inspect-fs-unix.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/src/inspect-fs-unix.c b/src/inspect-fs-unix.c >> index 01a59f1..f55e53b 1006...

...tps://github.com/arvidjaar/bootinfoscript/blob/master/bootinfoscript#L2343-L2459 Those signatures (byte patterns) are from real mode machine code but this code is not generated by a compiler and does not change often. I’ve isolated and simplified the signatures database here: https://github.com/skalkoto/snf-image-creator/blob/develop/image_creator/bootloader.py and I was wondering if you care to add 2 new libguestfs API methods e.g.: char * guestfs_inspect_get_mbr_bootloader(guestfs *g) char * guestfs_inspect_get_vbr_bootloader(guests *g, char *device) that would return a string like “grub2”, “...

On Tue, Nov 05, 2013 at 12:15:47PM +0200, Nikos Skalkotos wrote: > The device name prefix for IDE hard drives used to be `ad' but now > is `ada' (http://www.freebsd.org/doc/handbook/disks-naming.html). > For virtio hard drives it is `vtbd'. > > Under an MBR partition table a slice will be used, so the name of > the first pa...

On Tue, Dec 02, 2014 at 07:11:55PM +0200, Nikos Skalkotos wrote: > Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr> > --- > src/inspect-fs-unix.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/inspect-fs-unix.c b/src/inspect-fs-unix.c > index 01a59f1..f55e53b 100644 > --- a/src/inspect-f...

Add a new guestfs_int_merge_fs_inspections() function that merges the OS inspection information of two inspect_fs instances into one. This function is useful if the inspection information for an OS are gathered by inspecting multiple filesystems. Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr> --- src/guestfs-internal.h | 1 + src/inspect-fs.c | 115 +++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 116 insertions(+) diff --git a/src/guestfs-internal.h b/src/guestfs-internal.h index 4f06c37..01cbca7 100644 --- a/src/guestfs-internal.h...

OK, I'll try to fix the epoch thing for all three. Nikos On 17 November 2014 13:49, Richard W.M. Jones <rjones@redhat.com> wrote: > On Mon, Nov 17, 2014 at 01:41:28PM +0200, Nikos Skalkotos wrote: >> OK, I'll make the suggested changes and I'll try to come up with a new >> patch by tomorrow or the day after tomorrow. I just noticed that a >> space is missing between STREQ and ( in the key assignment code which >> violates the project's coding style...

...io hard drives it is `vtbd'. Under an mbr partition table a slice will be used, so the name of the first partitions will be either ada0s1a or vtbd0s1a. Under a GPT partition table, where no slice is needed, the name of the first partition will be either ada0p1 or vtbd0p1. Signed-off-by: Nikos Skalkotos <skalkoto at grnet.gr> --- src/guestfs-internal.h | 2 ++ src/inspect-fs-unix.c | 30 +++++++++++++++++++++++++----- src/match.c | 25 +++++++++++++++++++++++++ 3 files changed, 52 insertions(+), 5 deletions(-) diff --git a/src/guestfs-internal.h b/src/guestfs-internal.h index...

* Implement coreos distro * Detect CoreOS images Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr> --- generator/actions.ml | 4 +++ src/guestfs-internal.h | 3 +++ src/inspect-fs-unix.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++--- src/inspect-fs.c | 21 +++++++++++++++ src/inspect-icon.c | 1 + src/inspect.c | 62 +++++++++++++++++...

On Tue, Jun 02, 2015 at 06:18:38PM +0300, Nikos Skalkotos wrote: > On 02/06/15 17:10, Richard W.M. Jones wrote: > Hello, > > > On Fri, May 29, 2015 at 12:24:58PM +0300, Nikos Skalkotos wrote: > >> + if (collect_coreos_inspection_info (g)) { > >> + guestfs_int_free_inspect_info (g); > >> + return NULL; &gt...

In inspect-fs-unix.c:1197 in add_fstab_entry() then too. On 02/06/15 18:39, Richard W.M. Jones wrote: > On Tue, Jun 02, 2015 at 06:37:06PM +0300, Nikos Skalkotos wrote: >> Sorry, I don't get it. In inspect.c line 67 you have this: >> >> for (fs = fses; *fs; fs += 2) { >> if (guestfs_int_check_for_filesystem_on (g, *fs)) { >> guestfs_int_free_inspect_info (g); >> return NULL; >> } >>...

On Fri, Jun 19, 2015 at 01:53:13PM +0300, Nikos Skalkotos wrote: > Hello, > > I was looking for a way to detect the installed boot loader of an image > and I found this: https://github.com/arvidjaar/bootinfoscript > This script will inspection a lot of things on a running system and will > output a Report. The most interesting part is...

Reported by Nikos Skalkotos https://aur.archlinux.org/packages/libguestfs/ --- Makefile.am | 2 +- po/POTFILES | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 5defbce..663958d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -320,7 +320,7 @@ po/POTFILES: configure.ac rm -f...