Displaying 20 results from an estimated 65 matches for "skalkotos".
2014 Dec 02
2
[PATCH 1/5] Remove extra space in inspect-fs-unix.c
Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr>
---
src/inspect-fs-unix.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/inspect-fs-unix.c b/src/inspect-fs-unix.c
index 01a59f1..f55e53b 100644
--- a/src/inspect-fs-unix.c
+++ b/src/inspect-fs-unix.c
@@ -58,8 +58,8 @@ COMPILE_REGEXP (re_scien...
2015 Jun 02
2
Re: [PATCH 2/3] inspection: Add support for CoreOS
On 02/06/15 17:10, Richard W.M. Jones wrote:
Hello,
> On Fri, May 29, 2015 at 12:24:58PM +0300, Nikos Skalkotos wrote:
>> + if (collect_coreos_inspection_info (g)) {
>> + guestfs_int_free_inspect_info (g);
>> + return NULL;
>> + }
> Although this is stylistic, I think it's easier to understand if
> you change the if condition to:
>
> if (collect_coreos_inspec...
2015 Feb 18
1
[PATCH] Fix a bug in e2fsck execution code
Use commandrvf() instead of commandvf() to execute e2fsck. A non-zero
exit status does not always indicate a failure.
Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr>
---
daemon/ext2.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/daemon/ext2.c b/daemon/ext2.c
index 65ddae6..8ef6d5f 100644
--- a/daemon/ext2.c
+++ b/daemon/ext2.c
@@ -296,9 +296,9 @@ do_e2fsck (const char *device,
ADD_ARG (argv, i, device);...
2013 Nov 05
2
[PATCH stable-1.24] Fix fstab block device resolution for FreeBSD
...bd'.
Under an MBR partition table a slice will be used, so the name of
the first partitions will be either `ada0s1a' or `vtbd0s1a'. Under a
GPT partition table, where no slice is needed, the name of the first
partition will be either `ada0p1' or `vtbd0p1'.
Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr>
---
src/guestfs-internal.h | 2 ++
src/inspect-fs-unix.c | 27 +++++++++++++++++++++++----
src/match.c | 25 +++++++++++++++++++++++++
3 files changed, 50 insertions(+), 4 deletions(-)
diff --git a/src/guestfs-internal.h b/src/guestfs-internal.h
index 9936c8...
2014 Nov 17
1
[PATCH] inspection: deb: Seperate epoch field from version
Return it in the app2_epoch field of the guestfs_application2 struct
Signed-off-by: Nikos Skalkotos <skalkoto@gmail.com>
---
src/inspect-apps.c | 25 +++++++++++++++++--------
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/src/inspect-apps.c b/src/inspect-apps.c
index 8e645b7..bd4e6c1 100644
--- a/src/inspect-apps.c
+++ b/src/inspect-apps.c
@@ -439,6 +439,7 @@ list_applicat...
2015 Jun 02
2
Re: [PATCH 2/3] inspection: Add support for CoreOS
...ou have this:
for (fs = fses; *fs; fs += 2) {
if (guestfs_int_check_for_filesystem_on (g, *fs)) {
guestfs_int_free_inspect_info (g);
return NULL;
}
}
I don't see the bug.
On 02/06/15 18:30, Richard W.M. Jones wrote:
> On Tue, Jun 02, 2015 at 06:18:38PM +0300, Nikos Skalkotos wrote:
>> On 02/06/15 17:10, Richard W.M. Jones wrote:
>> Hello,
>>
>>> On Fri, May 29, 2015 at 12:24:58PM +0300, Nikos Skalkotos wrote:
>>>> + if (collect_coreos_inspection_info (g)) {
>>>> + guestfs_int_free_inspect_info (g);
>>>>...
2013 Nov 05
1
Re: [PATCH stable-1.24] Fix fstab block device resolution for FreeBSD
...h at
all. The regular expression /dev/(ada{0,1}|vtbd)
will match both: /dev/ada and /dev/ad. This is why I use "{0,1}"
(=zero or one occurrence of the character a)
Nikos
On Tue 05 Nov 2013 01:42:44 PM EET, Richard W.M. Jones wrote:
> On Tue, Nov 05, 2013 at 12:15:47PM +0200, Nikos Skalkotos wrote:
>> The device name prefix for IDE hard drives used to be `ad' but now
>> is `ada' (http://www.freebsd.org/doc/handbook/disks-naming.html).
>> For virtio hard drives it is `vtbd'.
>>
>> Under an MBR partition table a slice will be used, so the name of...
2014 Nov 17
1
[PATCH] list-applications: Add support for pacman
Extend the guestfs_inspect_list_applications2 API call to work on Arch
Linux guest images.
Signed-off-by: Nikos Skalkotos <skalkoto@gmail.com>
---
src/inspect-apps.c | 137 +++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 137 insertions(+)
diff --git a/src/inspect-apps.c b/src/inspect-apps.c
index 6fb9665..8e645b7 100644
--- a/src/inspect-apps.c
+++ b/src/inspect-apps.c
@@ -60,6 +60,7 @@...
2014 Dec 03
2
Re: [synnefo-devel] Re: [PATCH 1/5] Remove extra space in inspect-fs-unix.c
...fs/tests/mountable'
make: *** [check-am] Error 2
make: Leaving directory `/root/src/libguestfs/tests/mountable'
I tried it on Debian Jessie and an updated Fedora 20 system. Any hints?
Nikos
On 03/12/14 01:53, Richard W.M. Jones wrote:
> On Tue, Dec 02, 2014 at 07:11:55PM +0200, Nikos Skalkotos wrote:
>> Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr>
>> ---
>> src/inspect-fs-unix.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/inspect-fs-unix.c b/src/inspect-fs-unix.c
>> index 01a59f1..f55e53b 10064...
2015 Jun 19
2
boot loader detection
Hello,
I was looking for a way to detect the installed boot loader of an image
and I found this: https://github.com/arvidjaar/bootinfoscript
This script will inspection a lot of things on a running system and will
output a Report. The most interesting part is that it uses known Master
and Volume Boot Record byte-patterns to determine the installed boot loader:
2013 Nov 05
0
Re: [PATCH stable-1.24] Fix fstab block device resolution for FreeBSD
On Tue, Nov 05, 2013 at 12:15:47PM +0200, Nikos Skalkotos wrote:
> The device name prefix for IDE hard drives used to be `ad' but now
> is `ada' (http://www.freebsd.org/doc/handbook/disks-naming.html).
> For virtio hard drives it is `vtbd'.
>
> Under an MBR partition table a slice will be used, so the name of
> the first par...
2014 Dec 02
0
Re: [PATCH 1/5] Remove extra space in inspect-fs-unix.c
On Tue, Dec 02, 2014 at 07:11:55PM +0200, Nikos Skalkotos wrote:
> Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr>
> ---
> src/inspect-fs-unix.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/inspect-fs-unix.c b/src/inspect-fs-unix.c
> index 01a59f1..f55e53b 100644
> --- a/src/inspect-fs...
2015 May 29
2
[PATCH 1/3] inspection: Add func for merging fs inspections
Add a new guestfs_int_merge_fs_inspections() function that merges the OS
inspection information of two inspect_fs instances into one. This
function is useful if the inspection information for an OS are gathered
by inspecting multiple filesystems.
Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr>
---
src/guestfs-internal.h | 1 +
src/inspect-fs.c | 115 +++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 116 insertions(+)
diff --git a/src/guestfs-internal.h b/src/guestfs-internal.h
index 4f06c37..01cbca7 100644
--- a/src/guestfs-internal.h...
2014 Nov 17
3
Re: [PATCH] list-applications: Add support for pacman
OK, I'll try to fix the epoch thing for all three.
Nikos
On 17 November 2014 13:49, Richard W.M. Jones <rjones@redhat.com> wrote:
> On Mon, Nov 17, 2014 at 01:41:28PM +0200, Nikos Skalkotos wrote:
>> OK, I'll make the suggested changes and I'll try to come up with a new
>> patch by tomorrow or the day after tomorrow. I just noticed that a
>> space is missing between STREQ and ( in the key assignment code which
>> violates the project's coding style....
2013 Nov 03
2
[PATCH stable-1.24] Fix fstab block device resolution for FreeBSD
...io hard drives it is `vtbd'.
Under an mbr partition table a slice will be used, so the name of
the first partitions will be either ada0s1a or vtbd0s1a. Under a
GPT partition table, where no slice is needed, the name of the first
partition will be either ada0p1 or vtbd0p1.
Signed-off-by: Nikos Skalkotos <skalkoto at grnet.gr>
---
src/guestfs-internal.h | 2 ++
src/inspect-fs-unix.c | 30 +++++++++++++++++++++++++-----
src/match.c | 25 +++++++++++++++++++++++++
3 files changed, 52 insertions(+), 5 deletions(-)
diff --git a/src/guestfs-internal.h b/src/guestfs-internal.h
index...
2015 May 29
2
[PATCH 2/3] inspection: Add support for CoreOS
* Implement coreos distro
* Detect CoreOS images
Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr>
---
generator/actions.ml | 4 +++
src/guestfs-internal.h | 3 +++
src/inspect-fs-unix.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++---
src/inspect-fs.c | 21 +++++++++++++++
src/inspect-icon.c | 1 +
src/inspect.c | 62 ++++++++++++++++++...
2015 Jun 02
0
Re: [PATCH 2/3] inspection: Add support for CoreOS
On Tue, Jun 02, 2015 at 06:18:38PM +0300, Nikos Skalkotos wrote:
> On 02/06/15 17:10, Richard W.M. Jones wrote:
> Hello,
>
> > On Fri, May 29, 2015 at 12:24:58PM +0300, Nikos Skalkotos wrote:
> >> + if (collect_coreos_inspection_info (g)) {
> >> + guestfs_int_free_inspect_info (g);
> >> + return NULL;
>...
2015 Jun 02
1
Re: [PATCH 2/3] inspection: Add support for CoreOS
In inspect-fs-unix.c:1197 in add_fstab_entry() then too.
On 02/06/15 18:39, Richard W.M. Jones wrote:
> On Tue, Jun 02, 2015 at 06:37:06PM +0300, Nikos Skalkotos wrote:
>> Sorry, I don't get it. In inspect.c line 67 you have this:
>>
>> for (fs = fses; *fs; fs += 2) {
>> if (guestfs_int_check_for_filesystem_on (g, *fs)) {
>> guestfs_int_free_inspect_info (g);
>> return NULL;
>> }
>>...
2015 Jun 19
0
Re: boot loader detection
On Fri, Jun 19, 2015 at 01:53:13PM +0300, Nikos Skalkotos wrote:
> Hello,
>
> I was looking for a way to detect the installed boot loader of an image
> and I found this: https://github.com/arvidjaar/bootinfoscript
> This script will inspection a lot of things on a running system and will
> output a Report. The most interesting part is t...
2016 Sep 12
1
[PATCH] perl: Guestfs.c file is not translatable, don't include it in po/POTFILES.
Reported by Nikos Skalkotos
https://aur.archlinux.org/packages/libguestfs/
---
Makefile.am | 2 +-
po/POTFILES | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 5defbce..663958d 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -320,7 +320,7 @@ po/POTFILES: configure.ac
rm -f...