search for: size_rtn

I've been taking a long hard look at the protocol layer. It has evolved over a long time without any particular direction, and the result is, to say the least, not very organized. These patches take a first step at cleaning up the mess by abstracting out socket operations from the rest of the code. The purpose of this is to allow us to slot in a different connection layer under the

This patch is a straightforward refactoring of libnbd?s nbdcopy program, and not very interesting. However I have plans for nbdcopy (see full todo below). I would like to use this utility for virt-v2v as a replacement for ?qemu-img convert?. qemu-img has caused us a series of problems: - change in zeroing behaviour caused a big performance regression - qemu-img reads extents up-front which

...(len=4, bufv=<optimized out>, connv= > <optimized out>, g=<optimized out>) at conn-socket.c:179 > #9 ?read_data (g=0xf31290, connv=0x110e280, bufv=<optimized out>, len=4) at > conn-socket.c:142 > #10 0x00007ffff6e1764a in recv_from_daemon (buf_rtn=0x7fffffffd858, size_rtn= > 0x7fffffffd854, g=0xf31290) at proto.c:545 > #11 guestfs_int_recv_from_daemon (g=g at entry=0xf31290, size_rtn=size_rtn at entry= > 0x7fffffffd854, buf_rtn=buf_rtn at entry=0x7fffffffd858) at proto.c:623 > #12 0x00007ffff6e17a5a in guestfs_int_recv > ? ? (g=g at entry=0xf31290, fn...

...6dfbd63 in read_data (len=4, bufv=<optimized out>, connv=<optimized out>, g=<optimized out>) at conn-socket.c:179 #9 read_data (g=0xf31290, connv=0x110e280, bufv=<optimized out>, len=4) at conn-socket.c:142 #10 0x00007ffff6e1764a in recv_from_daemon (buf_rtn=0x7fffffffd858, size_rtn=0x7fffffffd854, g=0xf31290) at proto.c:545 #11 guestfs_int_recv_from_daemon (g=g at entry=0xf31290, size_rtn=size_rtn at entry=0x7fffffffd854, buf_rtn=buf_rtn at entry=0x7fffffffd858) at proto.c:623 #12 0x00007ffff6e17a5a in guestfs_int_recv (g=g at entry=0xf31290, fn=fn at entry=0x7ffff6e3b3e8...

...stfish (with verbose & trace): ><fs> mkfs-opts ext2 /dev/vda1 blocksize:1024 mkfs_opts "ext2" "/dev/vda1" "blocksize:1024"send_to_daemon: 0x2393bc0 g->state = 3, n = 72 proc 210 (part_disk) took 0.18 seconds recv_from_daemon: 0x2393bc0 g->state = 3, size_rtn = 0x7fffd24c565c, buf_rtn = 0x7fffd24c5650 mkfs -t ext2 -b 1024 /dev/vda1 mke2fs 1.41.12 (17-May-2010) = 0 ><fs> mkfs-opts ext2 /dev/vda1 mkfs_opts "ext2" "/dev/vda1"send_to_daemon: 0x2393bc0 g->state = 3, n = 72 proc 278 (mkfs_opts) took 0.19 seconds recv_from_da...

...(len=4, bufv=<optimized out>, connv= > <optimized out>, g=<optimized out>) at conn-socket.c:179 > #7 ?read_data (g=0xae06f0, connv=0xd19570, bufv=<optimized out>, len=4) at > conn-socket.c:142 > #8 ?0x00007f6dd1685c2a in recv_from_daemon (buf_rtn=0x7fffa95cc548, size_rtn= > 0x7fffa95cc544, g=0xae06f0) at proto.c:545 > #9 ?guestfs_int_recv_from_daemon (g=g at entry=0xae06f0, size_rtn=size_rtn at entry= > 0x7fffa95cc544, buf_rtn=buf_rtn at entry=0x7fffa95cc548) at proto.c:623 > #10 0x00007f6dd168603a in guestfs_int_recv > ? ? (g=g at entry=0xae06f0, fn...

This is an updated and extended version of the original patch: https://www.redhat.com/archives/libguestfs/2010-August/msg00163.html This adds OCaml and Perl bindings (both tested), support for progress bars in virt-resize, and adds progress notifications to a number of the simpler commands. Still to do is to add progress messages to more commands. There are still a few commands which would be

...ea4 in poll (__timeout=-1, __nfds=2, __fds=0x7ffe4c0537b0) at /usr/include/bits/poll2.h:41 #2 read_data (g=0x7fe6f8e04bd0, connv=0x7fe6f8df9100, bufv=<optimized out>, len=4) at conn-socket.c:162 #3 0x00007fe6f7983f0c in recv_from_daemon (buf_rtn=0x7ffe4c053908, buf_rtn@entry=0x7ffe4c053658, size_rtn=0x7ffe4c0538e4, size_rtn@entry=0x7ffe4c053634, g=0x7fe6f8e04bd0, g@entry=0x7ffe4c053840) at proto.c:515 #4 guestfs_int_recv_from_daemon (g=g@entry=0x7fe6f8e04bd0, size_rtn=size_rtn@entry=0x7ffe4c0538e4, buf_rtn=buf_rtn@entry=0x7ffe4c053908) at proto.c:611 #5 0x00007fe6f797dae0 in launch_libvirt (...

Thanks Rich. I have used libguestfs for several month. It worked perfectly before, the issue appears recently. I am trying guestfs_set_backend (g, "direct"). Thanks, Allen 2016-08-29 23:31 GMT+08:00 Richard W.M. Jones <rjones@redhat.com>: > On Mon, Aug 29, 2016 at 11:19:04PM +0800, Baochuan Wu wrote: > > Thanks Rich for you quick reply. I enabled logs and the program

As the start of work to add remote support, I'm taking a close look at the protocol layer in the library. These are some small cleanups. Rich.

...(uintmax_t) major (dev), (uintmax_t) minor (dev)) < 0) { perror ("printf"); exit (EXIT_FAILURE); } diff --git a/fish/alloc.c b/fish/alloc.c index b40284a..9f41915 100644 --- a/fish/alloc.c +++ b/fish/alloc.c @@ -97,7 +97,7 @@ parse_size (const char *str, off_t *size_rtn) xerr = xstrtoull (str, NULL, 0, &size, "0kKMGTPEZY"); if (xerr != LONGINT_OK) { fprintf (stderr, - _("%s: invalid integer parameter (%s returned %d)\n"), + _("%s: invalid integer parameter (%s returned %u)\n"), &quo...

...(uintmax_t) major (dev), (uintmax_t) minor (dev)) < 0) { perror ("printf"); exit (EXIT_FAILURE); } diff --git a/fish/alloc.c b/fish/alloc.c index b40284a..9f41915 100644 --- a/fish/alloc.c +++ b/fish/alloc.c @@ -97,7 +97,7 @@ parse_size (const char *str, off_t *size_rtn) xerr = xstrtoull (str, NULL, 0, &size, "0kKMGTPEZY"); if (xerr != LONGINT_OK) { fprintf (stderr, - _("%s: invalid integer parameter (%s returned %d)\n"), + _("%s: invalid integer parameter (%s returned %u)\n"), &quo...

...; MIN (i+16, len); ++j) printf ("%02x ", (unsigned char) buf[j]); for (; j < i+16; ++j) diff --git a/src/guestfs.c b/src/guestfs.c index 17974fd..e9961d1 100644 --- a/src/guestfs.c +++ b/src/guestfs.c @@ -1902,18 +1902,18 @@ recv_from_daemon (guestfs_h *g, uint32_t *size_rtn, void **buf_rtn) /* Got the full message, caller can start processing it. */ #if 0 if (g->verbose) { - size_t i, j; + ssize_t i, j; for (i = 0; i < nr; i += 16) { - printf ("%04x: ", i); + printf ("%04zx: ", i); for (j = i; j < MIN (...

From: "Richard W.M. Jones" <rjones at redhat.com> --- generator/generator_gobject.ml | 4 ++-- gobject/Makefile.am | 14 +++++++++----- gobject/Makefile.inc | 4 ++-- 3 files changed, 13 insertions(+), 9 deletions(-) diff --git a/generator/generator_gobject.ml b/generator/generator_gobject.ml index 17c6c36..3096501 100644 ---

v2: - Fixes a number of bugs in corner cases. - Uses a 1M block size to fetch from the underlying plugin. This improves performance considerably. I also tested this much more thoroughly and can't find any more bugs. Rich.

Matt asked if xz should really be a filter rather than a plugin. The answer is yes, of course it should be! That's been something in the todo file for a while. The commit converts the xz plugin code into a filter (leaving the plugin around, but deprecating it). plugin: nbdkit xz file.xz filter: nbdkit --filter=xz file file.xz plugin: # can't be done filter: nbdkit

...g->progress_cb (g, g->progress_cb_data, - message.proc, message.serial, - message.position, message.total); + send_progress_message (g, &message); } return 0; @@ -543,8 +549,7 @@ guestfs___recv_from_daemon (guestfs_h *g, uint32_t *size_rtn, void **buf_rtn) g->state); else { g->state = READY; - if (g->launch_done_cb) - g->launch_done_cb (g, g->launch_done_cb_data); + guestfs___call_callbacks_void (g, GUESTFS_EVENT_LAUNCH_DONE); }...

...> @@ -62,6 +61,7 @@ #include "guestfs.h" #include "guestfs-internal-actions.h" #include "guestfs_protocol.h" +#include "c-ctype.h" #include "ignore-value.h" #ifdef HAVE_GETTEXT @@ -2136,7 +2136,7 @@ recv_from_daemon (guestfs_h *g, uint32_t *size_rtn, void **buf_rtn) printf (" "); printf ("|"); for (j = i; j < MIN (i+16, nr); ++j) - if (isprint ((*(char **)buf_rtn)[j])) + if (c_isprint ((*(char **)buf_rtn)[j])) printf ("%c", (*(char **)buf_rtn)[j]); else...

...et ifile to the name of the pipe. + */ +static int +prepare_input (const char *input, const char *ifmt, char **ifile_rtn, + int *ifile_delete_on_exit) +{ + abort (); /* XXX */ +} + +/* Adapted from fish/alloc.c */ +static int +parse_size (const char *str, uint64_t estimate, uint64_t *size_rtn) +{ + unsigned long long size; + strtol_error xerr; + int plus = 0; + + assert (str); + + if (str[0] == '+') { + plus = 1; + str++; + } + + xerr = xstrtoull (str, NULL, 0, &size, "0kKMGTPEZY"); + if (xerr != LONGINT_OK) { + fprintf (stderr, + _(&qu...

...1001/initrd.28536 \ ??? -append 'panic=1 console=ttyS0 udevtimeout=300 noapic acpi=off printk.time=1 cgroup_disable=memory selinux=0 guestfs_verbose=1 TERM=xterm ' \ ??? -drive file=/tmp/.guestfs-1001/root.28536,snapshot=on,if=virtio,cache=unsafe recv_from_daemon: 0x8b77958 g->state = 1, size_rtn = 0xbf95c43c, buf_rtn = 0xbf95c438 open /dev/kvm: No such file or directory Could not initialize KVM, will disable KVM support [??? 0.000000] Initializing cgroup subsys cpuset [??? 0.000000] Initializing cgroup subsys cpu [??? 0.000000] Linux version 2.6.36-020636-generic (root at zinc) (gcc versio...