search for: shankark

On Mon, Apr 20, 2015 at 1:44 AM, Shankar Easwaran <shankarke at gmail.com> wrote: > Attached patch fixes the issue. Thanks for the quick fix. The patch LGTM if you add a test case. Unfortunately yaml2obj does not support duplicated section names but we can use a binary input file. -- Simon Atanasyan

...the temporary measure is reasonable (besides the discussion if checking in binary files is desirable). Even if you plan to add a test written in YAML, it's better to check in a binary at least for now than checking it in without any tests. On Mon, Apr 20, 2015 at 7:59 AM, Shankar Easwaram <shankarke at gmail.com> wrote: > I plan to add a test case but couldn't add because of yaml2obj support. I > am adding that support to yaml2obj and obj2yaml and push this patch later. > I don't like the idea of adding binary files to the test repo as we need to > keep cleaning up lat...

On Sat, Jul 05, 2014 at 01:33:11PM -0700, shankarke wrote: > Gnu linker does not support for some reason as well, if we are > emulating the gnu behavior it might be good to handle it in the same way. Binutils broke the ELF behavior with some recent versions. That is not something to follow. Joerg

...essing. >> Since it crashed in tests because of native format conversion, I needed to >> keep calculated addend to pass it along the handlers instead of just >> calling ref.addend(). >> >> - Denis. >> >> >> On 02/08/2015 08:42 PM, Shankar Easwaram <shankarke at gmail.com> >> <shankarke at gmail.com> wrote: >> >> ARM has a concept of Group relocations, which applies relocations >> considering them as one set may be we should consider extending apply >> relocation. What do you think? >> >> >>>...

...t;> So it's totally okay if some input file type is not representable in >> YAML/Native. Some use cases are not real. We can't force all developers to >> spend their time to support unrealistic use cases. >> >> On Fri, Feb 6, 2015 at 7:04 PM, Shankar Easwaran <shankarke at gmail.com> >> wrote: >>> >>> The intermediate result is what is really written to disk when >>> --output-filetype=yaml or native is chosen too. >>> >>> >>> Writing to YAML/Reading back YAML is not doable when you convert input &g...

...he Reference object in the relocation handler to simplify further processing. Since it crashed in tests because of native format conversion, I needed to keep calculated addend to pass it along the handlers instead of just calling ref.addend(). - Denis. On 02/08/2015 08:42 PM, Shankar Easwaram <shankarke at gmail.com><mailto:shankarke at gmail.com> wrote: ARM has a concept of Group relocations, which applies relocations considering them as one set may be we should consider extending apply relocation. What do you think? > On Feb 8, 2015, at 04:50, Simon Atanasyan <simon at atanasyan...

...r option), but that's an object file. So it's totally okay if some input file type is not representable in YAML/Native. Some use cases are not real. We can't force all developers to spend their time to support unrealistic use cases. On Fri, Feb 6, 2015 at 7:04 PM, Shankar Easwaran <shankarke at gmail.com> wrote: > The intermediate result is what is really written to disk when > --output-filetype=yaml or native is chosen too. > > > Writing to YAML/Reading back YAML is not doable when you convert input > files to atoms because some of the input files are not repres...

...hankar Easwaran -------- Original Message -------- Subject: Re: [PATCH] Add a fallback mechanism for undefined atom. Date: Thu, 29 Aug 2013 15:15:49 -0700 From: kledzik at apple.com <kledzik at apple.com> Reply-To: reviews+D1550+public+25c98da67f89e22f at llvm-reviews.chandlerc.com To: shankarke at gmail.com, kledzik at apple.com, bigcheesegs at gmail.com, ruiu at google.com CC: llvm-commits at cs.uiuc.edu Interesting feature. What happens if a.o has an undefine foo which says its fallback is bar, but in b.o an undefine for foo says its fallback is baz? Is that an error, or d...

Hi Nick, I need the original path of the files, from where the atoms were parsed. The path for the atoms are completely useless after the round trip pass. This is needed to support linker scripts with the Gnu flavor. I think there are more uses too like diagnostics (relocation overflows etc) I was planning to add a patch so that the native writer, stores the original path for atoms Another

Hi, FYI LLD cannot handle ELF sections with non-unique names. An object file with such sections can be generated by the Clang since r234143. I am not sure that Clang works absolutely correct but bfd linker works fine. Right now I do not have a time to investigate this problem. If nobody take, I will try to solve it later. Here is the reproduction script for x86_64 host: $ cat test.cc template

Hi All, I have a design question of how your linker would be suitable for modeling ELF semantics. The ELF linker needs the functionality of reading relocations ahead of symbol resolution for the following usecases :- - Add linker defined symbols if there is a relocation to the symbol (Examples are : defsym, PROVIDE) - Dont halt the linker operation if there are undefined symbols but they are

...------ Original Message -------- > Subject: Re: [PATCH] Add a fallback mechanism for undefined atom. > Date: Thu, 29 Aug 2013 15:15:49 -0700 > From: kledzik at apple.com <kledzik at apple.com> > Reply-To: reviews+D1550+public+25c98da67f89e22f at llvm-reviews.chandlerc.com > To: shankarke at gmail.com, kledzik at apple.com, bigcheesegs at gmail.com, ruiu at google.com > CC: llvm-commits at cs.uiuc.edu > > > Interesting feature. > > What happens if a.o has an undefine foo which says its fallback is bar, but in b.o an undefine for foo says its fallback is baz...

Hi Shankar, I almost implement ELFRelocationReader but still not completely sure that this is a right direction. Suppose somebody wants to override creation of the `ELFReference` object from the `Elf_Rela` or `Elf_Rel` record. Let's consider two implementations A and B: A: ===== 1. Factor out `ELFReference` creation from `createDefinedAtomAndAssignRelocations` into a couple of virtual

I think no one is opposing the idea of reading and writing YAML. The problem here is that why we need to force all developers to write code to serialize intermediate data in the middle of link, which no one except the round-trip passes needs. On Fri, Feb 6, 2015 at 6:41 PM, Shankar Easwaram <shankarke at gmail.com> wrote: > Doing it for every input file is not useful as some of the input files are > not represent able in YAML form. Examples are shared libraries. > > The reason I made the yaml pass be called before the writer was the > intermediate result was more complete sin...

On Wed, Jul 02, 2014 at 05:09:14PM -0700, Nick Kledzik wrote: > Shankar, Does lld for ELF support loading indirect DSOs? It doesn't, which is a bug. Joerg

Hi, Yes, ldd is generating wrong tbss size. It is just considering one tbss section and not calculating all sections from all objects. The following example on x86_64 shows the issue: --- t0.c --- #include <stdio.h> extern __thread int t0; extern __thread int t1; extern __thread int t2; extern __thread int t3; __thread int t4; __thread int t5; __thread int t6; __thread int t7; int

...age -------- >> Subject: Re: [PATCH] Add a fallback mechanism for undefined atom. >> Date: Thu, 29 Aug 2013 15:15:49 -0700 >> From: kledzik at apple.com <kledzik at apple.com> >> Reply-To: reviews+D1550+public+25c98da67f89e22f at llvm-reviews.chandlerc.com >> To: shankarke at gmail.com, kledzik at apple.com, bigcheesegs at gmail.com, ruiu at google.com >> CC: llvm-commits at cs.uiuc.edu >> >> >> Interesting feature. >> >> What happens if a.o has an undefine foo which says its fallback is bar, but in b.o an undefine for foo s...

Hi, Now lld writes relocations to the ".rela" sections only. Mips requires to use the "rel" format. So we need to be able to select format and names of relocation section, names of symbols like __rela_iplt_* / __rel_iplt_*, dynamic table tag DT_RELA / DT_REL. My current idea: - Add two virtual functions DefaultLayout::createDynamicRelocationTable() and

...;> Subject: Re: [PATCH] Add a fallback mechanism for undefined atom. >>> Date: Thu, 29 Aug 2013 15:15:49 -0700 >>> From: kledzik at apple.com <kledzik at apple.com> >>> Reply-To: reviews+D1550+public+25c98da67f89e22f at llvm-reviews.chandlerc.com >>> To: shankarke at gmail.com, kledzik at apple.com, bigcheesegs at gmail.com, ruiu at google.com >>> CC: llvm-commits at cs.uiuc.edu >>> >>> >>> Interesting feature. >>> >>> What happens if a.o has an undefine foo which says its fallback is bar, but in...

David, I started a discussion yesterday on lld / chunks for ELF as we need relocations to be read when reading the inputs especially for handling comdat. The other way thus can be done is doing symbol resolution while reading which makes the linker less suitable for concurrent operations. Let me know what you think? Shankar Easwaran > On Jun 5, 2015, at 23:35, Davide Italiano <davide