search for: setup_protocol

...shed directory from being removed. 1. I don't think the --backup rule should be perishable. If I delete an entire directory from the source, I would expect the receiver to back up the files inside and not discard the backups just because I deleted the whole directory. 2. The filters added in setup_protocol in compat.c don't seem to be taking effect on local rsyncs. See this run of CVS rsync to which I added some debugging output: [matt@mattlaptop backup]$ ~/rsync/rsync/rsync -in -vv -a --backup --del src/ dest/ Parsed rule Pp *~ <-- setup_protocol am_sender is 1, filter_list.head is 8878...

...ry=0x7fffffffa810 "\037", len=len at entry=4) at io.c:245 #7 0x0000555555585cfe in read_buf (f=f at entry=1606, buf=buf at entry=0x7fffffffa810 "\037", len=len at entry=4) at io.c:1815 #8 0x0000555555585ef6 in read_int (f=f at entry=1606) at io.c:1711 #9 0x00005555555876ed in setup_protocol (f_out=1605, f_in=1606) at compat.c:158 #10 0x0000555555576417 in client_run (f_in=1606, f_out=1605, pid=24793, argc=1, argv=0x5555557d5240) at main.c:1128 #11 0x000055555557795e in start_client (argv=0x5555557d5240, argc=1) at main.c:1423 #12 main (argc=2, argv=0x5555557d5240) at main.c:1651 It l...

...e1f83c in iconv () from /lib64/libc.so.6 #3 0x000000000040d252 in iconvbufs () #4 0x0000000000423bce in rwrite () #5 0x0000000000423505 in rprintf () #6 0x000000000042b911 in whine_about_eof () #7 0x000000000042f5e2 in read_buf () #8 0x000000000042fde1 in read_int () #9 0x000000000043055d in setup_protocol () #10 0x000000000041ffb8 in client_run () #11 0x00000000004209c6 in main () Please let us know if any additional information is needed for debugging. Regards, Balveer Singh -- You are receiving this mail because: You are the QA Contact for the bug.

...er order : detect-renamed.diff & fileflags.diff & crtimes.diff => errors but different (but alway in connection with the last applied patch...) gcc -std=gnu99 -I. -I. -g -O2 -DHAVE_CONFIG_H -Wall -W -I./popt -Wno-unused-parameter -c compat.c -o compat.o compat.c: In function 'setup_protocol': compat.c:144: error: 'preserve_crtimes' undeclared (first use in this function) compat.c:144: error: (Each undeclared identifier is reported only once compat.c:144: error: for each function it appears in.) compat.c:146: error: 'preserve_fileflags' undeclared (first use...

...uot;\037", len=len at entry=4) at io.c:245 > #7 0x0000555555585cfe in read_buf (f=f at entry=1606, > buf=buf at entry=0x7fffffffa810 "\037", len=len at entry=4) at io.c:1815 > #8 0x0000555555585ef6 in read_int (f=f at entry=1606) at io.c:1711 > #9 0x00005555555876ed in setup_protocol (f_out=1605, f_in=1606) at compat.c:158 > #10 0x0000555555576417 in client_run (f_in=1606, f_out=1605, > pid=24793, argc=1, argv=0x5555557d5240) at main.c:1128 > #11 0x000055555557795e in start_client (argv=0x5555557d5240, argc=1) > at main.c:1423 > #12 main (argc=2, argv=0x5555557d5...

> Just curious: what about the rsync+ patch? Thanks for the reminder. I've just committed Jos's rsync+ patch onto the "branch_mbp_rsyncplus_merge" branch. If it works OK and nobody screams I will move it across onto the main tree tomorrow or Wednesday. I see the patch doesn't add documentation about the new options to the man page, so we should fix that in the future.

Hi All, I have been using rysnc 3.0.6 with Mike's rsync_3.0.6-hfs-compression_20091027.diff patch (as well as the standard osx patches) with good results. I discovered that clones done on 10.6 using this rsync cause some executable files ( the ones that are mostly compressed this way on osx ) to be damaged. I did a test twice and indeed a handful of them are damaged. They all appear to be in

...itation can be removed. */ if (!read_batch) { recv_exclude_list(f_in); if (cvs_exclude) *************** *** 609,623 **** char *local_name = NULL; cleanup_child_pid = pid; ! if (read_batch) ! flist = batch_flist; set_nonblocking(f_in); set_nonblocking(f_out); setup_protocol(f_out,f_in); ! if (protocol_version >= 23) io_start_multiplex_in(f_in); if (am_sender) { --- 633,658 ---- char *local_name = NULL; cleanup_child_pid = pid; ! if (read_batch) { ! close(f_in); ! close(f_out); + /* This is the heart of the read_batch approach: +...

..., buf=0xbfffe984 "\036", len=4) at io.c:783 #11 0x08069933 in readfd_unbuffered (fd=5, buf=0xbfffe984 "\036", len=4) at io.c:1041 #12 0x08069e38 in readfd (fd=5, buffer=0xbfffe984 "\036", N=4) at io.c:1187 #13 0x08069ea5 in read_int (f=5) at io.c:1215 #14 0x0806b2cd in setup_protocol (f_out=4, f_in=5) at compat.c:150 #15 0x08060374 in client_run (f_in=5, f_out=4, pid=25865, argc=1, argv=0x80a21a4) at main.c:983 #16 0x0806097d in start_client (argc=1, argv=0x80a21a4) at main.c:1266 #17 0x08061033 in main (argc=2, argv=0x80a21a0) at main.c:1493 The most recent errno before the c...

...&preserve_links , 0, 0, 0 }, {"copy-links", 'L', POPT_ARG_NONE, &copy_links , 0, 0, 0 }, diff -ru rsync-2.5.6/proto.h rsync-2.5.6J/proto.h --- rsync-2.5.6/proto.h Sun Jan 26 20:35:09 2003 +++ rsync-2.5.6J/proto.h Wed Jan 29 17:16:39 2003 @@ -58,6 +58,7 @@ void setup_protocol(int f_out,int f_in); int claim_connection(char *fname,int max_connections); int check_exclude(char *name, struct exclude_struct **local_exclude_list, + struct exclude_struct **recur_local_exclude_list, STRUCT_STAT *st); void add_exclude_list(const char *pattern, struct exclude_struct ***...

This is a patch to add an --rsync-exclude option to rsync-2.5.6cvs. File names in .rsync- (or .rsync+) are excluded (or included) from the file lists associated with the current directory and all of its subdirectories. This has advantages over --cvs-exclude for backing up large file systems since the .cvsignore files only apply to the current directory: unless the .cvsignore restrictions apply

...uot;copy-links", 'L', POPT_ARG_NONE, &copy_links, 0, 0, 0 }, diff -ru rsync-2.6.1pre-1/proto.h rsync-2.6.1pre-1J/proto.h --- rsync-2.6.1pre-1/proto.h 2004-02-18 00:13:06.000000000 +0100 +++ rsync-2.6.1pre-1J/proto.h 2004-04-07 11:42:21.000000000 +0200 @@ -52,7 +52,8 @@ void setup_protocol(int f_out,int f_in); int claim_connection(char *fname,int max_connections); void free_exclude_list(struct exclude_struct ***listp); -int check_exclude(struct exclude_struct **list, char *name, int name_is_dir); +int check_exclude(struct exclude_struct **list, char *name, int name_is_dir, + con...

...c_recv; #endif /* These index values are for the file-list's extra-attribute array. */ -int uid_ndx, gid_ndx, acls_ndx, xattrs_ndx, unsort_ndx; +int uid_ndx, gid_ndx, fileflags_ndx, acls_ndx, xattrs_ndx, unsort_ndx; #ifdef ICONV_OPTION int filesfrom_convert = 0; @@ -124,6 +125,8 @@ void setup_protocol(int f_out,int f_in) uid_ndx = ++file_extra_cnt; if (preserve_gid) gid_ndx = ++file_extra_cnt; + if (preserve_fileflags) + fileflags_ndx = ++file_extra_cnt; if (preserve_acls && !am_sender) acls_ndx = ++file_extra_cnt; if (preserve_xattrs) diff -brpu rsync-3.0.0pre9/config.h....

...xclude_list(f_in); - if (read_batch) /* dw */ + if (read_batch) flist = batch_flist; else flist = recv_file_list(f_in); @@ -497,7 +497,7 @@ extern int cvs_exclude; extern int am_sender; extern int remote_version; - extern int read_batch; /* dw */ + extern int read_batch; setup_protocol(f_out, f_in); @@ -508,7 +508,7 @@ io_start_multiplex_out(f_out); if (am_sender) { - if (!read_batch) { /* dw */ + if (!read_batch) { recv_exclude_list(f_in); if (cvs_exclude) add_cvs_excludes(); @@ -527,19 +527,19 @@ */ int client_run(int f_in, int f_out, pid_t pid,...

..., int fd1, int fd2); void cleanup_set_pid(int pid); int start_socket_client(char *host, char *path, int argc, char *argv[]); + int start_inband_exchange(char *user, char *path, int f_in, int f_out, int argc, char *argv[]); + int start_daemon(int f_in, int f_out); int daemon_main(void); void setup_protocol(int f_out,int f_in); int claim_connection(char *fname,int max_connections); *************** *** 145,151 **** void send_files(struct file_list *flist,int f_out,int f_in); int open_socket_out(char *host, int port, struct in_addr *address); int is_a_socket(int fd); ! void start_accept_loop(int...