search for: seekdir

I was just playing with git 1.5.3.8 and btrfs 0.11, and I noticed something odd. If I prepare a very simple repository: $ mkdir foo $ cd foo $ git init Initialized empty Git repository in .git/ $ echo hi > blort $ git add . $ git commit -m create Created initial commit 4ae9415: create 1 files changed, 1 insertions(+), 0 deletions(-) create mode 100644 blort and then

On Fri, Feb 17, 2023 at 12:40:25AM +0100, Conor Armstrong wrote: > Ok, starting to make sense now.? In order to fix it.... > I note that the lower level calls are wrapped in dir.c - eg > dptr_SeekDir(...) wraps SeekDir(...) > this might allow for some code to use array indexes instead of NFS cookies > as noted by Chris Chilvers here for the 3.10 kernel: > [1]https://lore.kernel.org/all/CAAmbk-e-YQAPo6QyNB0aJyc9qzUShmEC+x5eTR7wqp1ABWADsg at mail.gmail.com/T/ First I think we need...

Ok, starting to make sense now. In order to fix it.... I note that the lower level calls are wrapped in dir.c - eg dptr_SeekDir(...) wraps SeekDir(...) this might allow for some code to use array indexes instead of NFS cookies as noted by Chris Chilvers here for the 3.10 kernel: https://lore.kernel.org/all/CAAmbk-e-YQAPo6QyNB0aJyc9qzUShmEC+x5eTR7wqp1ABWADsg at mail.gmail.com/T/ > On the older 3.10 kernel, this was not...

...ile: 4236, Offset: -376809161586095012 File: 3507, Offset: -376809161585570724 ... The negative NFS negative offsets seem to be managed already in source3/smbd/dir.c in the map_dir_offset_to_wire() function which adjusts for signed/unsigned longs. You mention that NFS doesn't have a working seekdir()/telldir()/rewinddir(). Other than the different offset (cookie) management, do you know of any other differences? I had a look at the wireshark dumps. I'm getting a STATUS_PENDING shortly followed by a STATUS_CANCELLED for the NFS share which are absent on the block storage share. > On...

...gt; I know this issue has arisen a few times over the past couple of years and > never any real resolution.? Would be good to get it solved once and for > all. Samba is merely making opendir()/readdir()/closedir() calls in a loop in this codepath. It's possible we may also be using seekdir() telldir()/rewinddir() calls, which may not be returning a consistent view of the directory over NFS. Get debug level 10 logs plus a wireshark trace to see what is going on both in the fileserver and on the wire. ----- End forwarded message -----

Alternately, we could possibly modify the dptr_TellDir function to set a flag somewhere if it ever returns a negative offset. Then any calls to dptr_SeekDir checks if the flag is set and does a slower approach of a RewindDir and then multiple ReadDir & TellDir calls until we get the matching offset. If flag is not set then go with the normal SeekDir call??? On Fri, 17 Feb 2023 at 00:40, Conor Armstrong <conorarmstrong at gmail.com> wrote:...

...7, Offset: -376809161585570724 > > ... > > The negative NFS negative offsets seem to be managed already > in?source3/smbd/dir.c in the?map_dir_offset_to_wire() function which > adjusts for signed/unsigned longs. > You mention that?NFS doesn't have a working > seekdir()/telldir()/rewinddir(). Other than the different offset (cookie) > management, do you know of any other differences? > I had a look at the wireshark dumps. I'm getting a STATUS_PENDING shortly > followed by a STATUS_CANCELLED for the NFS share which are absent on the > bloc...

...ou move through a directory. On Mon, 27 Feb 2023 at 19:00, Jeremy Allison <jra at samba.org> wrote: > On Mon, Feb 27, 2023 at 01:18:20PM +0100, Conor Armstrong via samba wrote: > >Just by way of update on this, it looks like the problem exists with the > >ReadDir, TellDir and SeekDir implementation on NFS shares. In my case it > >was an AWS EFS share that uses NFS. > > Can you elaborate exactly the issue with the AWS NFS server here ? > It would be really helpful to understand what it's doing here. > > >The fix in the samba code isn't straightfo...

...then end up as a negative > signed offset in Samba which is not handled correctly. The cookies are not > necessarily consecutive as you move through a directory. ? We only store the returned cookie as a 'long' from telldir(), and then use it to get to the same position again via seekdir(). There isn't any interpretation of the actual value inside Samba other than 3 'magic' values we use #defined here: /* "Special" directory offsets. */ #define END_OF_DIRECTORY_OFFSET ((long)-1) #define START_OF_DIRECTORY_OFFSET ((long)0) #define DOT_DOT_DIRECTORY_OFFSET ((lo...

On Wed, Feb 15, 2023 at 08:06:28PM +0100, Conor Armstrong wrote: > Rowland & Jeremy - thanks for this! > I built a copy of the latest version from github 4.19 and same issue > arises. ? > I will have a look at the wireshark trace and see if I can spot anything > obvious there. > I'm not an expert on this, but as far?as I know NFS isn't fully POSIX >

Hello, I have a problem with directories that contain more than 10000 entries (Ubuntu 8.04.1) or with more than 70000 entries (RHEL 5.2). If you use readdir(3) or readdir64(3) you get one entry twice, with same name and inode. Some analyzing showed that disabling dir_index solves this problem, but I think that this is a bug in the ext3 code, as no other file-system shows this behavior.

Hi, A stupid flat directory /tmp holding 5 millon files, the directory locates on a ext3 file system with dir_index feature turned on. The running Linux are FC4 and FC5. The files are just directly under /tmp, not in any subdirectories -- they are results of mis-operations of users. Then a 'ls' or 'find' command will take one hour to finish, a lot of other applications on

...gt; > > > OK, almost certainly it's the NFS mount causing the problem. > > > > Can you try and reproduce on a locally hosted share. > > > > I expect not. Given it's on an NFS mount, we can investigate > > but I'm guessing it'll be the telldir()/seekdir() error that > > seems to be endemic to NFS mounts. > > > > It will not help using the REALM instead of the WORKGROUP in the idmap > config lines. > > Rowland > > -- > To unsubscribe from this list go to the following URL and read the > instructions: https://...

...ry. > > On Mon, 27 Feb 2023 at 19:00, Jeremy Allison <jra at samba.org> wrote: > >> On Mon, Feb 27, 2023 at 01:18:20PM +0100, Conor Armstrong via samba wrote: >> >Just by way of update on this, it looks like the problem exists with the >> >ReadDir, TellDir and SeekDir implementation on NFS shares. In my case it >> >was an AWS EFS share that uses NFS. >> >> Can you elaborate exactly the issue with the AWS NFS server here ? >> It would be really helpful to understand what it's doing here. >> >> >The fix in the samba c...

...set for the next entry. So after the last entry in the directory you will be getting the offset of a non-existent entry, in which case the next readdir would return NULL anyways. Is it necessary to test the offset inside the loop after the readdir or would it be sufficient to test it before the SeekDir on the next iteration. Unfortunately you can not convert between version 1 naming and version 2 naming on the XFS filesystem without a full dump and restore. So I am wondering is someone can come up with a workaround for this. Thanks for your time in this concern. Cale Fairchild Systems...

Hi, Before I file a bug report, I just wanted to check that samba is capable of serving files from a FAT32 partition. I have here an OpenBSD-4.2 i386 machine here with a second disk containting files that I will be sharing via both NFS and samba. The NFS share work great, but samba seg faults upon a windows client connecting. This occurs when using the OpenBSD package, and also when built from

Jeremy, I think we found the part of source where the problem resides: smbd/trans2.c +1444 for (i=0;(i<maxentries) && !finished && !out_of_space;i++) { +1445 BOOL got_exact_match = False; +1446 +1447 /* this is a heuristic to avoid seeking the dirptr except when +1448 absolutely necessary. It allows for

...checking for symlink... no > checking for readlink... no > checking for syslog... no > checking for vsyslog... no > checking for syscall... no > checking for _dup... no > checking for _dup2... no > checking for _opendir... no > checking for _readdir... no > checking for _seekdir... no > checking for _telldir... no > checking for _closedir... no > checking for __dup... no > checking for __dup2... no > checking for __opendir... no > checking for __readdir... no > checking for __seekdir... no > checking for __telldir... no > checking for __closedir....

...or srandom... yes checking for random... yes checking for srand... yes checking for rand... yes checking for setenv... no checking for mmap64... yes checking for syscall... yes checking for _dup... yes checking for _dup2... yes checking for _opendir... yes checking for _readdir... yes checking for _seekdir... yes checking for _telldir... yes checking for _closedir... yes checking for __dup... no checking for __dup2... no checking for __opendir... no checking for __readdir... no checking for __seekdir... no checking for __telldir... no checking for __closedir... no checking for __getcwd... no checking...

...usleep... yes checking for strcasecmp... yes checking for fcvt... yes checking for fcvtl... no checking for symlink... yes checking for readlink... yes checking for syscall... yes checking for _dup... no checking for _dup2... no checking for _opendir... no checking for _readdir... no checking for _seekdir... no checking for _telldir... no checking for _closedir... no checking for __dup... yes checking for __dup2... yes checking for __opendir... yes checking for __readdir... yes checking for __seekdir... yes checking for __telldir... yes checking for __closedir... yes checking for __getcwd... yes che...