search for: sched_annotate_sleep

...gt; AFAIK this is currently not a problem. According to > > http://lwn.net/Articles/627419/ these kmalloc calls never > > fail because they allocate less than a page. > > I strongly suggest you unlearn that fact. > The fix for this is in two parts: > > 1) Annotate using sched_annotate_sleep() and add a comment: we may spin > a few times in low memory situations, but this isn't a high > performance path. > > 2) Handle get_config (and other) failure in some more elegant way. > > Cheers, > Rusty. I agree, but I'd like to point out that even without k...

...gt; AFAIK this is currently not a problem. According to > > http://lwn.net/Articles/627419/ these kmalloc calls never > > fail because they allocate less than a page. > > I strongly suggest you unlearn that fact. > The fix for this is in two parts: > > 1) Annotate using sched_annotate_sleep() and add a comment: we may spin > a few times in low memory situations, but this isn't a high > performance path. > > 2) Handle get_config (and other) failure in some more elegant way. > > Cheers, > Rusty. I agree, but I'd like to point out that even without k...

...> http://lwn.net/Articles/627419/ these kmalloc calls never > > > > fail because they allocate less than a page. > > > > > > I strongly suggest you unlearn that fact. > > > The fix for this is in two parts: > > > > > > 1) Annotate using sched_annotate_sleep() and add a comment: we may spin > > > a few times in low memory situations, but this isn't a high > > > performance path. > > > > > > 2) Handle get_config (and other) failure in some more elegant way. > > Do you mean we need to enable the calle...

...> http://lwn.net/Articles/627419/ these kmalloc calls never > > > > fail because they allocate less than a page. > > > > > > I strongly suggest you unlearn that fact. > > > The fix for this is in two parts: > > > > > > 1) Annotate using sched_annotate_sleep() and add a comment: we may spin > > > a few times in low memory situations, but this isn't a high > > > performance path. > > > > > > 2) Handle get_config (and other) failure in some more elegant way. > > Do you mean we need to enable the calle...

...t;> > http://lwn.net/Articles/627419/ these kmalloc calls never > >> > fail because they allocate less than a page. > >> > >> I strongly suggest you unlearn that fact. > >> The fix for this is in two parts: > >> > >> 1) Annotate using sched_annotate_sleep() and add a comment: we may spin > >> a few times in low memory situations, but this isn't a high > >> performance path. > >> > >> 2) Handle get_config (and other) failure in some more elegant way. > >> > >> Cheers, > >> Rus...

...t;> > http://lwn.net/Articles/627419/ these kmalloc calls never > >> > fail because they allocate less than a page. > >> > >> I strongly suggest you unlearn that fact. > >> The fix for this is in two parts: > >> > >> 1) Annotate using sched_annotate_sleep() and add a comment: we may spin > >> a few times in low memory situations, but this isn't a high > >> performance path. > >> > >> 2) Handle get_config (and other) failure in some more elegant way. > >> > >> Cheers, > >> Rus...

...not a problem. According to >> > http://lwn.net/Articles/627419/ these kmalloc calls never >> > fail because they allocate less than a page. >> >> I strongly suggest you unlearn that fact. >> The fix for this is in two parts: >> >> 1) Annotate using sched_annotate_sleep() and add a comment: we may spin >> a few times in low memory situations, but this isn't a high >> performance path. >> >> 2) Handle get_config (and other) failure in some more elegant way. >> >> Cheers, >> Rusty. > > I agree, but I'd...

...not a problem. According to >> > http://lwn.net/Articles/627419/ these kmalloc calls never >> > fail because they allocate less than a page. >> >> I strongly suggest you unlearn that fact. >> The fix for this is in two parts: >> >> 1) Annotate using sched_annotate_sleep() and add a comment: we may spin >> a few times in low memory situations, but this isn't a high >> performance path. >> >> 2) Handle get_config (and other) failure in some more elegant way. >> >> Cheers, >> Rusty. > > I agree, but I'd...

On Thu, 26 Feb 2015 11:50:42 +1030 Rusty Russell <rusty at rustcorp.com.au> wrote: > Thomas Huth <thuth at linux.vnet.ibm.com> writes: > > Hi all, > > > > with the recent kernel 3.19, I get a kernel warning when I start my > > KVM guest on s390 with virtio balloon enabled: > > The deeper problem is that virtio_ccw_get_config just silently fails on

On Thu, 26 Feb 2015 11:50:42 +1030 Rusty Russell <rusty at rustcorp.com.au> wrote: > Thomas Huth <thuth at linux.vnet.ibm.com> writes: > > Hi all, > > > > with the recent kernel 3.19, I get a kernel warning when I start my > > KVM guest on s390 with virtio balloon enabled: > > The deeper problem is that virtio_ccw_get_config just silently fails on

...ver > > > > > > fail because they allocate less than a page. > > > > > > > > > > I strongly suggest you unlearn that fact. > > > > > The fix for this is in two parts: > > > > > > > > > > 1) Annotate using sched_annotate_sleep() and add a comment: we may spin > > > > > a few times in low memory situations, but this isn't a high > > > > > performance path. > > > > > > > > > > 2) Handle get_config (and other) failure in some more elegant way. > >...

...ver > > > > > > fail because they allocate less than a page. > > > > > > > > > > I strongly suggest you unlearn that fact. > > > > > The fix for this is in two parts: > > > > > > > > > > 1) Annotate using sched_annotate_sleep() and add a comment: we may spin > > > > > a few times in low memory situations, but this isn't a high > > > > > performance path. > > > > > > > > > > 2) Handle get_config (and other) failure in some more elegant way. > >...

...ne, int preempt_offset); +extern void __cant_migrate(const char *file, int line); /** * might_sleep - annotation for functions that can sleep @@ -227,6 +228,18 @@ extern void __cant_sleep(const char *fil # define cant_sleep() \ do { __cant_sleep(__FILE__, __LINE__, 0); } while (0) # define sched_annotate_sleep() (current->task_state_change = 0) + +/** + * cant_migrate - annotation for functions that cannot migrate + * + * Will print a stack trace if executed in code which is migratable + */ +# define cant_migrate() \ + do { \ + if (IS_ENABLED(CONFIG_SMP)) \ + __cant_migrate(__FILE__...

...onfig are expected to fail. > > AFAIK this is currently not a problem. According to > http://lwn.net/Articles/627419/ these kmalloc calls never > fail because they allocate less than a page. I strongly suggest you unlearn that fact. The fix for this is in two parts: 1) Annotate using sched_annotate_sleep() and add a comment: we may spin a few times in low memory situations, but this isn't a high performance path. 2) Handle get_config (and other) failure in some more elegant way. Cheers, Rusty.

...roblem. According to > > > http://lwn.net/Articles/627419/ these kmalloc calls never > > > fail because they allocate less than a page. > > > > I strongly suggest you unlearn that fact. > > The fix for this is in two parts: > > > > 1) Annotate using sched_annotate_sleep() and add a comment: we may spin > > a few times in low memory situations, but this isn't a high > > performance path. > > > > 2) Handle get_config (and other) failure in some more elegant way. Do you mean we need to enable the caller to deal with get_config fail...

...627419/ these kmalloc calls never > > > > > fail because they allocate less than a page. > > > > > > > > I strongly suggest you unlearn that fact. > > > > The fix for this is in two parts: > > > > > > > > 1) Annotate using sched_annotate_sleep() and add a comment: we may spin > > > > a few times in low memory situations, but this isn't a high > > > > performance path. > > > > > > > > 2) Handle get_config (and other) failure in some more elegant way. > > > > Do you me...

...onfig are expected to fail. > > AFAIK this is currently not a problem. According to > http://lwn.net/Articles/627419/ these kmalloc calls never > fail because they allocate less than a page. I strongly suggest you unlearn that fact. The fix for this is in two parts: 1) Annotate using sched_annotate_sleep() and add a comment: we may spin a few times in low memory situations, but this isn't a high performance path. 2) Handle get_config (and other) failure in some more elegant way. Cheers, Rusty.

...roblem. According to > > > http://lwn.net/Articles/627419/ these kmalloc calls never > > > fail because they allocate less than a page. > > > > I strongly suggest you unlearn that fact. > > The fix for this is in two parts: > > > > 1) Annotate using sched_annotate_sleep() and add a comment: we may spin > > a few times in low memory situations, but this isn't a high > > performance path. > > > > 2) Handle get_config (and other) failure in some more elegant way. Do you mean we need to enable the caller to deal with get_config fail...

...627419/ these kmalloc calls never > > > > > fail because they allocate less than a page. > > > > > > > > I strongly suggest you unlearn that fact. > > > > The fix for this is in two parts: > > > > > > > > 1) Annotate using sched_annotate_sleep() and add a comment: we may spin > > > > a few times in low memory situations, but this isn't a high > > > > performance path. > > > > > > > > 2) Handle get_config (and other) failure in some more elegant way. > > > > Do you me...

...icles/627419/ these kmalloc calls never > > >> > fail because they allocate less than a page. > > >> > > >> I strongly suggest you unlearn that fact. > > >> The fix for this is in two parts: > > >> > > >> 1) Annotate using sched_annotate_sleep() and add a comment: we may spin > > >> a few times in low memory situations, but this isn't a high > > >> performance path. > > >> > > >> 2) Handle get_config (and other) failure in some more elegant way. > > >> > > >...