search for: rnnnn

...in the first place AFAIK. > So I don't see any obstacle to have a regex that would match any part of the commit message. So, when I revert patches (using the git-svn script), it sets the title to: "Revert: <old title>" then writes on the body *only* "This reverts commit rNNNNN.". Unless the git-hook has a way look into rNNNN's commit message, or the PR is on the title, I don't know how it would match it... --renato

On 17 May 2016 at 20:04, Justin Bogner via llvm-dev <llvm-dev at lists.llvm.org> wrote: >> Note that this would also fire when a commit referring to a PR gets >> reverted (assuming the reverting commit doesn't botch the commit >> message), etc., which is super useful for those following along on the >> bug's cc list. > > +1. This would be a very useful

...time. A commit that "Fixes PR123" does not necessarily close it. There may be multiple commits, or we may wait until the buildbots are happy to close it (I certainly do). I think that the update here is simpler than that: Whenever a commit refers a PR, update the bug saying "commit rNNNN was marked as a fix to this bug". People CC on the bug can then verify and act appropriately. > For B, assuming the PR or Diffusion becomes the way to keep trace of every > fixes, it is a matter of making easy to document that we are fixing a bug > even if a PR does not exist. Mayb...

Filing a PR for *every* fix is overkill. But filing a PR to express "please merge this to the branch" (if there isn't already a PR) seems reasonable. --paulr From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Reid Kleckner via llvm-dev Sent: Thursday, May 05, 2016 10:09 AM To: Quentin Colombet Cc: llvm-dev Subject: Re: [llvm-dev] [RFC] Helping release