search for: remotefilenam

...InDocs; Cancellable], [], "internal test function - do not use", "\ @@ -2714,7 +2714,8 @@ Reread the partition table on C<device>. This uses the L<blockdev(8)> command."); - ("upload", (RErr, [FileIn "filename"; Dev_or_Path "remotefilename"], []), 66, [Progress], + ("upload", (RErr, [FileIn "filename"; Dev_or_Path "remotefilename"], []), 66, + [Progress; Cancellable], [InitScratchFS, Always, TestOutput ( (* Pick a file from cwd which isn't likely to change. *) [["mkdir...

This is a further, more comprehensive fix for https://bugzilla.redhat.com/show_bug.cgi?id=788641 The guestfish 'edit' command (aka 'emacs', 'vi') suffered from the same problems as virt-edit and more. It could have failed and left a partially overwritten file, and it didn't preserve permissions etc from the original file. These three patches fix all this. The first

..."e3eda01d9815f8d24aae2dbd89b68b06")], + ["checksum"; "md5"; "/COPYING.LIB"]], + Digest.to_hex (Digest.file "COPYING.LIB"))], "upload a file from the local machine", "\ Upload local file C<filename> to C<remotefilename> on the @@ -1772,7 +1773,8 @@ See also C<guestfs_download>."); [["upload"; "../COPYING.LIB"; "/COPYING.LIB"]; ["download"; "/COPYING.LIB"; "testdownload.tmp"]; ["upload"; "testdownload.t...

.../* guestfish edit command, suggested by Ján Ondrej, implemented by RWMJ */ @@ -135,7 +134,8 @@ run_edit (const char *cmd, size_t argc, char *argv[]) /* Set the permissions, UID, GID and SELinux context of the new * file to match the old file (RHBZ#788641). */ - if (copy_attributes (remotefilename, newname) == -1) + if (guestfs_copy_attributes (g, remotefilename, newname, + GUESTFS_COPY_ATTRIBUTES_ALL, 1, -1) == -1) return -1; if (guestfs_mv (g, newname, remotefilename) == -1) @@ -177,53 +177,3 @@ generate_random_name (const char *filename) return ret; /* caller will fr...

Hi, this series does a couple of code reorganizations/refactoring in code used by tools: the windows path handling code, and the two types of file editing (using editor, and using perl expression). There's still a code duplication between the two variants of file editing, but it is just within a single source, and can be easily solved now (planning as next step). Pino Toscano (13): edit:

...ibvirt I tend to do: v = rb_hash_aref(optsargv, rb_str_new2("readonly")); That being said, your way may actually be faster since you aren't allocating a new object. Minor in any case, they both work. 6) In ruby_guestfs_download() and elsewhere, there is code like: Check_Type (remotefilenamev, T_STRING); const char *remotefilename = StringValueCStr (remotefilenamev); if (!remotefilename) rb_raise (rb_eTypeError, "expected string for parameter %s of %s", "remotefilename", "download"); First, the Check_Type isn't strictly necessar...

...ure-guestfish-hexedit/#content The first part implements two new APIs for partial writing and reading of files. These are modelled after guestfs_upload and guestfs_download but allow you to specify an offset and (for download only) a size: int guestfs_download_offset (guestfs_h *g, const char *remotefilename, const char *filename, int64_t offset, int64_t size); int guestfs_upload_offset (guestfs_h *g, const char *filename, const char *remotefilename, int64_t offset); Since these calls use the streaming FileIn/FileOut part of the protocol, they are both efficient and unlimited in the amount and...

...? ? (g=g at entry=0xae06f0, fn=fn at entry=0x7f6dd16aa308 "download", hdr=hdr at entry= > 0x7fffa95cc610, err=err at entry=0x7fffa95cc5e0, xdrp=xdrp at entry=0x0, ret= > ret at entry=0x0) > ? ? at proto.c:668 > #11 0x00007f6dd163825e in guestfs_download (g=g at entry=0xae06f0, remotefilename= > <optimized out>, filename=0x7f6dd17edea0 "/tmp/1") at actions-5.c:2984 > #12 0x00007f6dd17ab01a in guestfs_int_py_download (self=<optimized out>, args= > <optimized out>) at actions-5.c:794 > ? > > > On Mon, Feb 13, 2023 at 10:16 PM Richard W.M...

Hi, attached there is a prototype of patch for adding a new copy-attributes command. Such command would allow copy the attributes of a "file" to another, so for example in guestfish: copy-attributes foo bar permissions:true xattributes:false would only copy the permissions of foo to bar, not copying its extended attributes too. Just few notes: - my first daemon command, so

I'm currently working on gobject bindings for libguestfs. I haven't got as far as compiling anything yet, but I've attached the C header for initial review. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 -------------- next part -------------- An embedded and

...another location, you should provide the full path in the first parameter. @@ -4688,10 +4688,10 @@ This uses the L<blockdev(8)> command." }; ]; shortdesc = "upload a file from the local machine"; longdesc = "\ -Upload local file C<filename> to C<remotefilename> on the +Upload local file F<filename> to F<remotefilename> on the filesystem. -C<filename> can also be a named pipe. +F<filename> can also be a named pipe. See also C<guestfs_download>." }; @@ -4712,10 +4712,10 @@ See also C<guestfs_download>.&q...

...Always, TestRun [["blockdev_rereadpt"; "/dev/sda"]], [] @@ -2708,7 +2708,7 @@ This uses the L<blockdev(8)> command." }; { defaults with name = "upload"; added = (1, 0, 2); - style = RErr, [FileIn "filename"; Dev_or_Path "remotefilename"], []; + style = RErr, [String (FileIn, "filename"); String (Dev_or_Path, "remotefilename")], []; progress = true; cancellable = true; tests = [ InitScratchFS, Always, TestResultString ( @@ -2729,7 +2729,7 @@ See also C<guestfs_download>." };...

Very large but mechanical change to the generator. Rich.

This is a follow-up to the other generator changes in: https://www.redhat.com/archives/libguestfs/2017-February/msg00217.html Rich.

Split up the huge generator/actions.ml into several smaller files. Rich.

This started as a simple warning-elimination change. I'll get back to that series shortly ;-) It turned into a factorization and constification exercise during which I got a taste of ocaml. Thanks to Rich Jones for help with a few snippets in generator.ml. The overall result is that many previously-manually-maintained bits from daemon/*.c functions are now hoisted into the automatically-

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.