search for: release_23_vs2005

...ve assert(0 && ...) at the end) at line 622 and 605 without calling abort() -- Visual Studio give warnings about other places that _do_ call abort() as well, but I guess that's fine. -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: release_23_vs2005.patch URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080521/f625eef4/attachment.ksh>

Ok, thanks. So it seems like we have to deviate from mainline a bit. I can apply the patch that you proposed in your earlier mail. Sound ok? I just need someone to verify that it works with 2008 so that everyone is happy. -Tanya On Wed, 21 May 2008 morten at hue.no wrote: > >> I just sent a reply to Razvan with 3 patches that I think should be merged >> into the release

>I just sent a reply to Razvan with 3 patches that I think should be merged >into the release branch. I want to keep it somewhat in sync with mainline. >Can you try applying those 3 patches and let me know if it builds for you >and what version of MSVC you have? It doesn't build. first problem is patch 51098 that adds lib\VMCore\Use.cpp and lib\Transforms\Utils\UnrollLoop.cpp

As I saw from the mailing list the MSVC 2005 patches were made to take into account the new files from the development branch, files which are not in the 2.3 release. So for now the below patch is the only one functional for the release. If I am wrong, please someone correct me. If someone can make a 2005 patch for the release branch, it is ok. Else, I am afraid that this one is for now the

> This is my patch for MSVC 2008 and it was applied by Chris: > > http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080512/062390.html > > I tested it and it is ok for the 2.3 release. I don't believe I can apply this patch. There have been several patches applied recently to TOT to allow MSVC 2005 which I think many people are using. Does this patch mean that one