search for: recv_exclude_list

...implementation and also a straight cygwin/rsync install. I'm experiencing the following errors: using cygwin implementation: $ sh clientupload.sh /cygdrive/c/batch1/ready/ Sending files... Sending /cygdrive/c/batch1/ready/: building file list ... 25 files to consider ERROR: buffer overflow in recv_exclude_list rsync error: error allocating core memory buffers (code 22) at util.c(121) rsync: read error: Connection reset by peer (104) rsync error: error in rsync protocol data stream (code 12) at /home/lapo/packaging/tmp/rsync-2.6.3/io.c(515) using cwrsync: C:\cwrsync>rsync --rsh="ssh" --recu...

...te=1 -pogtvS /var/spool/mail/* /md7/mail_backup/`date "+%H"`/ ----- Forwarded message from fcron <root> ----- To: root@hvs Subject: Output of fcron job: '/usr/local/sbin/mail_backup' From: fcron <root> Date: Sun, 27 Jun 2004 21:20:00 +0200 ERROR: buffer overflow in recv_exclude_list rsync error: error allocating core memory buffers (code 22) at util.c(122) rsync: connection unexpectedly closed (8 bytes read so far) rsync error: error in rsync protocol data stream (code 12) at io.c(342) 21:20:00 Job /usr/local/sbin/mail_backup terminated (exit status: 12) (mailing output) ----...

...tried versions 2.5.4-6. They all seem to have the same problems. Currently, I'm trying to use SystemImager, which uses rsync to transfer files. I get this: get_boel_binaries_tarball rsync -av 10.1.2.14::boot/i386/SMC/boel_binaries.tar.gz /tmp/ receiving file list ... ERROR: buffer overflow in recv_exclude_list rsync error: error allocating core memory buffers (code 22) at util.c(238) rsync: connection unexpectedly closed (28 bytes read so far) Looking at the code for recv_exclude_list, it seems real simple. However, I do see a couple of issues. Using 2.5.6 source code, line 314 of exclude.c has an unsig...

...r) { - if (read_batch) - create_flist_from_batch(); /* sets batch_flist */ ret = local_child(argc, args, f_in, f_out, child_main); } else { ret = piped_child(args,f_in,f_out); --- 263,268 ---- *************** *** 505,515 **** if (delete_mode && !delete_excluded) recv_exclude_list(f_in); ! ! if (read_batch) ! flist = batch_flist; ! else ! flist = recv_file_list(f_in); if (!flist) { rprintf(FERROR,"server_recv: recv_file_list error\n"); exit_cleanup(RERR_FILESELECT); --- 503,509 ---- if (delete_mode && !delete_excluded) recv...

...t, -1); } io_flush(); ! msleep(100); kill(pid, SIGUSR2); wait_process(pid, &status); return status; *************** *** 476,481 **** --- 478,484 ---- } } + io_start_buffering_in(f_in); if (delete_mode && !delete_excluded) recv_exclude_list(f_in); *************** *** 569,574 **** --- 572,578 ---- extern int cvs_exclude; extern int delete_mode; extern int delete_excluded; + io_start_buffering_out(f_out); if (cvs_exclude) add_cvs_excludes(); if (delete_mode &...

> Just curious: what about the rsync+ patch? Thanks for the reminder. I've just committed Jos's rsync+ patch onto the "branch_mbp_rsyncplus_merge" branch. If it works OK and nobody screams I will move it across onto the main tree tomorrow or Wednesday. I see the patch doesn't add documentation about the new options to the man page, so we should fix that in the future.

...9) { rprintf(FERROR,"remote rsync does not support include syntax - aborting\n"); @@ -294,6 +388,7 @@ } else { write_int(f,l); } + } write_buf(f,pattern,l); } @@ -309,7 +404,7 @@ while ((l=read_int(f))) { if (l >= MAXPATHLEN) overflow("recv_exclude_list"); read_sbuf(f,line,l); - add_exclude(line,0); + add_exclude(line,0,0); } } @@ -362,25 +457,25 @@ } -void add_exclude_line(char *p) +void add_exclude_line(char *p, int regexp) { char *tok; if (!p || !*p) return; p = strdup(p); if (!p) out_of_memory("add_exclude_li...

...-421,7 +423,7 @@ close(error_pipe[1]); if (f_in != f_out) close(f_in); - io_start_buffering(f_out); + io_start_buffering_out(f_out); io_set_error_fd(error_pipe[0]); @@ -476,6 +478,7 @@ } } + io_start_buffering_in(f_in); if (delete_mode && !delete_excluded) recv_exclude_list(f_in); @@ -569,6 +572,7 @@ extern int cvs_exclude; extern int delete_mode; extern int delete_excluded; + io_start_buffering_out(f_out); if (cvs_exclude) add_cvs_excludes(); if (delete_mode && !delete_excluded) @@ -578,7 +582,10 @@ if (verbose > 3)...

...dw */ - extern struct file_list *batch_flist; /* dw */ + extern int read_batch; + extern struct file_list *batch_flist; if (verbose > 2) rprintf(FINFO,"server_recv(%d) starting pid=%d\n",argc,(int)getpid()); @@ -470,7 +470,7 @@ if (delete_mode && !delete_excluded) recv_exclude_list(f_in); - if (read_batch) /* dw */ + if (read_batch) flist = batch_flist; else flist = recv_file_list(f_in); @@ -497,7 +497,7 @@ extern int cvs_exclude; extern int am_sender; extern int remote_version; - extern int read_batch; /* dw */ + extern int read_batch; setup_proto...

...extern int orig_umask; extern int preserve_hard_links; extern int protocol_version; @@ -558,6 +559,8 @@ void start_server(int f_in, int f_out, i io_start_multiplex_out(f_out); if (am_sender) { + if (need_messages_from_generator) + io_start_multiplex_in(f_in); if (!read_batch) { recv_exclude_list(f_in); if (cvs_exclude) @@ -623,6 +626,9 @@ int client_run(int f_in, int f_out, pid_ io_flush(FULL_FLUSH); exit_cleanup(status); } + + if (need_messages_from_generator) + io_start_multiplex_out(f_out); if (argc == 0) { list_only = 1; Index: options.c --- options.c 15 Jan 2004 17...

...(FERROR,"server_recv: recv_file_list error\n"); --- 568,573 ---- *************** *** 585,590 **** --- 607,614 ---- if (am_sender) { keep_dirlinks = 0; /* Must be disabled on the sender. */ + + /* TODO: I suspect this limitation can be removed. */ if (!read_batch) { recv_exclude_list(f_in); if (cvs_exclude) *************** *** 609,623 **** char *local_name = NULL; cleanup_child_pid = pid; ! if (read_batch) ! flist = batch_flist; set_nonblocking(f_in); set_nonblocking(f_out); setup_protocol(f_out,f_in); ! if (protocol_version >= 23) io_...