search for: rb_alloc_func_t

ruby bindings fail to build with ruby 1.8.7 because rb_alloc_func_t does not exist in this version of ruby. This happens due to commit 448a02373df95dafc0d4b3e4db0e77c96a09074d Olaf

I needed to add a few patches to be able to build libguestfs 1.20.2 out of tree. Mostly srcdir/builddir issues -- I think that I had posted something for building the daemon before. As mentioned on IRC, I found that compiling (Ruby bindings) caused config.h file shipped with the Ruby headers to be included rather than ${builddir}/config.h. This can be fixed because the relevant checks can be

...d, 3 insertions(+), 2 deletions(-) diff --git a/ruby/ext/guestfs/extconf.rb.in b/ruby/ext/guestfs/extconf.rb.in index c4551fa6c..6b806101e 100644 --- a/ruby/ext/guestfs/extconf.rb.in +++ b/ruby/ext/guestfs/extconf.rb.in @@ -33,8 +33,9 @@ have_func("rb_define_alloc_func") have_type("rb_alloc_func_t") $CFLAGS = - "#{$CFLAGS} @CFLAGS@ -DGUESTFS_PRIVATE=1 " << - "@WARN_CFLAGS@ @WERROR_CFLAGS@" + "#{$CFLAGS} " << + "@WARN_CFLAGS@ @WERROR_CFLAGS@ " << + "@CFLAGS@ -DGUESTFS_PRIVATE=1" create_header create_makefile(...

Here are three patches that fix issues with out-of-tree building and one that uses Ruby's own autoconf stuff for determining how Ruby bindings should be built. Cheers, -Hilko

...err by default. */ guestfs_set_error_handler (g, NULL, NULL); - /* Wrap it, and make sure the close function is called when the - * handle goes away. - */ return Data_Wrap_Struct (c_guestfs, NULL, ruby_guestfs_free, g); } @@ -707,10 +760,10 @@ Init__guestfs (void) #ifndef HAVE_TYPE_RB_ALLOC_FUNC_T #define rb_alloc_func_t void* #endif - rb_define_alloc_func (c_guestfs, (rb_alloc_func_t) ruby_guestfs_create); + rb_define_alloc_func (c_guestfs, (rb_alloc_func_t) ruby_guestfs_alloc); #endif - rb_define_module_function (m_guestfs, \"create\", ruby_guestfs_create, -1); + rb_defi...

See this bug for background information: https://bugzilla.redhat.com/show_bug.cgi?id=1350465 Thanks: Tomáš Golembiovský --- v2v/virt-v2v.pod | 38 ++++++++++++++++++++++++++------------ 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/v2v/virt-v2v.pod b/v2v/virt-v2v.pod index e68d75cf8..0943bf305 100644 --- a/v2v/virt-v2v.pod +++ b/v2v/virt-v2v.pod @@ -1909,18 +1909,32 @@ that

See this bug for background information: https://bugzilla.redhat.com/show_bug.cgi?id=1350465 --- v2v/virt-v2v.pod | 39 +++++++++++++++++++++++++++------------ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/v2v/virt-v2v.pod b/v2v/virt-v2v.pod index e68d75cf8..93d1a9ecd 100644 --- a/v2v/virt-v2v.pod +++ b/v2v/virt-v2v.pod @@ -1909,18 +1909,33 @@ that guest through the RHV-M UI,

If the connection is not local, paths of disks will refer to the remote host, which were mistakenly handled as local paths (in the best case failing to open a non-existing disk, and in the worst case opening a different disk!). In case the disks are remote resources like ssh or ceph, nothing guarantees that the hostname can be reached from the local machine, or even that it is actually the same on

Hopefully this time ...