search for: r328595

...bably >> these things should be sunk into BinaryFormat as is the case for DWARF >> features used by MC? >> > > I'd be OK with that. We could very easily introduce true link dependencies > on that library in the near future. > OK - added the LLVMBuild.txt change in r328595 > include/llvm/Object/COFF.h includes >> include/llvm/DebugInfo/CodeView/CVDebugRecord.h >> Also seems like this could/should/needs to be sunk into BinaryFormat? >> > > These things are really more PE/PDB related than CodeView. They are in the > wrong place. I'...

...s the case for DWARF >>>> features used by MC? >>>> >>> >>> I'd be OK with that. We could very easily introduce true link >>> dependencies on that library in the near future. >>> >> >> OK - added the LLVMBuild.txt change in r328595 >> > > Hmm, not perfect - this creates a bit of a circular dependency: > > llvm-tblgen > MC > DebugInfo/CodeView > Object > Bitcode/Reader > IR (including lib/IR/AttributesCompatFunc.inc) > llvm-tblgen (to generate AttributesCompatFunc.inc) > > This is just...

...d be sunk into BinaryFormat as is the case for DWARF >>> features used by MC? >>> >> >> I'd be OK with that. We could very easily introduce true link >> dependencies on that library in the near future. >> > > OK - added the LLVMBuild.txt change in r328595 > Hmm, not perfect - this creates a bit of a circular dependency: llvm-tblgen MC DebugInfo/CodeView Object Bitcode/Reader IR (including lib/IR/AttributesCompatFunc.inc) llvm-tblgen (to generate AttributesCompatFunc.inc) This is just a specific path shown by the internal build system - no doub...

...gt; DWARF features used by MC? >>>>> >>>> >>>> I'd be OK with that. We could very easily introduce true link >>>> dependencies on that library in the near future. >>>> >>> >>> OK - added the LLVMBuild.txt change in r328595 >>> >> >> Hmm, not perfect - this creates a bit of a circular dependency: >> >> llvm-tblgen >> MC >> DebugInfo/CodeView >> Object >> Bitcode/Reader >> IR (including lib/IR/AttributesCompatFunc.inc) >> llvm-tblgen (to generate Attr...

On Wed, Mar 21, 2018 at 11:31 AM David Blaikie <dblaikie at gmail.com> wrote: > I'm looking at fixing some layering violations in LLVM & came across a few > in the CodeView handling, specifically: > > lib/MC/MCCodeView includes several llvm/DebugInfo/CodeView headers > I guess MC could be made dependent on DebugInfoCodeView? But probably > these things should be

...C? >>>>>> >>>>> >>>>> I'd be OK with that. We could very easily introduce true link >>>>> dependencies on that library in the near future. >>>>> >>>> >>>> OK - added the LLVMBuild.txt change in r328595 >>>> >>> >>> Hmm, not perfect - this creates a bit of a circular dependency: >>> >>> llvm-tblgen >>> MC >>> DebugInfo/CodeView >>> Object >>> Bitcode/Reader >>> IR (including lib/IR/AttributesCompatFunc.inc...

I'm looking at fixing some layering violations in LLVM & came across a few in the CodeView handling, specifically: lib/MC/MCCodeView includes several llvm/DebugInfo/CodeView headers I guess MC could be made dependent on DebugInfoCodeView? But probably these things should be sunk into BinaryFormat as is the case for DWARF features used by MC? include/llvm/Object/COFF.h includes