search for: qemu_supports_virtio_scsi

Currently virtio_scsi is forced if qemu in the host supports this feature. This test does however not take the capabilities of the started guest into account. As a result no disks will be found if the guest kernel is older than 3.4. I forced qemu_supports_virtio_scsi to return always 0, which seem to work well for the kernel versions as shipped in SLES11SP2, openSuSE 12.1 and older. Is there any functionality that would be missing if a guest kernel has just virtio_blk? How can I force the host tools to not enable virtio_scsi? Should it be a runtime option, or...

These assorted patches end up with adding virtio-scsi support to libguestfs. It passes libguestfs-test-tool, but I haven't yet tried to run the full set of tests. In theory > 26 devices can be added, but it's likely that certain parts of the daemon will break if you actually try this. This of course needs to be fixed. Thanks Paolo Bonzini for invaluable help. Rich.

More comprehensive support for virtio-scsi. Passes all the tests. Rich.

...evice (g, data, "virtio-rng-pci")) { + ADD_CMDLINE ("-object"); + ADD_CMDLINE ("rng-random,filename=/dev/urandom,id=rng0"); + ADD_CMDLINE ("-device"); + ADD_CMDLINE ("virtio-rng-pci,rng=rng0"); + } + /* Add drives */ virtio_scsi = qemu_supports_virtio_scsi (g, data); diff --git a/src/launch-libvirt.c b/src/launch-libvirt.c index 9f2672d..c6cc740 100644 --- a/src/launch-libvirt.c +++ b/src/launch-libvirt.c @@ -1251,6 +1251,20 @@ construct_libvirt_xml_devices (guestfs_h *g, } #endif + /* Add a random number generator (backend for virtio-rn...

v1 -> v2: - Rebase on top of Pino's version work. Two patches went upstream, these are the two remaining patches. Note the generation number is still inside the qemu.stat file. We could put it in the filename, I have no particular preference. Rich.

Doing qemu feature detection in the direct backend takes ~100ms because we need to run `qemu -help' and `qemu -devices ?', and each of those interacts with glibc's very slow link loader. Fixing the link loader is really hard. Instead memoize the output of those two commands. This patch series first separates all the code dealing with qemu into a separate module (src/qemu.c) and

...qemu); + g->hv = new_hv; + return 0; } diff --git a/src/launch-direct.c b/src/launch-direct.c index f45f582..2d4073a 100644 --- a/src/launch-direct.c +++ b/src/launch-direct.c @@ -101,6 +101,7 @@ static int qemu_supports_device (guestfs_h *g, struct backend_direct_data *, con static int qemu_supports_virtio_scsi (guestfs_h *g, struct backend_direct_data *); static char *qemu_escape_param (guestfs_h *g, const char *param); +#ifdef QEMU_OPTIONS /* Like 'add_cmdline' but allowing a shell-quoted string of zero or * more options. XXX The unquoting is not very clever. */ @@ -156,6 +157,7 @@ add_...

...launch-direct.c @@ -62,7 +62,7 @@ struct backend_direct_data { char *qemu_devices; /* Output of qemu -device ? */ /* qemu version (0, 0 if unable to parse). */ - int qemu_version_major, qemu_version_minor; + struct version qemu_version; int virtio_scsi; /* See function qemu_supports_virtio_scsi */ @@ -420,8 +420,7 @@ launch_direct (guestfs_h *g, void *datav, const char *arg) if (qemu_supports (g, data, "-no-hpet")) { ADD_CMDLINE ("-no-hpet"); } - if (data->qemu_version_major < 1 || - (data->qemu_version_major == 1 && data->qemu_ve...

...@ static int is_openable (guestfs_h *g, const char *path, int flags); static void print_qemu_command_line (guestfs_h *g, char **argv); static int qemu_supports (guestfs_h *g, const char *option); +#if 0 static int qemu_supports_device (guestfs_h *g, const char *device_name); +#endif static int qemu_supports_virtio_scsi (guestfs_h *g); static char *qemu_drive_param (guestfs_h *g, const struct drive *drv, size_t index); @@ -826,6 +828,7 @@ qemu_supports (guestfs_h *g, const char *option) return strstr (g->app.qemu_help, option) != NULL; } +#if 0 /* Test if device is supported by qemu (currently just gr...

...list in supermin: https://github.com/libguestfs/supermin/blob/master/src/ext2_initrd.ml#L33 Anyhow, virtio-scsi definitely isn't working, as you can see from the appliance kernel output. You can force the direct backend to use virtio-blk instead by editing the function src/launch-direct.c: qemu_supports_virtio_scsi. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http:...

This preliminary patch series adds a libvirt backend to libguestfs. It's for review only because although it launches the guest OK, there are some missing features that need to be implemented. The meat of the patch is in part 4/4. To save you the trouble of interpreting libxml2 fragments, an example of the generated XML and the corresponding qemu command line are attached below. Note the

Error out early if the path to the socket will not fit into sockaddr_un::sun_path, as we will not be able to connect to it. --- src/launch-unix.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/launch-unix.c b/src/launch-unix.c index 740c554..973e14b 100644 --- a/src/launch-unix.c +++ b/src/launch-unix.c @@ -47,6 +47,12 @@ launch_unix (guestfs_h *g, void *datav, const char

...ou use writable NBD disks. + +=back + =head2 INSPECTION Libguestfs has APIs for inspecting an unknown disk image to find out diff --git a/src/launch-appliance.c b/src/launch-appliance.c index 122f143..4b70cc1 100644 --- a/src/launch-appliance.c +++ b/src/launch-appliance.c @@ -931,36 +931,46 @@ qemu_supports_virtio_scsi (guestfs_h *g) return g->app.virtio_scsi == 1; } +/* Convert a struct drive into a qemu -drive parameter. Note that if + * using virtio-scsi, then the code above adds a second -device + * parameter to connect this drive to the SCSI HBA, as is required by + * virtio-scsi. + */ static char...

On Wed, Jun 11, 2014 at 01:00:16PM +0530, abhishek jain wrote: > Hi RIch > > Below are the logs updated logs of libguestfs-test-tool on ubuntu powerpc... > > libguestfs-test-tool > ************************************************************ > * IMPORTANT NOTICE > * > * When reporting bugs, include the COMPLETE, UNEDITED >

Hi, this adds an helper version struct, and uses it in the backends (for the libvirt and qemu versions) and inspection code. This also moves common code to that, so it is not repeated in many places. This should help with the small refactoring proposed with https://www.redhat.com/archives/libguestfs/2016-May/msg00070.html Thanks, Pino Toscano (2): src: start unifying version handling

Hi, this adds an helper version struct, and uses it in the backends (for the libvirt and qemu versions) and inspection code. This also moves common code to that, so it is not repeated in many places. This should help with the small refactoring proposed with https://www.redhat.com/archives/libguestfs/2016-May/msg00070.html Thanks, Pino Toscano (2): src: start unifying version handling

...uestfs/supermin/blob/master/src/ext2_initrd.ml#L33 >> >> Anyhow, virtio-scsi definitely isn't working, as you can see from the >> appliance kernel output. You can force the direct backend to use >> virtio-blk instead by editing the function src/launch-direct.c: >> qemu_supports_virtio_scsi. >> >> Rich. >> >> -- >> Richard Jones, Virtualization Group, Red Hat >> http://people.redhat.com/~rjones >> Read my programming and virtualization blog: http://rwmj.wordpress.com >> virt-df lists disk usage of guests without needing to install any &g...

QEMU upstream has broken snapshot=on ... again. These two patches stop using it entirely. Instead we run 'qemu-img create' to create overlay disks as required. Note that the libvirt and UML backends were already doing this: The libvirt backend because <transient/> has never worked, and the UML backend was running uml_mkcow because the UML-equivalent syntax of snapshot=on was

Lots of changes since v2, too much to remember or summarize. Please ignore patch 11/11, it's just for my testing. Rich.