search for: qemu_img

...guestfs-building.pod index d85483a0b..94df49158 100644 --- a/docs/guestfs-building.pod +++ b/docs/guestfs-building.pod @@ -716,6 +716,12 @@ binary to find the version of Python, the location of Python libraries and so on. See L</BUILDING PYTHON 2 AND PYTHON 3 BINDINGS> below. +=item B<QEMU_IMG> + +This environment variable may be set to point to the full path of the +L<qemu-img(1)> program, in case it is on a nonstandard path or has a +nonstandard name. + =item B<SUPERMIN> This environment variable can be set to choose an alternative diff --git a/lib/command.c b/lib/co...

...launchpad.net/qemu/+bug/1740364 --- lib/info.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/info.c b/lib/info.c index 442a9755b..86044855e 100644 --- a/lib/info.c +++ b/lib/info.c @@ -149,6 +149,7 @@ get_json_output (guestfs_h *g, const char *filename) guestfs_int_cmd_add_arg (cmd, QEMU_IMG); guestfs_int_cmd_add_arg (cmd, "info"); + guestfs_int_cmd_add_arg (cmd, "-U"); guestfs_int_cmd_add_arg (cmd, "--output"); guestfs_int_cmd_add_arg (cmd, "json"); if (filename[0] == '/') -- 2.19.0.rc0

...rgets input output = let cmd = let filename = match t.target_file with - | TargetFile filename -> "file:" ^ filename + | TargetFile filename -> qemu_input_filename filename | TargetURI uri -> uri in [ Guestfs_config.qemu_img; "convert" ] @ (if not (quiet ()) then [ "-p" ] else []) @ -- 2.16.2

...address: 172.29.99.20 Hostname: pub02 Start time: Fri Jan 31 13:48:57 MST 2014 Shutdown time: Fri Jan 31 14:48:57 MST 2014 Termination time: Fri Jan 31 14:50:57 MST 2014 Waiting for updates. Problem with vm-035: Unexpected issue STDERR: 2014-01-31 13:48:44,412 - WARNING - no qemu_img configuration, copy-on-write support is disabled libvir: QEMU error : Domain not found: no domain with matching name 'wrksp-33' libvir: error : An error occurred, but the cause is unknown 2014-01-31 13:48:45,587 - ERROR - Problem creating the VM: An error occurred, but the cause is unknown...

This changes the infrastructure to allow the target_file to be a QEMU URI. Rich.

...ze_estimate cmdline overlays = + let json = cmdline.machine_readable in + if json then printf "{ \"disks\": [\n%!"; + List.iteri ( + fun i { ov_overlay_file } -> + if json && i > 0 then printf ",\n%!"; + let cmd = + [ Guestfs_config.qemu_img; "measure"; + (* For use of -O qcow2 here, see this thread: + * https://www.redhat.com/archives/libguestfs/2018-August/thread.html#00142 + *) + "-f"; "qcow2"; "-O"; "qcow2"; + "--output=" ^ (i...

...Inc., + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + *) + +open Std_utils +open Tools_utils +open JSON_parser +open Common_gettext.Gettext + +(* Run qemu-img measure on a disk. *) + +let measure ?format filename = + let cmd = ref [] in + List.push_back_list cmd [Guestfs_config.qemu_img; "measure"]; + (match format with + | None -> () + | Some format -> + List.push_back_list cmd ["-f"; format] + ); + (* For use of -O qcow2 here, see this thread: + * https://www.redhat.com/archives/libguestfs/2018-August/thread.html#00142 + *) + List.push_...

...(* Run qemu-img measure on a disk. *) + +let error_unexpected_output what json = + error (f_"qemu-img measure: unexpected output: %s\n\nqemu-img command printed:\n\n%s") + what json + +let measure ?format filename = + let cmd = ref [] in + List.push_back_list cmd [Guestfs_config.qemu_img; "measure"]; + (match format with + | None -> () + | Some format -> + List.push_back_list cmd ["-f"; format] + ); + (* For use of -O qcow2 here, see this thread: + * https://www.redhat.com/archives/libguestfs/2018-August/thread.html#00142 + *) + List.push_...

...Inc., + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + *) + +open Std_utils +open Tools_utils +open JSON_parser +open Common_gettext.Gettext + +(* Run qemu-img measure on a disk. *) + +let measure ?format filename = + let cmd = ref [] in + List.push_back_list cmd [Guestfs_config.qemu_img; "measure"]; + (match format with + | None -> () + | Some format -> + List.push_back_list cmd ["-f"; format] + ); + (* For use of -O qcow2 here, see this thread: + * https://www.redhat.com/archives/libguestfs/2018-August/thread.html#00142 + *) + List.push_...

...Inc., + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + *) + +open Std_utils +open Tools_utils +open JSON_parser +open Common_gettext.Gettext + +(* Run qemu-img measure on a disk. *) + +let measure ?format filename = + let cmd = ref [] in + List.push_back_list cmd [Guestfs_config.qemu_img; "measure"]; + (match format with + | None -> () + | Some format -> + List.push_back_list cmd ["-f"; format] + ); + (* For use of -O qcow2 here, see this thread: + * https://www.redhat.com/archives/libguestfs/2018-August/thread.html#00142 + *) + List.push_...

v4: - Same as v3, but depends on and uses new --machine-readable work. Rich.

v6: - Make the text output a bit nicer. - Changes as suggested to Measure_disk module temp file & json parsing. - Use jq to test JSON output. - Retest.

v5: - Normal output modified approx as suggested in previous email. - Machine readable output uses JSON.

The first commit removes the --dcpath parameter, which just makes the following stuff simpler. Since libvirt has supported getting datacenterpath from VMware since Oct 2015, it's time to drop this hairy parameter. The rest is quite a complicated series of refactorings, followed by a very simple change to add handling of snapshots taken from old virt-v2v. Rich.

I rethought this again, as I think that it's a dangerous assumption to bake qemu-img measure output into our API. This patch series runs qemu-img measure behind the scenes, but then parses the output and sums it to a single number which we print. Doing that required a bit of reworking, moving the Jansson [JSON parser] bindings from virt-builder into the common directory and a couple of other