Richard W.M. Jones
2018-May-22 07:11 UTC
[Libguestfs] [PATCH] v2v: Use Std_utils.qemu_input_filename instead of prefixing "file:" to filename (RHBZ#1580292).
This also allows us to use virt-v2v with the old version of qemu in RHEL 7. Fixes commit e29296cfa20dd691995832940a30fe2e6b98149a. Thanks: Pino Toscano for suggesting the fix. --- v2v/v2v.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2v/v2v.ml b/v2v/v2v.ml index 54a2b3998..363699701 100644 --- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -744,7 +744,7 @@ and copy_targets cmdline targets input output let cmd let filename match t.target_file with - | TargetFile filename -> "file:" ^ filename + | TargetFile filename -> qemu_input_filename filename | TargetURI uri -> uri in [ Guestfs_config.qemu_img; "convert" ] @ (if not (quiet ()) then [ "-p" ] else []) @ -- 2.16.2
Pino Toscano
2018-May-22 08:03 UTC
Re: [Libguestfs] [PATCH] v2v: Use Std_utils.qemu_input_filename instead of prefixing "file:" to filename (RHBZ#1580292).
On Tuesday, 22 May 2018 09:11:17 CEST Richard W.M. Jones wrote:> This also allows us to use virt-v2v with the old version of qemu in > RHEL 7. > > Fixes commit e29296cfa20dd691995832940a30fe2e6b98149a. > > Thanks: Pino Toscano for suggesting the fix. > ---LGTM (indeed I cannot not ACK this, since this is basically what I suggested). -- Pino Toscano
Possibly Parallel Threads
- [PATCH] v2v: Allow output modes to rewrite disk copying
- Re: [PATCH v2v] v2v: Allow output to block devices (RHBZ#1868690).
- [PATCH v2v] v2v: Allow output to block devices (RHBZ#1868690).
- [PATCH 2/2] v2v: Add --print-target to display overlay and target information.
- Re: [PATCH v2v] v2v: Allow output to block devices (RHBZ#1868690).