search for: prot_sg

...st/scsi.c Nicholas Bellinger 2015-01-31 579 struct vhost_scsi_cmd *cmd; 1a1ff8256af679c8 drivers/vhost/scsi.c Nicholas Bellinger 2015-01-31 580 struct vhost_scsi_nexus *tv_nexus; b1935f687bb93b20 drivers/vhost/scsi.c Nicholas Bellinger 2014-02-22 581 struct scatterlist *sg, *prot_sg; 3aee26b4ae91048c drivers/vhost/scsi.c Nicholas Bellinger 2013-06-21 582 struct page **pages; 10e9cbb6b531117b drivers/vhost/scsi.c Matthew Wilcox 2018-06-12 583 int tag, cpu; 057cbf49a1f08297 drivers/vhost/tcm_vhost.c Nicholas Bellinger 2012-07-18 584 9871831283e79575 driver...

...ertions(+), 5 deletions(-) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index fd6c8b66f06f..650533916c19 100644 --- a/drivers/vhost/scsi.c +++ b/drivers/vhost/scsi.c @@ -597,8 +597,7 @@ vhost_scsi_get_tag(struct vhost_virtqueue *vq, struct vhost_scsi_tpg *tpg, sg = cmd->tvc_sgl; prot_sg = cmd->tvc_prot_sgl; pages = cmd->tvc_upages; - memset(cmd, 0, sizeof(struct vhost_scsi_cmd)); - + memset(cmd, 0, sizeof(*cmd)); cmd->tvc_sgl = sg; cmd->tvc_prot_sgl = prot_sg; cmd->tvc_upages = pages; @@ -1757,5 +1756,5 @@ static int vhost_scsi_make_nexus(struct vhost_scsi_t...

...gt; level protection resources. (currently hardcoded to 1) > > It changes virtscsi_add_cmd() to attach outgoing / incoming > protection SGLs preceeding the data payload, and is using the > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > to signal to vhost/scsi how many prot_sgs to expect. > > v3 changes: > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > v2 changes: > - Make protection buffer come before data buffer (Paolo) > - Enable virtio_scsi_cmd_req_pi usage (Paolo) > > Cc: Paolo Bonzini <pbonzini at redh...

...gt; level protection resources. (currently hardcoded to 1) > > It changes virtscsi_add_cmd() to attach outgoing / incoming > protection SGLs preceeding the data payload, and is using the > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > to signal to vhost/scsi how many prot_sgs to expect. > > v3 changes: > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > v2 changes: > - Make protection buffer come before data buffer (Paolo) > - Enable virtio_scsi_cmd_req_pi usage (Paolo) > > Cc: Paolo Bonzini <pbonzini at redh...

...ed to 1) > > > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > protection SGLs preceeding the data payload, and is using the > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > v3 changes: > > > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > > > > > v2 changes: > > > - Make protection buffer come before data buffer (Paolo) > > > - Enable virtio_scsi_cmd_...

...ed to 1) > > > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > protection SGLs preceeding the data payload, and is using the > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > v3 changes: > > > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > > > > > v2 changes: > > > - Make protection buffer come before data buffer (Paolo) > > > - Enable virtio_scsi_cmd_...

...> > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > > > protection SGLs preceeding the data payload, and is using the > > > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > > > > > v3 changes: > > > > > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > > > > > > > > > v2 changes: > > > > > - Make protection buffer come before da...

...> > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > > > protection SGLs preceeding the data payload, and is using the > > > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > > > > > v3 changes: > > > > > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > > > > > > > > > v2 changes: > > > > > - Make protection buffer come before da...

...ed to 1) > > > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > protection SGLs preceeding the data payload, and is using the > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > v3 changes: > > > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > > > > > v2 changes: > > > - Make protection buffer come before data buffer (Paolo) > > > - Enable virtio_scsi_cmd_...

...ed to 1) > > > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > protection SGLs preceeding the data payload, and is using the > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > v3 changes: > > > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > > > > > v2 changes: > > > - Make protection buffer come before data buffer (Paolo) > > > - Enable virtio_scsi_cmd_...

From: Markus Elfring <elfring at users.sourceforge.net> Date: Sat, 20 May 2017 16:25:04 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (2): Improve a size determination in four functions Delete error messages for failed memory allocations in five functions drivers/vhost/scsi.c | 33 +++++++++++---------------------- 1 file

From: Markus Elfring <elfring at users.sourceforge.net> Date: Sat, 20 May 2017 16:25:04 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (2): Improve a size determination in four functions Delete error messages for failed memory allocations in five functions drivers/vhost/scsi.c | 33 +++++++++++---------------------- 1 file

.../vhost/scsi.c Nicholas Bellinger 2015-01-31 579 struct vhost_scsi_cmd *cmd; 1a1ff8256af679 drivers/vhost/scsi.c Nicholas Bellinger 2015-01-31 580 struct vhost_scsi_nexus *tv_nexus; b1935f687bb93b drivers/vhost/scsi.c Nicholas Bellinger 2014-02-22 581 struct scatterlist *sg, *prot_sg; 3aee26b4ae9104 drivers/vhost/scsi.c Nicholas Bellinger 2013-06-21 582 struct page **pages; 10e9cbb6b53111 drivers/vhost/scsi.c Matthew Wilcox 2018-06-12 583 int tag, cpu; 057cbf49a1f082 drivers/vhost/tcm_vhost.c Nicholas Bellinger 2012-07-18 584 9871831283e795 drivers/vhost/...

...6 @@ > #define VHOST_SCSI_VERSION "v0.1" > #define VHOST_SCSI_NAMELEN 256 > #define VHOST_SCSI_MAX_CDB_SIZE 32 > -#define VHOST_SCSI_DEFAULT_TAGS 256 > #define VHOST_SCSI_PREALLOC_SGLS 2048 > #define VHOST_SCSI_PREALLOC_UPAGES 2048 > #define VHOST_SCSI_PREALLOC_PROT_SGLS 2048 > @@ -189,6 +188,9 @@ struct vhost_scsi_virtqueue { > * Writers must also take dev mutex and flush under it. > */ > int inflight_idx; > + struct vhost_scsi_cmd *scsi_cmds; > + struct sbitmap scsi_tags; > + int max_cmds; > }; > > struct vhost_scsi { &...

The following patches were made over Linus's tree and fix an issue where windows guests will send iovecs with offset/lengths that result in IOs that are not aligned to 512. The LIO layer will then send them to Linux's FS/block layer but it requires 512 byte alignment, so depending on the FS/block driver being used we will get IO errors or hung IO. The following patches have vhost-scsi

...urces. (currently hardcoded to 1) > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > protection SGLs preceeding the data payload, and is using the > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > to signal to vhost/scsi how many prot_sgs to expect. > > > > v3 changes: > > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > > > v2 changes: > > - Make protection buffer come before data buffer (Paolo) > > - Enable virtio_scsi_cmd_req_pi usage (Paolo) > > &gt...

...gt; > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > > protection SGLs preceeding the data payload, and is using the > > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > > > v3 changes: > > > > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > > > > > > > v2 changes: > > > > - Make protection buffer come before data buffer (Paolo) > > &g...

...gt; > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > > protection SGLs preceeding the data payload, and is using the > > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > > > v3 changes: > > > > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > > > > > > > v2 changes: > > > > - Make protection buffer come before data buffer (Paolo) > > &g...

...&se_sess->sess_tag_pool, se_cmd->map_tag, + se_cmd->map_cpu); } static u32 vhost_scsi_sess_get_index(struct se_session *se_sess) @@ -567,7 +567,7 @@ vhost_scsi_get_tag(struct vhost_virtqueue *vq, struct vhost_scsi_tpg *tpg, struct se_session *se_sess; struct scatterlist *sg, *prot_sg; struct page **pages; - int tag; + int tag, cpu; tv_nexus = tpg->tpg_nexus; if (!tv_nexus) { @@ -576,7 +576,7 @@ vhost_scsi_get_tag(struct vhost_virtqueue *vq, struct vhost_scsi_tpg *tpg, } se_sess = tv_nexus->tvn_se_sess; - tag = percpu_ida_alloc(&se_sess->sess_tag_pool,...

The following patches were made over Linus's tree and fix an issue where windows guests will send iovecs with offset/lengths that result in IOs that are not aligned to 512. The LIO layer will then send them to Linux's block layer but it requires 512 byte alignment, so depending on the block driver being used we will get IO errors or hung IO. The following patches have vhost-scsi detect