search for: prot_sgs

Hi Mike, url: https://github.com/0day-ci/linux/commits/Mike-Christie/vhost-scsi-fixes-and-cleanups/20200922-031251 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: i386-randconfig-m021-20200923 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot

From: Markus Elfring <elfring at users.sourceforge.net> Date: Sat, 20 May 2017 13:48:44 +0200 Replace the specification of four data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring <elfring at

...gt; level protection resources. (currently hardcoded to 1) > > It changes virtscsi_add_cmd() to attach outgoing / incoming > protection SGLs preceeding the data payload, and is using the > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > to signal to vhost/scsi how many prot_sgs to expect. > > v3 changes: > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > v2 changes: > - Make protection buffer come before data buffer (Paolo) > - Enable virtio_scsi_cmd_req_pi usage (Paolo) > > Cc: Paolo Bonzini <pbonzini at redha...

...gt; level protection resources. (currently hardcoded to 1) > > It changes virtscsi_add_cmd() to attach outgoing / incoming > protection SGLs preceeding the data payload, and is using the > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > to signal to vhost/scsi how many prot_sgs to expect. > > v3 changes: > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > v2 changes: > - Make protection buffer come before data buffer (Paolo) > - Enable virtio_scsi_cmd_req_pi usage (Paolo) > > Cc: Paolo Bonzini <pbonzini at redha...

...ed to 1) > > > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > protection SGLs preceeding the data payload, and is using the > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > v3 changes: > > > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > > > > > v2 changes: > > > - Make protection buffer come before data buffer (Paolo) > > > - Enable virtio_scsi_cmd_r...

...ed to 1) > > > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > protection SGLs preceeding the data payload, and is using the > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > v3 changes: > > > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > > > > > v2 changes: > > > - Make protection buffer come before data buffer (Paolo) > > > - Enable virtio_scsi_cmd_r...

...> > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > > > protection SGLs preceeding the data payload, and is using the > > > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > > > > > v3 changes: > > > > > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > > > > > > > > > v2 changes: > > > > > - Make protection buffer come before dat...

...> > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > > > protection SGLs preceeding the data payload, and is using the > > > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > > > > > v3 changes: > > > > > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > > > > > > > > > v2 changes: > > > > > - Make protection buffer come before dat...

...ed to 1) > > > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > protection SGLs preceeding the data payload, and is using the > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > v3 changes: > > > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > > > > > v2 changes: > > > - Make protection buffer come before data buffer (Paolo) > > > - Enable virtio_scsi_cmd_r...

...ed to 1) > > > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > protection SGLs preceeding the data payload, and is using the > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > v3 changes: > > > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > > > > > v2 changes: > > > - Make protection buffer come before data buffer (Paolo) > > > - Enable virtio_scsi_cmd_r...

From: Markus Elfring <elfring at users.sourceforge.net> Date: Sat, 20 May 2017 16:25:04 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (2): Improve a size determination in four functions Delete error messages for failed memory allocations in five functions drivers/vhost/scsi.c | 33 +++++++++++---------------------- 1 file

From: Markus Elfring <elfring at users.sourceforge.net> Date: Sat, 20 May 2017 16:25:04 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (2): Improve a size determination in four functions Delete error messages for failed memory allocations in five functions drivers/vhost/scsi.c | 33 +++++++++++---------------------- 1 file

Hi Mike, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on vhost/linux-next] [also build test WARNING on v5.9-rc6 next-20200921] [cannot apply to target/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url:

On Mon, Sep 21, 2020 at 01:23:03PM -0500, Mike Christie wrote: > We currently are limited to 256 cmds per session. This leads to problems > where if the user has increased virtqueue_size to more than 2 or > cmd_per_lun to more than 256 vhost_scsi_get_tag can fail and the guest > will get IO errors. > > This patch moves the cmd allocation to per vq so we can easily match >

The following patches were made over Linus's tree and fix an issue where windows guests will send iovecs with offset/lengths that result in IOs that are not aligned to 512. The LIO layer will then send them to Linux's FS/block layer but it requires 512 byte alignment, so depending on the FS/block driver being used we will get IO errors or hung IO. The following patches have vhost-scsi

...urces. (currently hardcoded to 1) > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > protection SGLs preceeding the data payload, and is using the > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > to signal to vhost/scsi how many prot_sgs to expect. > > > > v3 changes: > > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > > > v2 changes: > > - Make protection buffer come before data buffer (Paolo) > > - Enable virtio_scsi_cmd_req_pi usage (Paolo) > > >...

...gt; > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > > protection SGLs preceeding the data payload, and is using the > > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > > > v3 changes: > > > > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > > > > > > > v2 changes: > > > > - Make protection buffer come before data buffer (Paolo) > > &gt...

...gt; > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > > protection SGLs preceeding the data payload, and is using the > > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > > > v3 changes: > > > > - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo) > > > > > > > > v2 changes: > > > > - Make protection buffer come before data buffer (Paolo) > > &gt...

From: Matthew Wilcox <mawilcox at microsoft.com> The sbitmap and the percpu_ida perform essentially the same task, allocating tags for commands. Since the sbitmap is more used than the percpu_ida, convert the percpu_ida users to the sbitmap API. Signed-off-by: Matthew Wilcox <mawilcox at microsoft.com> --- drivers/scsi/qla2xxx/qla_target.c | 16 ++++++-----

The following patches were made over Linus's tree and fix an issue where windows guests will send iovecs with offset/lengths that result in IOs that are not aligned to 512. The LIO layer will then send them to Linux's block layer but it requires 512 byte alignment, so depending on the block driver being used we will get IO errors or hung IO. The following patches have vhost-scsi detect