search for: prosek

On Wed, Mar 22, 2017 at 5:14 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > On Wed, Mar 22, 2017 at 04:10:27PM +0100, Ladi Prosek wrote: >> When init_vqs runs, virtio_balloon.stats is either uninitialized or >> contains stale values. The host updates its state with garbage data >> because it has no way of knowing that this is just a marker buffer >> used for signaling. >> >> This patch init...

On Wed, Mar 22, 2017 at 5:14 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > On Wed, Mar 22, 2017 at 04:10:27PM +0100, Ladi Prosek wrote: >> When init_vqs runs, virtio_balloon.stats is either uninitialized or >> contains stale values. The host updates its state with garbage data >> because it has no way of knowing that this is just a marker buffer >> used for signaling. >> >> This patch init...

...must be initialized. v2->v3: * Remove BUG_ON and return the actual number of counters from update_balloon_stats instead. * Added Arnd's patch to omit VM stats if CONFIG_VM_EVENT_COUNTERS is not defined. Arnd Bergmann (1): virtio_balloon: prevent uninitialized variable use Ladi Prosek (2): virtio_balloon: don't push uninitialized buffers to stats virtqueue virtio-balloon: use actual number of stats for stats queue buffers drivers/virtio/virtio_balloon.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) Thanks! Ladi

...must be initialized. v2->v3: * Remove BUG_ON and return the actual number of counters from update_balloon_stats instead. * Added Arnd's patch to omit VM stats if CONFIG_VM_EVENT_COUNTERS is not defined. Arnd Bergmann (1): virtio_balloon: prevent uninitialized variable use Ladi Prosek (2): virtio_balloon: don't push uninitialized buffers to stats virtqueue virtio-balloon: use actual number of stats for stats queue buffers drivers/virtio/virtio_balloon.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) Thanks! Ladi

...to be ignored by the host. The alternative fix would be to push an empty buffer in init_vqs but that's not easily done with the current virtio implementation and would still not eliminate the invariant that update_balloon_stats has to update all VIRTIO_BALLOON_S_NR fields. Signed-off-by: Ladi Prosek <lprosek at redhat.com> --- drivers/virtio/virtio_balloon.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 4e11915..d34f56f 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -...

...to be ignored by the host. The alternative fix would be to push an empty buffer in init_vqs but that's not easily done with the current virtio implementation and would still not eliminate the invariant that update_balloon_stats has to update all VIRTIO_BALLOON_S_NR fields. Signed-off-by: Ladi Prosek <lprosek at redhat.com> --- drivers/virtio/virtio_balloon.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 4e11915..d34f56f 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -...

On Wed, Mar 22, 2017 at 06:05:39PM +0100, Ladi Prosek wrote: > On Wed, Mar 22, 2017 at 5:14 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > > On Wed, Mar 22, 2017 at 04:10:27PM +0100, Ladi Prosek wrote: > >> When init_vqs runs, virtio_balloon.stats is either uninitialized or > >> contains stale values. The host upd...

...virtio implementation and violates the spec "Driver MUST supply the same subset of statistics in all buffers submitted to the statsq". * Push a buffer with invalid tags in init_vqs. Violates the same spec clause, plus "invalid tag" is not really defined. Signed-off-by: Ladi Prosek <lprosek at redhat.com> --- v1->v2: * Call update_balloon_stats instead of filling the buffer with invalid tags. * Add BUG_ON to update_balloon_stats to formalize the invariant that all slots in the buffer must be initialized. Also, I just noticed this paragraph in the spec: &quot...

...virtio implementation and violates the spec "Driver MUST supply the same subset of statistics in all buffers submitted to the statsq". * Push a buffer with invalid tags in init_vqs. Violates the same spec clause, plus "invalid tag" is not really defined. Signed-off-by: Ladi Prosek <lprosek at redhat.com> --- v1->v2: * Call update_balloon_stats instead of filling the buffer with invalid tags. * Add BUG_ON to update_balloon_stats to formalize the invariant that all slots in the buffer must be initialized. Also, I just noticed this paragraph in the spec: &quot...

On Mon, Mar 27, 2017 at 12:02:33PM +0200, Ladi Prosek wrote: > On Fri, Mar 24, 2017 at 9:59 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > > On Fri, Mar 24, 2017 at 09:40:07PM +0100, Arnd Bergmann wrote: > >> On Fri, Mar 24, 2017 at 9:11 PM, Ladi Prosek <lprosek at redhat.com> wrote: > >> > On Fri, Mar 24...

On Mon, Mar 27, 2017 at 12:02:33PM +0200, Ladi Prosek wrote: > On Fri, Mar 24, 2017 at 9:59 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > > On Fri, Mar 24, 2017 at 09:40:07PM +0100, Arnd Bergmann wrote: > >> On Fri, Mar 24, 2017 at 9:11 PM, Ladi Prosek <lprosek at redhat.com> wrote: > >> > On Fri, Mar 24...

On Wed, Mar 22, 2017 at 04:10:27PM +0100, Ladi Prosek wrote: > When init_vqs runs, virtio_balloon.stats is either uninitialized or > contains stale values. The host updates its state with garbage data > because it has no way of knowing that this is just a marker buffer > used for signaling. > > This patch initializes all tags with U...

On Fri, Mar 24, 2017 at 09:40:07PM +0100, Arnd Bergmann wrote: > On Fri, Mar 24, 2017 at 9:11 PM, Ladi Prosek <lprosek at redhat.com> wrote: > > On Fri, Mar 24, 2017 at 7:38 PM, David Hildenbrand <david at redhat.com> wrote: > >> On 23.03.2017 16:17, Arnd Bergmann wrote: > >>> The latest gcc-7.0.1 snapshot reports a new warning: > >>> > >>> vir...

On Fri, Mar 24, 2017 at 09:40:07PM +0100, Arnd Bergmann wrote: > On Fri, Mar 24, 2017 at 9:11 PM, Ladi Prosek <lprosek at redhat.com> wrote: > > On Fri, Mar 24, 2017 at 7:38 PM, David Hildenbrand <david at redhat.com> wrote: > >> On 23.03.2017 16:17, Arnd Bergmann wrote: > >>> The latest gcc-7.0.1 snapshot reports a new warning: > >>> > >>> vir...

On Fri, Mar 24, 2017 at 7:38 PM, David Hildenbrand <david at redhat.com> wrote: > On 23.03.2017 16:17, Arnd Bergmann wrote: >> The latest gcc-7.0.1 snapshot reports a new warning: >> >> virtio/virtio_balloon.c: In function 'update_balloon_stats': >> virtio/virtio_balloon.c:258:26: error: 'events[2]' is used uninitialized in this function

On Fri, Mar 24, 2017 at 7:38 PM, David Hildenbrand <david at redhat.com> wrote: > On 23.03.2017 16:17, Arnd Bergmann wrote: >> The latest gcc-7.0.1 snapshot reports a new warning: >> >> virtio/virtio_balloon.c: In function 'update_balloon_stats': >> virtio/virtio_balloon.c:258:26: error: 'events[2]' is used uninitialized in this function

...minor fixes This fixes two minor bugs: error handling in vhost, and capability processing in virtio. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> ---------------------------------------------------------------- Greg Kurz (1): vhost: fix error path in vhost_init_used() Ladi Prosek (1): virtio-pci: read the right virtio_pci_notify_cap field drivers/vhost/vhost.c | 15 +++++++++++---- drivers/virtio/virtio_pci_modern.c | 2 +- 2 files changed, 12 insertions(+), 5 deletions(-)

...nothing major in this cycle. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> ---------------------------------------------------------------- Juergen Gross (1): virtio: remove config.c Konstantin Neumoin (1): virtio: update balloon size in balloon "probe" Ladi Prosek (1): virtio_ring: Make interrupt suppression spec compliant Markus Elfring (2): virtio_blk: Use kmalloc_array() in init_vq() virtio_blk: Delete an unnecessary initialisation in init_vq() Matt Redfearn (1): virtio: console: Unlock vqs while freeing buffers Michael S. Tsirk...

..., working on it. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> ---------------------------------------------------------------- Arnd Bergmann (1): virtio_balloon: prevent uninitialized variable use Jason Wang (1): virtio_pci: fix out of bound access for msix_names Ladi Prosek (2): virtio_balloon: init 1st buffer in stats vq virtio-balloon: use actual number of stats for stats queue buffers drivers/virtio/virtio_balloon.c | 19 +++++++++++++------ drivers/virtio/virtio_pci_common.c | 9 +++++---- 2 files changed, 18 insertions(+), 10 deletions(-)

...nto the statistics. >From all I can tell, this has been broken since the statistics code was originally added in 2.6.34. Fixes: 9564e138b1f6 ("virtio: Add memory statistics reporting to the balloon driver (V4)") Signed-off-by: Arnd Bergmann <arnd at arndb.de> Signed-off-by: Ladi Prosek <lprosek at redhat.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> [arnd: backported to 4.4] Signed-off-by: Arnd Bergmann <arnd at arndb.de> --- drivers/virtio/virtio_balloon.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/virtio/virtio_balloon.c b/dri...