search for: printbeforeal

...ol PrintBeforePass(Pass *P) { Please just mark stand-alone functions "static" don't put them in anonymous namespaces. Typo in the comment. Please rename this to "ShouldPrintBeforePass", "PrintBeforePass" implies that it does printing. + bool PrintBeforeThis = PrintBeforeAll; + if (!PrintBeforeThis) don't nest the entire function, use an early return like this: if (PrintBeforeAll) return true; + for (unsigned i = 0; i < PrintBefore.size(); ++i) { Don't evaluate PrintBefore.size() every time through the loop. + if (PassInf && P->...

On Friday 12 March 2010 08:13:05 Kalle Raiskila wrote: > David Greene wrote: > > Here's a rework using PassManager as Chris suggested. Comments? > > Tried this second patch with the svn version 97812 (the one the patch is > made against), but it doesn't compile: > "llvm/include/llvm/Pass.h:127: Error: expected unqualified-id before "&" >

I came across a PDB that caused llvm-pdbdump to crash. I tracked it down to a missing overload for a data type in the variable printer. When I tried to provide an implementation, I discovered that there were some bugs in the existing overloads and it was easy to come up with combinations of types that weren't being dumped right. I created some test cases and tried to fix these problems but

David Greene wrote: > Here's a rework using PassManager as Chris suggested. Comments? Tried this second patch with the svn version 97812 (the one the patch is made against), but it doesn't compile: "llvm/include/llvm/Pass.h:127: Error: expected unqualified-id before "&" token" Seems raw_ostream is forward declared but not defined (adding a missing #include

...c" don't put them in anonymous > namespaces. Ok. Out of curiosity, why the preference for static? > Typo in the comment. Please rename this to > "ShouldPrintBeforePass", "PrintBeforePass" implies that it does printing. Ok. > + bool PrintBeforeThis = PrintBeforeAll; > + if (!PrintBeforeThis) > > don't nest the entire function, use an early return like this: Ok. > + for (unsigned i = 0; i < PrintBefore.size(); ++i) { > Don't evaluate PrintBefore.size() every time through the loop. Ok, but that's a bit nitpicky... :) >...

On Tue, Dec 10, 2013 at 11:58 AM, Hans Wennborg <hans at chromium.org> wrote: > It would be nice if we could make the TypePrinter not print the > calling convention if it's the default one for the ABI, but > TypePrinter doesn't have a lot of context.. no Sema, no ASTContext :/ > Does this patch fix any failures for you? It doesn't fix that test case, unfortunately.

...ecified passes. +PassOptionList +PrintBefore("print-before", + llvm::cl::desc("Print IR before specified passes")); + +PassOptionList +PrintAfter("print-after", + llvm::cl::desc("Print IR after specified passes")); + +cl::opt<bool> +PrintBeforeAll("print-before-all", + llvm::cl::desc("Print IR before each pass"), + cl::init(false)); +cl::opt<bool> +PrintAfterAll("print-after-all", + llvm::cl::desc("Print IR after each pass"), + cl::init(false...

On Mon, Dec 9, 2013 at 5:18 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote: > Mingw switched abis with the release of gcc 4.7 > (http://gcc.gnu.org/gcc-4.7/changes.html). The main change is that now > mingw (like msvc) given thiscall calling convention to methods by > default. > > I think the last bug blocking us to support the new abi has just been > fixed.

On Monday 15 March 2010 13:45:14 David Greene wrote: > On Sunday 14 March 2010 18:32:35 Chris Lattner wrote: > > This is much better than the first iteration but still has many issues. I believe I've addressed all your points with this patch except I didn't use StringRef. It doesn't appear to be useful since createPrinterPass will be sent a const std::string & and will

...fore("print-before", > + llvm::cl::desc("Print IR before specified passes")); > + > +PassOptionList > +PrintAfter("print-after", > + llvm::cl::desc("Print IR after specified passes")); > + > +cl::opt<bool> > +PrintBeforeAll("print-before-all", > + llvm::cl::desc("Print IR before each pass"), > + cl::init(false)); > +cl::opt<bool> > +PrintAfterAll("print-after-all", > + llvm::cl::desc("Print IR after each pass"), >...

Mingw switched abis with the release of gcc 4.7 (http://gcc.gnu.org/gcc-4.7/changes.html). The main change is that now mingw (like msvc) given thiscall calling convention to methods by default. I think the last bug blocking us to support the new abi has just been fixed. The question now is how to switch. The attached patches simply switch llvm and clang to the new ABI. This is similar to what

...3GlobalContext", "GlobalContext"}, {"_ZN4llvmL13PassDebuggingE", "llvm::PassDebugging"}, {"_ZN4llvmL11PrintBeforeE", "llvm::PrintBefore"}, {"_ZN4llvmL10PrintAfterE", "llvm::PrintAfter"}, {"_ZN4llvmL14PrintBeforeAllE", "llvm::PrintBeforeAll"}, {"_ZN4llvmL13PrintAfterAllE", "llvm::PrintAfterAll"}, {"_ZN12_GLOBAL__N_1L15TimingInfoMutexE", "(anonymous namespace)::TimingInfoMutex"}, {"_ZL12EnableTiming", "EnableTiming"},...