search for: printbeforeall

...ol PrintBeforePass(Pass *P) { Please just mark stand-alone functions "static" don't put them in anonymous namespaces. Typo in the comment. Please rename this to "ShouldPrintBeforePass", "PrintBeforePass" implies that it does printing. + bool PrintBeforeThis = PrintBeforeAll; + if (!PrintBeforeThis) don't nest the entire function, use an early return like this: if (PrintBeforeAll) return true; + for (unsigned i = 0; i < PrintBefore.size(); ++i) { Don't evaluate PrintBefore.size() every time through the loop. + if (PassInf && P->g...

On Friday 12 March 2010 08:13:05 Kalle Raiskila wrote: > David Greene wrote: > > Here's a rework using PassManager as Chris suggested. Comments? > > Tried this second patch with the svn version 97812 (the one the patch is > made against), but it doesn't compile: > "llvm/include/llvm/Pass.h:127: Error: expected unqualified-id before "&" >

...ecified passes. +PassOptionList +PrintBefore("print-before", + llvm::cl::desc("Print IR before specified passes")); + +PassOptionList +PrintAfter("print-after", + llvm::cl::desc("Print IR after specified passes")); + +cl::opt<bool> +PrintBeforeAll("print-before-all", + llvm::cl::desc("Print IR before each pass"), + cl::init(false)); +cl::opt<bool> +PrintAfterAll("print-after-all", + llvm::cl::desc("Print IR after each pass"), + cl::init(false)...

David Greene wrote: > Here's a rework using PassManager as Chris suggested. Comments? Tried this second patch with the svn version 97812 (the one the patch is made against), but it doesn't compile: "llvm/include/llvm/Pass.h:127: Error: expected unqualified-id before "&" token" Seems raw_ostream is forward declared but not defined (adding a missing #include

On Monday 15 March 2010 13:45:14 David Greene wrote: > On Sunday 14 March 2010 18:32:35 Chris Lattner wrote: > > This is much better than the first iteration but still has many issues. I believe I've addressed all your points with this patch except I didn't use StringRef. It doesn't appear to be useful since createPrinterPass will be sent a const std::string & and will

...fore("print-before", > + llvm::cl::desc("Print IR before specified passes")); > + > +PassOptionList > +PrintAfter("print-after", > + llvm::cl::desc("Print IR after specified passes")); > + > +cl::opt<bool> > +PrintBeforeAll("print-before-all", > + llvm::cl::desc("Print IR before each pass"), > + cl::init(false)); > +cl::opt<bool> > +PrintAfterAll("print-after-all", > + llvm::cl::desc("Print IR after each pass"), >...

...c" don't put them in anonymous > namespaces. Ok. Out of curiosity, why the preference for static? > Typo in the comment. Please rename this to > "ShouldPrintBeforePass", "PrintBeforePass" implies that it does printing. Ok. > + bool PrintBeforeThis = PrintBeforeAll; > + if (!PrintBeforeThis) > > don't nest the entire function, use an early return like this: Ok. > + for (unsigned i = 0; i < PrintBefore.size(); ++i) { > Don't evaluate PrintBefore.size() every time through the loop. Ok, but that's a bit nitpicky... :) >...

...3GlobalContext", "GlobalContext"}, {"_ZN4llvmL13PassDebuggingE", "llvm::PassDebugging"}, {"_ZN4llvmL11PrintBeforeE", "llvm::PrintBefore"}, {"_ZN4llvmL10PrintAfterE", "llvm::PrintAfter"}, {"_ZN4llvmL14PrintBeforeAllE", "llvm::PrintBeforeAll"}, {"_ZN4llvmL13PrintAfterAllE", "llvm::PrintAfterAll"}, {"_ZN12_GLOBAL__N_1L15TimingInfoMutexE", "(anonymous namespace)::TimingInfoMutex"}, {"_ZL12EnableTiming", "EnableTiming"},...