search for: partialsuccesserror

In addition, removed unnecessary 'rescue' clauses and fixed a bug in a prior fix for this problem for the Permission and Network controllers. Signed-off-by: Scott Seago <sseago at redhat.com> --- src/app/controllers/application.rb | 2 +- src/app/controllers/network_controller.rb | 2 +- src/app/controllers/permission_controller.rb | 6 ++----

...sful_vms = [] + failed_vms = {} + vm_ids.each do |vm_id| + begin + successful_vms << svc_vm_action(vm_id, vm_action, action_args) + rescue Exception => ex + failed_vms[@vm.description] = ex.message + end + end + unless failed_vms.empty? + raise PartialSuccessError.new("Your request to #{vm_action} encountered the following errors: ", + failed_vms, successful_vms) end - return "#{vm_action} was successfully queued." + return "Request to #{vm_action} submitted." end # Cancels...

This resend includes the rebase, but fixes a problem I just noticed with nil/empty checks.

This is a resend of the 2-patch series from a week or so ago, needed to be rebased due to some commits on next

The following two patches should be applied in the order: * [PATCH server] Add svc_vm_actions method to VmService. * [PATCH server] Cloud UI layer to initiate actions on vms. The service layer patch should work fine on its own (and not break anything), but cloud patch relies on service being there.

Forwarding to the list for Jay or Scott to have a look. Ignazio, do you see any more details (traceback or something) in the rails log? -------------- next part -------------- An embedded message was scrubbed... From: ignazio.cassano at provincia.torino.it Subject: Re: [Ovirt-devel] [PATCH node-image] keep NIC and HBA firmwares Date: Wed, 16 Sep 2009 16:48:47 +0200 Size: 4031 URL:

...pdate_actions(@pool, pool_hash) diff --git a/src/app/services/smart_pool_service.rb b/src/app/services/smart_pool_service.rb index 67adfe0..28bdaf3 100644 --- a/src/app/services/smart_pool_service.rb +++ b/src/app/services/smart_pool_service.rb @@ -96,7 +96,8 @@ module SmartPoolService raise PartialSuccessError.new("#{item_action.to_s} #{item_class.table_name.humanize if item_class} only partially successful", failed_resources, successful_resources) end - return "#{item_action.to_s} #{item_class.table_name.humanize} successful." + return...

...:success => false, - :alert => "Failed deleting " + - failed_networks.size.to_s + - " networks due to existing bondings/nics" } - end - end + unless failures.empty? + raise PartialSuccessError.new("Delete failed for some networks", + failures, successes) + end + render :json => { :object => "network", :success => true, + :alert => "Networks were successfully deleted." } + end - de...

...lp_section - - # General error handlers, must be in order from least specific - # to most specific - rescue_from Exception, :with => :handle_general_error - rescue_from PermissionError, :with => :handle_perm_error - rescue_from ActionError, :with => :handle_action_error - rescue_from PartialSuccessError, :with => :handle_partial_success_error - - def choose_layout - if(params[:component_layout]) - return (ENV["RAILS_ENV"] != "production")?'components/' << params[:component_layout]:'redux' - end - return 'redux' - end - - def is_...

Note that one of the 8 patches (#6) will be sent separately in reply to this email, as some of the replaced lines are too long, so git won't let me send the email. However, there is nothing wrong with that patch, and it should be applied in the sequence listed below. Note also that I assume this will be tested on a clean f11 install, rather than an upgrade of an existing ovirt server