search for: out_nd

...amp;ndr_desc.flags); > + set_bit(ND_REGION_ASYNC, &ndr_desc.flags); > + nd_region = nvdimm_pmem_region_create(vpmem->nvdimm_bus, &ndr_desc); > + if (!nd_region) { > + dev_err(&vdev->dev, "failed to create nvdimm region\n"); > + err = -ENXIO; > + goto out_nd; > + } > + nd_region->provider_data = dev_to_virtio(nd_region->dev.parent->parent); > + return 0; > +out_nd: > + nvdimm_bus_unregister(vpmem->nvdimm_bus); > +out_vq: > + vdev->config->del_vqs(vdev); > +out_err: > + return err; > +} > + > +static...

...amp;ndr_desc.flags); > + set_bit(ND_REGION_ASYNC, &ndr_desc.flags); > + nd_region = nvdimm_pmem_region_create(vpmem->nvdimm_bus, &ndr_desc); > + if (!nd_region) { > + dev_err(&vdev->dev, "failed to create nvdimm region\n"); > + err = -ENXIO; > + goto out_nd; > + } > + nd_region->provider_data = dev_to_virtio(nd_region->dev.parent->parent); > + return 0; > +out_nd: > + nvdimm_bus_unregister(vpmem->nvdimm_bus); > +out_vq: > + vdev->config->del_vqs(vdev); > +out_err: > + return err; > +} > + > +static...

...virtio > + (nd_region->dev.parent->parent); Isn't it clear that this parent chain will always end up at &vdev->dev? Maybe simply set ->provider_data to vdev directly? (Does it need to grab a reference count of the device, BTW?) > + > + if (!nd_region) > + goto out_nd; Probably better to do this check before you access nd_region's members :) > + > + return 0; > +out_nd: > + err = -ENXIO; > + nvdimm_bus_unregister(nvdimm_bus); > +out_vq: > + vdev->config->del_vqs(vdev); > +out_err: > + dev_err(&vdev->dev, "failed...

...virtio > + (nd_region->dev.parent->parent); Isn't it clear that this parent chain will always end up at &vdev->dev? Maybe simply set ->provider_data to vdev directly? (Does it need to grab a reference count of the device, BTW?) > + > + if (!nd_region) > + goto out_nd; Probably better to do this check before you access nd_region's members :) > + > + return 0; > +out_nd: > + err = -ENXIO; > + nvdimm_bus_unregister(nvdimm_bus); > +out_vq: > + vdev->config->del_vqs(vdev); > +out_err: > + dev_err(&vdev->dev, "failed...

...;> + set_bit(ND_REGION_ASYNC, &ndr_desc.flags); >> + nd_region = nvdimm_pmem_region_create(vpmem->nvdimm_bus, &ndr_desc); >> + if (!nd_region) { >> + dev_err(&vdev->dev, "failed to create nvdimm region\n"); >> + err = -ENXIO; >> + goto out_nd; >> + } >> + nd_region->provider_data = dev_to_virtio(nd_region->dev.parent->parent); >> + return 0; >> +out_nd: >> + nvdimm_bus_unregister(vpmem->nvdimm_bus); >> +out_vq: >> + vdev->config->del_vqs(vdev); >> +out_err: >> + ret...

...+ set_bit(ND_REGION_ASYNC, &ndr_desc.flags); > > + nd_region = nvdimm_pmem_region_create(vpmem->nvdimm_bus, &ndr_desc); > > + if (!nd_region) { > > + dev_err(&vdev->dev, "failed to create nvdimm region\n"); > > + err = -ENXIO; > > + goto out_nd; > > + } > > + nd_region->provider_data = dev_to_virtio(nd_region->dev.parent->parent); > > + return 0; > > +out_nd: > > + nvdimm_bus_unregister(vpmem->nvdimm_bus); > > +out_vq: > > + vdev->config->del_vqs(vdev); > > +out_err: > &...

...n't it clear that this parent chain will always end up at &vdev->dev? > > Maybe simply set ->provider_data to vdev directly? (Does it need to > > grab a reference count of the device, BTW?) > > > > > + > > > + if (!nd_region) > > > + goto out_nd; > > > > Probably better to do this check before you access nd_region's > > members :) > > > > > + > > > + return 0; > > > +out_nd: > > > + err = -ENXIO; > > > + nvdimm_bus_unregister(nvdimm_bus); > > > +out_vq: &gt...

...ent->parent); > > Isn't it clear that this parent chain will always end up at &vdev->dev? > Maybe simply set ->provider_data to vdev directly? (Does it need to > grab a reference count of the device, BTW?) > > > + > > + if (!nd_region) > > + goto out_nd; > > Probably better to do this check before you access nd_region's > members :) > > > + > > + return 0; > > +out_nd: > > + err = -ENXIO; > > + nvdimm_bus_unregister(nvdimm_bus); > > +out_vq: > > + vdev->config->del_vqs(vdev); > &...

....flush = async_pmem_flush; > + set_bit(ND_REGION_PAGEMAP, &ndr_desc.flags); > + set_bit(ND_REGION_ASYNC, &ndr_desc.flags); > + nd_region = nvdimm_pmem_region_create(vpmem->nvdimm_bus, &ndr_desc); > + > + if (!nd_region) > + goto out_nd; > + nd_region->provider_data = dev_to_virtio > + (nd_region->dev.parent->parent); > + return 0; > +out_nd: > + err = -ENXIO; > + nvdimm_bus_unregister(vpmem->nvdimm_bus); > +out_vq: > + vdev-&g...

....flush = async_pmem_flush; > + set_bit(ND_REGION_PAGEMAP, &ndr_desc.flags); > + set_bit(ND_REGION_ASYNC, &ndr_desc.flags); > + nd_region = nvdimm_pmem_region_create(vpmem->nvdimm_bus, &ndr_desc); > + > + if (!nd_region) > + goto out_nd; > + nd_region->provider_data = dev_to_virtio > + (nd_region->dev.parent->parent); > + return 0; > +out_nd: > + err = -ENXIO; > + nvdimm_bus_unregister(vpmem->nvdimm_bus); > +out_vq: > + vdev-&g...

..., &ndr_desc.flags); > > > + set_bit(ND_REGION_ASYNC, &ndr_desc.flags); > > > + nd_region = nvdimm_pmem_region_create(vpmem->nvdimm_bus, > > > &ndr_desc); > > > + > > > + if (!nd_region) > > > + goto out_nd; > > > + nd_region->provider_data = dev_to_virtio > > > + (nd_region->dev.parent->parent); > > > + return 0; > > > +out_nd: > > > + err = -ENXIO; > > > + nvdimm_bus_unregist...

...EMAP, &ndr_desc.flags); > + set_bit(ND_REGION_ASYNC, &ndr_desc.flags); > + nd_region = nvdimm_pmem_region_create(nvdimm_bus, &ndr_desc); > + nd_region->provider_data = dev_to_virtio > + (nd_region->dev.parent->parent); > + > + if (!nd_region) > + goto out_nd; > + > + //virtio_device_ready(vdev); Left over > + return 0; > +out_nd: > + err = -ENXIO; > + nvdimm_bus_unregister(nvdimm_bus); > +out_vq: > + vdev->config->del_vqs(vdev); > +out_err: > + dev_err(&vdev->dev, "failed to register virtio pmem memory\...

...EMAP, &ndr_desc.flags); > + set_bit(ND_REGION_ASYNC, &ndr_desc.flags); > + nd_region = nvdimm_pmem_region_create(nvdimm_bus, &ndr_desc); > + nd_region->provider_data = dev_to_virtio > + (nd_region->dev.parent->parent); > + > + if (!nd_region) > + goto out_nd; > + > + //virtio_device_ready(vdev); Left over > + return 0; > +out_nd: > + err = -ENXIO; > + nvdimm_bus_unregister(nvdimm_bus); > +out_vq: > + vdev->config->del_vqs(vdev); > +out_err: > + dev_err(&vdev->dev, "failed to register virtio pmem memory\...

...desc.numa_node = nid; > + ndr_desc.flush = async_pmem_flush; > + set_bit(ND_REGION_PAGEMAP, &ndr_desc.flags); > + set_bit(ND_REGION_ASYNC, &ndr_desc.flags); > + nd_region = nvdimm_pmem_region_create(vpmem->nvdimm_bus, &ndr_desc); > + > + if (!nd_region) > + goto out_nd; > + nd_region->provider_data = dev_to_virtio Delete extra space here ----------^^ I think this will let you join the two lines. > + (nd_region->dev.parent->parent); > + return 0; > +out_nd: > + err = -ENXIO; > + nvdimm_bus_unregister(vpmem->nvdimm_bus); > +o...

...desc.numa_node = nid; > + ndr_desc.flush = async_pmem_flush; > + set_bit(ND_REGION_PAGEMAP, &ndr_desc.flags); > + set_bit(ND_REGION_ASYNC, &ndr_desc.flags); > + nd_region = nvdimm_pmem_region_create(vpmem->nvdimm_bus, &ndr_desc); > + > + if (!nd_region) > + goto out_nd; > + nd_region->provider_data = dev_to_virtio(nd_region->dev.parent->parent); > + return 0; > +out_nd: > + err = -ENXIO; > + nvdimm_bus_unregister(vpmem->nvdimm_bus); > +out_vq: > + vdev->config->del_vqs(vdev); > +out_err: > + dev_err(&vdev->dev,...

...EMAP, &ndr_desc.flags); > + set_bit(ND_REGION_ASYNC, &ndr_desc.flags); > + nd_region = nvdimm_pmem_region_create(nvdimm_bus, &ndr_desc); > + nd_region->provider_data = dev_to_virtio > + (nd_region->dev.parent->parent); > + > + if (!nd_region) > + goto out_nd; > + > + return 0; > +out_nd: > + err = -ENXIO; > + nvdimm_bus_unregister(nvdimm_bus); > +out_vq: > + vdev->config->del_vqs(vdev); > +out_err: > + dev_err(&vdev->dev, "failed to register virtio pmem memory\n"); > + return err; > +} > + >...

..._desc.flush = async_pmem_flush; > + set_bit(ND_REGION_PAGEMAP, &ndr_desc.flags); > + set_bit(ND_REGION_ASYNC, &ndr_desc.flags); > + nd_region = nvdimm_pmem_region_create(vpmem->nvdimm_bus, &ndr_desc); > + I'd drop this empty line. > + if (!nd_region) > + goto out_nd; > + nd_region->provider_data = dev_to_virtio(nd_region->dev.parent->parent); Does it make sense to move some parts into separate functions for readability? E.g., virtio_pmem_init_nvdimm_bus() > + return 0; > +out_nd: > + err = -ENXIO; I'd always initialize "err&quo...

..._desc.flush = async_pmem_flush; > + set_bit(ND_REGION_PAGEMAP, &ndr_desc.flags); > + set_bit(ND_REGION_ASYNC, &ndr_desc.flags); > + nd_region = nvdimm_pmem_region_create(vpmem->nvdimm_bus, &ndr_desc); > + I'd drop this empty line. > + if (!nd_region) > + goto out_nd; > + nd_region->provider_data = dev_to_virtio(nd_region->dev.parent->parent); Does it make sense to move some parts into separate functions for readability? E.g., virtio_pmem_init_nvdimm_bus() > + return 0; > +out_nd: > + err = -ENXIO; I'd always initialize "err&quo...

...&ndr_desc.flags); > > > + nd_region = nvdimm_pmem_region_create(nvdimm_bus, &ndr_desc); > > > + nd_region->provider_data = dev_to_virtio > > > + (nd_region->dev.parent->parent); > > > + > > > + if (!nd_region) > > > + goto out_nd; > > > + > > > + //virtio_device_ready(vdev); > > > > Left over > > o.k > > > > > > + return 0; > > > +out_nd: > > > + err = -ENXIO; > > > + nvdimm_bus_unregister(nvdimm_bus); > > > +out_vq: > > >...

...&ndr_desc.flags); > > > + nd_region = nvdimm_pmem_region_create(nvdimm_bus, &ndr_desc); > > > + nd_region->provider_data = dev_to_virtio > > > + (nd_region->dev.parent->parent); > > > + > > > + if (!nd_region) > > > + goto out_nd; > > > + > > > + //virtio_device_ready(vdev); > > > > Left over > > o.k > > > > > > + return 0; > > > +out_nd: > > > + err = -ENXIO; > > > + nvdimm_bus_unregister(nvdimm_bus); > > > +out_vq: > > >...