search for: orderfile

Borrow an idea from nbdkit (in turn borrowed from qemu) on making patches easier to review by sorting diffs based on filename. --- We can tweak this order if desired, but the order presented here made enough sense to me. Makefile.am | 1 + scripts/git.orderfile | 58 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 59 insertions(+) create mode 100644 scripts/git.orderfile diff --git a/Makefile.am b/Makefile.am index b6cb8fe..588d505 100644 --- a/Makefile.am +++ b/Makefile.am @@ -23,6 +23,7 @@ EXTRA_DIST = \ .dir-locals.el \ .gitignore \...

...s changed, 1148 insertions(+), 10 deletions(-) > > How the heck did you generate that diffstat? The names should be > ordered, and are for me. > > Anyway, pulled. Just curious about how that thing happened. > > Linus That's because apparently diffstat obeys orderfile rules: [diff] renames = true orderfile = "/home/mst/.gitorderfile" $ cat .gitorderfile configure Makefile* *.json *.h *.c

...s changed, 1148 insertions(+), 10 deletions(-) > > How the heck did you generate that diffstat? The names should be > ordered, and are for me. > > Anyway, pulled. Just curious about how that thing happened. > > Linus That's because apparently diffstat obeys orderfile rules: [diff] renames = true orderfile = "/home/mst/.gitorderfile" $ cat .gitorderfile configure Makefile* *.json *.h *.c

On Wed, Jan 27, 2016 at 2:15 PM, Michael S. Tsirkin <mst at redhat.com> wrote: >> >> Anyway, pulled. Just curious about how that thing happened. > > That's because apparently diffstat obeys orderfile rules: Ugh. I guess that makes sense, but it's still very annoying for something like a pull request, where now different people end up having different diffstats. And the reason I never noticed it is that likely there aren't that many people who use an orderfile. I guess something like &...

...ory leak > (bitmap was not being freed). > --- > Makefile.am | 1 + > common/bitmap/Makefile.am | 44 ++++++++++++ > common/bitmap/bitmap.c | 74 ++++++++++++++++++++ > common/bitmap/bitmap.h | 141 ++++++++++++++++++++++++++++++++++++++ With git's orderfile directive, you can arrange to have all Makefile.am appear before all .h before all .c, to make patches a little easier to follow logically (what gets built, what interfaces does it need, and how is it implemented). 'git config diff.orderFile /path/to/file'; see qemu's scripts/git.o...

...dering isnt' really > alphabetical, since the '/' sorts as the NUL character, but close > enough). > > I can't see the logic to the re-ordering of the lines, so I'm > intrigued how you even generated it. > > Linus Oh, that's because I set orderfile globally rather than just for the qemu project which wants it. Fixed, sorry about that. -- MST

...dering isnt' really > alphabetical, since the '/' sorts as the NUL character, but close > enough). > > I can't see the logic to the re-ordering of the lines, so I'm > intrigued how you even generated it. > > Linus Oh, that's because I set orderfile globally rather than just for the qemu project which wants it. Fixed, sorry about that. -- MST

The following changes since commit 92e963f50fc74041b5e9e744c330dca48e04f08d: Linux 4.5-rc1 (2016-01-24 13:06:47 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to 481eaec37e91e2b33f17275901172f50ce2c71e8: tools/virtio: add ringtest utilities (2016-01-26 10:18:30 +0200)

The following changes since commit 92e963f50fc74041b5e9e744c330dca48e04f08d: Linux 4.5-rc1 (2016-01-24 13:06:47 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to 481eaec37e91e2b33f17275901172f50ce2c71e8: tools/virtio: add ringtest utilities (2016-01-26 10:18:30 +0200)

...evice/nbd/blob/master/doc/uri.md>. =head2 Other +L<libnbd-security(1), L<qemu(1)>. =head1 AUTHORS diff --git a/Makefile.am b/Makefile.am index 59918b9..019936f 100644 --- a/Makefile.am +++ b/Makefile.am @@ -24,6 +24,7 @@ EXTRA_DIST = \ .gitignore \ html/pod.css \ scripts/git.orderfile \ + SECURITY \ $(NULL) SUBDIRS = \ diff --git a/.gitignore b/.gitignore index 9254d1a..ae3e04f 100644 --- a/.gitignore +++ b/.gitignore @@ -37,10 +37,11 @@ Makefile.in /config.sub /configure /depcomp -/docs/*.3 +/docs/*.[13] /docs/*.pod /docs/Makefile.inc !/docs/libnbd.pod +!/docs/libnbd-...

...view pass over the patches! Manman -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190117/f4b4c2b9/attachment-0001.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: orderfile-llvm.patch Type: application/octet-stream Size: 16418 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190117/f4b4c2b9/attachment-0003.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: orderfile-rt.patch Type: applic...

The following changes since commit a57cb1c1d7974c62a5c80f7869e35b492ace12cd: Merge branch 'akpm' (patches from Andrew) (2016-12-14 17:25:18 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to 6bdf1e0efb04a1716373646cb6f35b73addca492: Makefile: drop -D__CHECK_ENDIAN__ from cflags

The following changes since commit a57cb1c1d7974c62a5c80f7869e35b492ace12cd: Merge branch 'akpm' (patches from Andrew) (2016-12-14 17:25:18 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to 6bdf1e0efb04a1716373646cb6f35b73addca492: Makefile: drop -D__CHECK_ENDIAN__ from cflags

...evice/nbd/blob/master/doc/uri.md>. =head2 Other +L<libnbd-security(1), L<qemu(1)>. =head1 AUTHORS diff --git a/Makefile.am b/Makefile.am index 59918b9..019936f 100644 --- a/Makefile.am +++ b/Makefile.am @@ -24,6 +24,7 @@ EXTRA_DIST = \ .gitignore \ html/pod.css \ scripts/git.orderfile \ + SECURITY \ $(NULL) SUBDIRS = \ diff --git a/.gitignore b/.gitignore index 9254d1a..ae3e04f 100644 --- a/.gitignore +++ b/.gitignore @@ -37,10 +37,11 @@ Makefile.in /config.sub /configure /depcomp -/docs/*.3 +/docs/*.[13] /docs/*.pod /docs/Makefile.inc !/docs/libnbd.pod +!/docs/libnbd-...

This is exactly the same as v1: https://www.redhat.com/archives/libguestfs/2018-December/msg00004.html except that it now frees the bitmap on unload (which the old code did not - there was always a memory leak). Rich.

Regarding the orderfile, yes, I was thinking more about ordering the real functions. In that case it sounds like your best option may be to implement the optimization pass to make direct calls go directly to the real function. >From a performance perspective I don't think it would make much difference if there are...

...ion in MachO). So the low_pc of the subprogram/function, for instance, or if there are two functions in the same section with debug info for both, the low_pc of the first of those functions, etc... If the label difference in a low_pc attribute is relative to the start of a section, could a linker orderfile pass break the dwarf unless it updates the offset? Ditto, I suppose, for an intra-function offset when something like propeller is used to reorder basic blocks (I’m thinking of At_call_return_pc now). Apologies if this has been answered elsewhere, I suppose there must be a solution for this for At...

...tatic int i = 53; > > fptr_t get_fptr(void) > { > if (i >= 0) > fptr = foo; > else > fptr = bar; > > return fptr; > } > On Apr 19, 2018, at 6:18 PM, Peter Collingbourne <peter at pcc.me.uk<mailto:peter at pcc.me.uk>> wrote: Regarding the orderfile, yes, I was thinking more about ordering the real functions. In that case it sounds like your best option may be to implement the optimization pass to make direct calls go directly to the real function. From a performance perspective I don't think it would make much difference if there are unu...

...e >>>> > fptr = bar; >>>> > >>>> > return fptr; >>>> > } >>>> > >>>> >>> > > > > On Apr 19, 2018, at 6:18 PM, Peter Collingbourne <peter at pcc.me.uk> wrote: > > Regarding the orderfile, yes, I was thinking more about ordering the real > functions. > > In that case it sounds like your best option may be to implement the > optimization pass to make direct calls go directly to the real function. > From a performance perspective I don't think it would make much dif...

...t-nbd-plugin(1) now requires libnbd. (If libnbd is not present at build time then this plugin is not built). The fallback code in this plugin which made NBD connections by constructing NBD command packets without using libnbd has been removed (Eric Blake). scripts/git.orderfile has been improved so that commands like "git diff" and "git show" display OCaml sources in a natural order with interface first followed by implementation. Various fixes for MinGW. Note MinGW / MSYS support is a work in progress and not finished yet...