Libguestfs - Jul 2019 - [libnbd PATCH] maint: Add git.orderfile

Borrow an idea from nbdkit (in turn borrowed from qemu) on making
patches easier to review by sorting diffs based on filename.
---

We can tweak this order if desired, but the order presented here
made enough sense to me.

 Makefile.am           |  1 +
 scripts/git.orderfile | 58 +++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 59 insertions(+)
 create mode 100644 scripts/git.orderfile

diff --git a/Makefile.am b/Makefile.am
index b6cb8fe..588d505 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -23,6 +23,7 @@ EXTRA_DIST = \
 	.dir-locals.el \
 	.gitignore \
 	html/pod.css \
+	scripts/git.orderfile \
 	$(NULL)

 SUBDIRS = \
diff --git a/scripts/git.orderfile b/scripts/git.orderfile
new file mode 100644
index 0000000..261e171
--- /dev/null
+++ b/scripts/git.orderfile
@@ -0,0 +1,58 @@
+# nbd client library in userspace
+# Copyright (C) 2013-2019 Red Hat Inc.
+#
+# This library is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Lesser General Public
+# License as published by the Free Software Foundation; either
+# version 2 of the License, or (at your option) any later version.
+#
+# This library is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public
+# License along with this library; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+
+# You can use this to change the ordering of files within patches to
+# make them easier to follow.
+#
+# Use:
+#   git diff -O scripts/git.orderfile
+#
+# Or make the change permanently by doing:
+#   git config diff.orderFile scripts/git.orderfile
+
+# Documentation.
+docs/*
+*.pod
+
+# Build files.
+configure.ac
+Makefile.am
+
+# Source header files.
+lib/*.h
+common/*.h
+common/*/*.h
+
+# Generator files.
+generator/generator
+generator/*
+
+# Source files.
+lib/*.c
+lib/*
+common/*
+
+# Language bindings.
+python/*
+ocaml/*
+
+# Tests.
+tests/*
+examples/*
+interop/*
+
+# Anything else last.
-- 
2.20.1

On Thu, Jul 25, 2019 at 02:22:59PM -0500, Eric Blake
wrote:
> Borrow an idea from nbdkit (in turn borrowed from qemu) on making
> patches easier to review by sorting diffs based on filename.
> ---
> 
> We can tweak this order if desired, but the order presented here
> made enough sense to me.
> 
>  Makefile.am           |  1 +
>  scripts/git.orderfile | 58 +++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 59 insertions(+)
>  create mode 100644 scripts/git.orderfile
> 
> diff --git a/Makefile.am b/Makefile.am
> index b6cb8fe..588d505 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -23,6 +23,7 @@ EXTRA_DIST = \
>  	.dir-locals.el \
>  	.gitignore \
>  	html/pod.css \
> +	scripts/git.orderfile \
>  	$(NULL)
> 
>  SUBDIRS = \
> diff --git a/scripts/git.orderfile b/scripts/git.orderfile
> new file mode 100644
> index 0000000..261e171
> --- /dev/null
> +++ b/scripts/git.orderfile
> @@ -0,0 +1,58 @@
> +# nbd client library in userspace
> +# Copyright (C) 2013-2019 Red Hat Inc.
> +#
> +# This library is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU Lesser General Public
> +# License as published by the Free Software Foundation; either
> +# version 2 of the License, or (at your option) any later version.
> +#
> +# This library is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +# Lesser General Public License for more details.
> +#
> +# You should have received a copy of the GNU Lesser General Public
> +# License along with this library; if not, write to the Free Software
> +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
USA
> +
> +# You can use this to change the ordering of files within patches to
> +# make them easier to follow.
> +#
> +# Use:
> +#   git diff -O scripts/git.orderfile
> +#
> +# Or make the change permanently by doing:
> +#   git config diff.orderFile scripts/git.orderfile
> +
> +# Documentation.
> +docs/*
> +*.pod
> +
> +# Build files.
> +configure.ac
> +Makefile.am
> +
> +# Source header files.
> +lib/*.h
> +common/*.h
> +common/*/*.h
> +
> +# Generator files.
> +generator/generator
> +generator/*
> +
> +# Source files.
> +lib/*.c
> +lib/*
> +common/*
> +
> +# Language bindings.
> +python/*
> +ocaml/*
> +
> +# Tests.
> +tests/*
> +examples/*
> +interop/*
> +
> +# Anything else last.
> -- 
> 2.20.1
ACK - I thought we'd already got this, but we don't.

Thanks,

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/