search for: opus_arm_neon_intr_cppflag

Hello, I received feedback from engineers working on NE10 [1] that it would be better to use NE10 [1] for FFT optimizations for opus use cases. However, these FFT patches are currently in review and haven't been integrated into NE10 yet. While the FFT functions in NE10 are getting baked, I wanted to optimize the celt_pitch_xcorr (floating point only) and use it to introduce ARM NEON

Review comments inline. > +if OPUS_ARM_NEON_INTR > +noinst_LTLIBRARIES = libarmneon.la > +libarmneon_la_SOURCES = $(CELT_SOURCES_ARM_NEON_INTR) > +libarmneon_la_CPPFLAGS = $(OPUS_ARM_NEON_INTR_CPPFLAGS) -I$(top_srcdir)/include > +endif I don't think these should be in a separate library. It brings with it lots of complications (to name one: wouldn't the .pc files need to be updated?). Please use the same mechanism that the SSE intrinsics use to add CFLAGS to the compilation of spe...

...ile.am b/Makefile.am index e20f7b4..0e9e120 100644 --- a/Makefile.am +++ b/Makefile.am @@ -38,6 +38,12 @@ CELT_SOURCES += $(CELT_SOURCES_SSE) endif endif +if OPUS_ARM_NEON_INTR +noinst_LTLIBRARIES = libarmneon.la +libarmneon_la_SOURCES = $(CELT_SOURCES_ARM_NEON_INTR) +libarmneon_la_CPPFLAGS = $(OPUS_ARM_NEON_INTR_CPPFLAGS) -I$(top_srcdir)/include +endif + if CPU_ARM CELT_SOURCES += $(CELT_SOURCES_ARM) SILK_SOURCES += $(SILK_SOURCES_ARM) @@ -59,6 +65,9 @@ include opus_headers.mk libopus_la_SOURCES = $(CELT_SOURCES) $(SILK_SOURCES) $(OPUS_SOURCES) libopus_la_LDFLAGS = -no-undefined -version-info @OPUS_LT_CURRENT...

...AGS="$CFLAGS"; CFLAGS="-mfpu=neon $CFLAGS" >> + AC_COMPILE_IFELSE( >> + [AC_LANG_PROGRAM([[#include <arm_neon.h>]], [])], >> + [ >> + OPUS_ARM_NEON_INTR=1 >> + OPUS_ARM_NEON_INTR_CPPFLAGS="-mfpu=neon -O3" >> + AC_SUBST(OPUS_ARM_NEON_INTR_CPPFLAGS) >> + ], >> + [ >> + OPUS_ARM_NEON_INTR=0 >> + ]) >> + CFLAGS="$save_CFLAGS" >&g...

Almost there... just a few nits left. Viswanath Puttagunta wrote: > +if OPUS_ARM_NEON_INTR > +CELT_SOURCES += $(CELT_SOURCES_ARM_NEON_INTR) > +OPUS_ARM_NEON_INTR_CPPFLAGS = -mfpu=neon -O3 I'll repeat: I don't think you should change the optimization level here. > + /* Just unroll the rest of the loop */ I saw you decided to keep this unrolled, but you didn't actually answer my question. > -#elif defined(OPUS_ARM_ASM) && defined(FIXE...

Viswanath Puttagunta wrote: > if OPUS_ARM_NEON_INTR > CELT_ARM_NEON_INTR_OBJ = $(CELT_SOURCES_ARM_NEON_INTR:.c=.lo) \ > - %test_unit_rotation.o %test_unit_mathops.o > -$(CELT_ARM_NEON_INTR_OBJ): CFLAGS += $(OPUS_ARM_NEON_INTR_CPPFLAGS) > + $(CELT_SOURCES_ARM_NE10:.c=.lo) \ > + %test_unit_rotation.o %test_unit_mathops.o \ > + %test_unit_mdct.o %test_unit_dft.o Crazy indentation. > +$(CELT_ARM_NEON_INTR_OBJ): CFLAGS += $(OPUS_ARM_NEON_INTR_CPPFLAGS) $(NE...

Hi, Optimizes celt_pitch_xcorr for floating point. Changes from RFCv1: - Rebased on top of commit aad281878: Fix celt_pitch_xcorr_c signature. which got rid of ugly code around CELT_PITCH_XCORR_IMPL passing of "arch" parameter. - Unified with --enable-intrinsics used by x86 - Modified algorithm to be more in-line with algorithm in celt_pitch_xcorr_arm.s Viswanath Puttagunta

...On 28 November 2014 at 15:52, Timothy B. Terriberry <tterribe at xiph.org> wrote: > Review comments inline. > >> +if OPUS_ARM_NEON_INTR >> +noinst_LTLIBRARIES = libarmneon.la >> +libarmneon_la_SOURCES = $(CELT_SOURCES_ARM_NEON_INTR) >> +libarmneon_la_CPPFLAGS = $(OPUS_ARM_NEON_INTR_CPPFLAGS) -I$(top_srcdir)/include >> +endif > > I don't think these should be in a separate library. It brings with it > lots of complications (to name one: wouldn't the .pc files need to be > updated?). Please use the same mechanism that the SSE intrinsics use to > add CFLAGS...

...SOURCES = $(CELT_SOURCES_ARM_ASM:.s=-gnu.S) \ @@ -260,3 +265,9 @@ if HAVE_SSE2 $(SSE_OBJ): CFLAGS += -msse2 endif endif + +if OPUS_ARM_NEON_INTR +CELT_ARM_NEON_INTR_OBJ = $(CELT_SOURCES_ARM_NEON_INTR:.c=.lo) \ + %test_unit_rotation.o %test_unit_mathops.o +$(CELT_ARM_NEON_INTR_OBJ): CFLAGS += $(OPUS_ARM_NEON_INTR_CPPFLAGS) +endif diff --git a/celt/arm/arm_celt_map.c b/celt/arm/arm_celt_map.c index 547a84d..ecdf7ec 100644 --- a/celt/arm/arm_celt_map.c +++ b/celt/arm/arm_celt_map.c @@ -41,9 +41,18 @@ opus_val32 (*const CELT_PITCH_XCORR_IMPL[OPUS_ARCHMASK+1])(const opus_val16 *, MAY_HAVE_MEDIA(celt_pitch_xcorr), /*...

Hi, Optimizes celt_pitch_xcorr for floating point. Changes from RFCv2: - Changes recommended by Timothy for celt_neon_intr.c everything except, left the unrolled loop still unrolled - configure.ac - use AC_LINK_IFELSE instead of AC_COMPILE_IFELSE - Moved compile flags into Makefile.am - OPUS_ARM_NEON_INR --> typo --> OPUS_ARM_NEON_INTR Viswanath Puttagunta (1): armv7:

From: Viswanath Puttagunta <viswanath.puttagunta at linaro.org> Hi, Optimizes celt_pitch_xcorr for floating point. Changes from RFCv1: - Rebased on top of commit aad281878: Fix celt_pitch_xcorr_c signature. which got rid of ugly code around CELT_PITCH_XCORR_IMPL passing of "arch" parameter. - Unified with --enable-intrinsics used by x86 - Modified algorithm to be more

...e at xiph.org> wrote: > Viswanath Puttagunta wrote: >> >> if OPUS_ARM_NEON_INTR >> CELT_ARM_NEON_INTR_OBJ = $(CELT_SOURCES_ARM_NEON_INTR:.c=.lo) \ >> - %test_unit_rotation.o %test_unit_mathops.o >> -$(CELT_ARM_NEON_INTR_OBJ): CFLAGS += $(OPUS_ARM_NEON_INTR_CPPFLAGS) >> + $(CELT_SOURCES_ARM_NE10:.c=.lo) \ >> + %test_unit_rotation.o >> %test_unit_mathops.o \ >> + %test_unit_mdct.o %test_unit_dft.o > > > Crazy indentation. > >> +$(CELT_AR...

...rinsics or not > + > + #Currently we only have intrinsic optimization for floating point > + AS_IF([test x"$enable_float" = x"yes"], > + [ > + AS_IF([test x"$OPUS_ARM_NEON_INTR" = x"1"], > + [ > + OPUS_ARM_NEON_INTR_CPPFLAGS="-mfpu=neon -O3" I don't think you should change the optimization level here.

...more.. Regards, Vish On 17 December 2014 at 23:59, Timothy B. Terriberry <tterribe at xiph.org> wrote: > > Almost there... just a few nits left. > > Viswanath Puttagunta wrote: > > +if OPUS_ARM_NEON_INTR > > +CELT_SOURCES += $(CELT_SOURCES_ARM_NEON_INTR) > > +OPUS_ARM_NEON_INTR_CPPFLAGS = -mfpu=neon -O3 > > I'll repeat: I don't think you should change the optimization level here. After you feedback, I moved this part from configure.ac to Makefile.am.. If it doesn't belong here either, then I need some guidance. I wouldn't know where else to put this. Withou...

Hi, Optimizes celt_pitch_xcorr for ARM NEON floating point. Changes from RFCv3: - celt_neon_intr.c - removed warnings due to not having constant pointers - Put simpler loop to take care of corner cases. Unrolling using intrinsics was not really mapping well to what was done in celt_pitch_xcorr_arm.s - Makefile.am Removed explicit -O3 optimization - test_unit_mathops.c,

...on_intr.c diff --git a/Makefile.am b/Makefile.am index e20f7b4..95323ca 100644 --- a/Makefile.am +++ b/Makefile.am @@ -41,6 +41,12 @@ endif if CPU_ARM CELT_SOURCES += $(CELT_SOURCES_ARM) SILK_SOURCES += $(SILK_SOURCES_ARM) + +if OPUS_ARM_NEON_INTR +CELT_SOURCES += $(CELT_SOURCES_ARM_NEON_INTR) +OPUS_ARM_NEON_INTR_CPPFLAGS = -mfpu=neon +endif + if OPUS_ARM_EXTERNAL_ASM nodist_libopus_la_SOURCES = $(CELT_SOURCES_ARM_ASM:.s=-gnu.S) BUILT_SOURCES = $(CELT_SOURCES_ARM_ASM:.s=-gnu.S) \ @@ -260,3 +266,9 @@ if HAVE_SSE2 $(SSE_OBJ): CFLAGS += -msse2 endif endif + +if OPUS_ARM_NEON_INTR +CELT_ARM_NEON_INTR_OBJ = $(CELT...

...on_intr.c diff --git a/Makefile.am b/Makefile.am index e20f7b4..be53754 100644 --- a/Makefile.am +++ b/Makefile.am @@ -41,6 +41,12 @@ endif if CPU_ARM CELT_SOURCES += $(CELT_SOURCES_ARM) SILK_SOURCES += $(SILK_SOURCES_ARM) + +if OPUS_ARM_NEON_INTR +CELT_SOURCES += $(CELT_SOURCES_ARM_NEON_INTR) +OPUS_ARM_NEON_INTR_CPPFLAGS = -mfpu=neon -O3 +endif + if OPUS_ARM_EXTERNAL_ASM nodist_libopus_la_SOURCES = $(CELT_SOURCES_ARM_ASM:.s=-gnu.S) BUILT_SOURCES = $(CELT_SOURCES_ARM_ASM:.s=-gnu.S) \ @@ -260,3 +266,9 @@ if HAVE_SSE2 $(SSE_OBJ): CFLAGS += -msse2 endif endif + +if OPUS_ARM_NEON_INTR +CELT_ARM_NEON_INTR_OBJ = $(...

...index e20f7b4..95323ca 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -41,6 +41,12 @@ endif > if CPU_ARM > CELT_SOURCES += $(CELT_SOURCES_ARM) > SILK_SOURCES += $(SILK_SOURCES_ARM) > + > +if OPUS_ARM_NEON_INTR > +CELT_SOURCES += $(CELT_SOURCES_ARM_NEON_INTR) > +OPUS_ARM_NEON_INTR_CPPFLAGS = -mfpu=neon > +endif > + > if OPUS_ARM_EXTERNAL_ASM > nodist_libopus_la_SOURCES = $(CELT_SOURCES_ARM_ASM:.s=-gnu.S) > BUILT_SOURCES = $(CELT_SOURCES_ARM_ASM:.s=-gnu.S) \ > @@ -260,3 +266,9 @@ if HAVE_SSE2 > $(SSE_OBJ): CFLAGS += -msse2 > endif > endif > + >...

Hello opus-dev, I've been cooking up this patchset to integrate NE10 library into opus. Current patchset focuses on encode use case mainly effecting performance of clt_mdct_forward() and opus_fft() (for float only) Glad to report the following on Encode use case: (Measured on my Beaglebone Black Cortex-A8 board) - Performance improvement for encode use case ~= 12.34% (Based on time -p

.../celt -I$(top_srcdir)/silk \ - -I$(top_srcdir)/silk/float -I$(top_srcdir)/silk/fixed + -I$(top_srcdir)/silk/float -I$(top_srcdir)/silk/fixed $(NE10_CFLAGS) include celt_sources.mk include silk_sources.mk @@ -47,6 +47,10 @@ CELT_SOURCES += $(CELT_SOURCES_ARM_NEON_INTR) OPUS_ARM_NEON_INTR_CPPFLAGS = -mfpu=neon endif +if HAVE_ARM_NE10 +CELT_SOURCES += $(CELT_SOURCES_ARM_NE10) +endif + if OPUS_ARM_EXTERNAL_ASM nodist_libopus_la_SOURCES = $(CELT_SOURCES_ARM_ASM:.s=-gnu.S) BUILT_SOURCES = $(CELT_SOURCES_ARM_ASM:.s=-gnu.S) \ @@ -64,7 +68,7 @@ include opus_headers.mk libopus_la_SOURCES =...