search for: olteanv

On Thu, Mar 30, 2023 at 02:59:04PM +0200, Hans Schultz wrote: > On Thu, Mar 30, 2023 at 15:43, Vladimir Oltean <olteanv at gmail.com> wrote: > > On Tue, Mar 28, 2023 at 09:45:26PM +0200, Hans Schultz wrote: > >> So the solution would be to not let the DSA layer send the > >> SWITCHDEV_FDB_OFFLOADED event in the case when the new dynamic flag is > >> set? > > > > I have...

On Thu, Apr 06, 2023 at 05:17:46PM +0200, Hans Schultz wrote: > On Thu, Mar 30, 2023 at 18:07, Vladimir Oltean <olteanv at gmail.com> wrote: > > As a bug fix, stop reporting to switchdev those FDB entries with > > BR_FDB_ADDED_BY_USER && !BR_FDB_STATIC. Then, after "net" is merged into > > "net-next" next Thursday (the ship has sailed for today), add "bool static...

On Tue, Mar 28, 2023 at 01:04:23PM +0200, Hans Schultz wrote: > On Tue, Mar 28, 2023 at 01:59, Vladimir Oltean <olteanv at gmail.com> wrote: > > > > which idea is that, again? > > So I cannot us the offloaded flag as it is added by DSA in the common > case when using 'bridge fdb replace ... dynamic'. Why not? I find it reasonable that the software bridge does not age out a dynamic F...

On Tue, Mar 28, 2023 at 14:49, Vladimir Oltean <olteanv at gmail.com> wrote: > On Tue, Mar 28, 2023 at 01:04:23PM +0200, Hans Schultz wrote: >> On Tue, Mar 28, 2023 at 01:59, Vladimir Oltean <olteanv at gmail.com> wrote: >> > >> > which idea is that, again? >> >> So I cannot us the offloaded flag as it is...

On Thu, Mar 30, 2023 at 15:43, Vladimir Oltean <olteanv at gmail.com> wrote: > On Tue, Mar 28, 2023 at 09:45:26PM +0200, Hans Schultz wrote: >> So the solution would be to not let the DSA layer send the >> SWITCHDEV_FDB_OFFLOADED event in the case when the new dynamic flag is >> set? > > I have never said that. No, I was j...

On Thu, Mar 30, 2023 at 18:07, Vladimir Oltean <olteanv at gmail.com> wrote: > > Then, make DSA decide whether to handle the "added_by_user && !is_static" > combination or not, based on the presence of the DSA_FDB_FLAG_DYNAMIC > flag, which will be set in ds->supported_fdb_flags only for the mv88e6xxx > driver. Ok...

On Thu, Mar 30, 2023 at 18:07, Vladimir Oltean <olteanv at gmail.com> wrote: > As a bug fix, stop reporting to switchdev those FDB entries with > BR_FDB_ADDED_BY_USER && !BR_FDB_STATIC. Then, after "net" is merged into > "net-next" next Thursday (the ship has sailed for today), add "bool static" It is p...

On Thu, Mar 30, 2023 at 22:27, Vladimir Oltean <olteanv at gmail.com> wrote: > On Thu, Mar 30, 2023 at 09:07:53PM +0200, Hans Schultz wrote: >> Not true, it reveals that I forgot to put it in the patch, that's all. As >> I cannot run several of these tests because of memory constraints I link >> the file to a copy in a rw are...

On Thu, Mar 30, 2023 at 04:54:19PM +0200, Hans Schultz wrote: > I don't know if you have a solution in mind wrt the behaviour of the > offloaded flag if it is not to do as it does now and let the bridge age > out dynamic entries. That led me to conclude that this patch-set cannot > use the offloaded flag, but you seem to suggest otherwise. > > If you have a suggestion, feel

On Thu, Mar 30, 2023 at 16:09, Vladimir Oltean <olteanv at gmail.com> wrote: > On Thu, Mar 30, 2023 at 02:59:04PM +0200, Hans Schultz wrote: >> On Thu, Mar 30, 2023 at 15:43, Vladimir Oltean <olteanv at gmail.com> wrote: >> > On Tue, Mar 28, 2023 at 09:45:26PM +0200, Hans Schultz wrote: >> >> So the solution would...

On Tue, Mar 28, 2023 at 01:59, Vladimir Oltean <olteanv at gmail.com> wrote: > > which idea is that, again? So I cannot us the offloaded flag as it is added by DSA in the common case when using 'bridge fdb replace ... dynamic'. The idea is then to use the ext_learn flag instead, which is not aged by the bridge. To do this the driver (...

On Thu, Mar 30, 2023 at 09:07:53PM +0200, Hans Schultz wrote: > Not true, it reveals that I forgot to put it in the patch, that's all. As > I cannot run several of these tests because of memory constraints I link > the file to a copy in a rw area where I modify the list and just run one > of the subtests at a time. If I try to run the whole it always fails > after a couple of

On Mon, Mar 27, 2023 at 05:31:26PM +0200, Hans Schultz wrote: > On Mon, Mar 27, 2023 at 14:52, Vladimir Oltean <olteanv at gmail.com> wrote: > > > > By the way, there is a behavior change here. > > > > Before: > > > > $ ip link add br0 type bridge && ip link set br0 up > > $ ip link set swp0 master br0 && ip link set swp0 up > > $ bridge fdb add dev...

On Mon, Mar 27, 2023 at 14:52, Vladimir Oltean <olteanv at gmail.com> wrote: > > By the way, there is a behavior change here. > > Before: > > $ ip link add br0 type bridge && ip link set br0 up > $ ip link set swp0 master br0 && ip link set swp0 up > $ bridge fdb add dev swp0 00:01:02:03:04:05 master dynamic &g...

On Mon, Mar 27, 2023 at 11:49:58PM +0200, Hans Schultz wrote: > My first approach was to use the SWITCHDEV_FDB_ADD_TO_BRIDGE event > and not the SWITCHDEV_FDB_OFFLOADED event as the first would set the > external learned flag which is not aged out by the bridge. Link to patch? I don't see any SWITCHDEV_FDB_ADD_TO_BRIDGE call in either the v1:

On Tue, Mar 28, 2023 at 09:45:26PM +0200, Hans Schultz wrote: > So the solution would be to not let the DSA layer send the > SWITCHDEV_FDB_OFFLOADED event in the case when the new dynamic flag is > set? I have never said that.

On Fri, Mar 31, 2023 at 12:37, Vladimir Oltean <olteanv at gmail.com> wrote: > > So, by running the command I posted in the earlier email, you actually > run it on the physical DSA user port interfaces, and it should pass > there too. Okay, that sounds like a good idea which I have not done before. I am seeing how I can install Debian in...

On Fri, Mar 31, 2023 at 02:43:11PM +0200, Hans Schultz wrote: > I will as long as the system is as it is with these selftests, just run > single subtests at a time on target, but if I have new phy problems like > the one you have seen I have had before, then testing on target becomes > off limits. Please open a dedicated communication channel (separate email thread on netdev at

On Mon, Mar 27, 2023 at 19:00, Vladimir Oltean <olteanv at gmail.com> wrote: > A reasonable question you could ask yourself is: why do my BR_FDB_OFFLOADED > entries have this flag in the software bridge in the first place? > Did I add code for it? Is it because there is some difference between > mv88e6xxx and ocelot/felix, or is it becaus...

On Fri, Mar 31, 2023 at 10:06:34AM +0200, Hans Schultz wrote: > The memory problems are of course on the embedded target. In that case I > think it would be a very good idea to do something to design the system > better, so that it frees memory between the subtests. People like Martin Blumenstingl have managed to deploy and run the networking kselftests on OpenWRT, which typically runs