search for: nvloadpalette

...uveau <nouveau at lists.freedesktop.org> > Subject: Re: [Nouveau] [PATCH] Fix colormap handling at screen depth > 30. > Message-ID: > <CAKb7UvhnUF6W41vXHpC+Q+jVSROgnHuxd8CzvfOGHmYSq_xTHQ at mail.gmail.com> > Content-Type: text/plain; charset="UTF-8" > > NVLoadPalette is pretty hard-coded to 256. I haven't looked at what > all xf86HandleColormaps does, but it seems pretty suspicious. Also It's also pretty dead :). NVLoadPalette is not ever used, because nouveau hooks up the .gamma_set function in xf86CrtcFuncsRec, so xf86HandleColormaps ignores the...

...b/src/nv_driver.c index 32062eb..4fcd4c1 100644 --- a/src/nv_driver.c +++ b/src/nv_driver.c @@ -1568,8 +1568,8 @@ NVScreenInit(SCREEN_INIT_ARGS_DECL) * Must follow initialization of the default colormap */ if (xf86_config->num_crtc && - !xf86HandleColormaps(pScreen, 256, 8, NVLoadPalette, - NULL, CMAP_PALETTED_TRUECOLOR)) + !xf86HandleColormaps(pScreen, 1 << pScrn->rgbBits, pScrn->rgbBits, + NVLoadPalette, NULL, CMAP_PALETTED_TRUECOLOR)) return FALSE; /* Report any unused options (only for the first generation) */ -- 2.7.4

...> >> Subject: Re: [Nouveau] [PATCH] Fix colormap handling at screen depth >> 30. >> Message-ID: >> >> <CAKb7UvhnUF6W41vXHpC+Q+jVSROgnHuxd8CzvfOGHmYSq_xTHQ at mail.gmail.com> >> Content-Type: text/plain; charset="UTF-8" >> >> NVLoadPalette is pretty hard-coded to 256. I haven't looked at what >> all xf86HandleColormaps does, but it seems pretty suspicious. Also > > > It's also pretty dead :). NVLoadPalette is not ever used, because nouveau > hooks up the .gamma_set function in xf86CrtcFuncsRec, so xf86Handle...

...ust follow initialization of the default colormap. + * X-Server < 1.20 mishandles > 256 slots / > 8 bpc color maps, so skip + * color map setup on old servers at > 8 bpc. Gamma luts still work. */ - if (xf86_config->num_crtc && - !xf86HandleColormaps(pScreen, 256, 8, NVLoadPalette, - NULL, CMAP_PALETTED_TRUECOLOR)) + if (xf86_config->num_crtc && (pScrn->rgbBits <= 8 || + XORG_VERSION_CURRENT >= XORG_VERSION_NUMERIC(1,20,0,0,0)) && + !xf86HandleColormaps(pScreen, 1 << pScrn->rgbBits, pScrn->rgbBits, + NVLoadPalette, NULL...

...x08117bec in AbortServer () at log.c:407 #3 0x0811808b in FatalError ( f=0x8189dd8 "Caught signal %d. Server aborting\n") at log.c:553 #4 0x080afb45 in xf86SigHandler (signo=-1077945400) at xf86Events.c:593 #5 0xbb85b370 in __opendir2 () from /usr/lib/libc.so.12 #6 0xbb5d0294 in NVLoadPalette (pScrn=0xbb646000, numColors=256, indices=0xbb611c00, colors=0xbb649800, pVisual=0xbb62f5b0) at nv_driver.c:1890 #7 0x080b4962 in CMapRefreshColors (pmap=0xbb6b6000, defs=256, indices=0xbb611c00) at xf86cmap.c:644 #8 0x080b4ddc in CMapReinstallMap (pmap=0xbb6b6000) at xf86cmap.c:51...

...ouveau] [PATCH] Fix colormap handling at screen depth >>> 30. >>> Message-ID: >>> >>> <CAKb7UvhnUF6W41vXHpC+Q+jVSROgnHuxd8CzvfOGHmYSq_xTHQ at mail.gmail.com> >>> Content-Type: text/plain; charset="UTF-8" >>> >>> NVLoadPalette is pretty hard-coded to 256. I haven't looked at what >>> all xf86HandleColormaps does, but it seems pretty suspicious. Also >> >> >> It's also pretty dead :). NVLoadPalette is not ever used, because nouveau >> hooks up the .gamma_set function in xf86CrtcFun...

...-1441,19 +1587,19 @@ NVScreenInit(SCREEN_INIT_ARGS_DECL) * Initialize colormap layer. * Must follow initialization of the default colormap */ - if (xf86_config->num_crtc && + if (!xorgMir && xf86_config->num_crtc && !xf86HandleColormaps(pScreen, 256, 8, NVLoadPalette, NULL, CMAP_PALETTED_TRUECOLOR)) - return FALSE; /* Report any unused options (only for the first generation) */ if (serverGeneration == 1) xf86ShowUnusedOptions(pScrn->scrnIndex, pScrn->options); - if (xf86_config->num_crtc) + if (!xorgMir && xf86_config->num_...

http://bugs.freedesktop.org/show_bug.cgi?id=18286 Summary: GeForce 8300 not supported (10de:0848/C77/MCP77) Product: xorg Version: 7.4 Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Driver/nouveau AssignedTo: nouveau at lists.freedesktop.org