search for: nvkm_vmm_new

...pu results in a kernel panic as the device cannot be fully mapped. I've made modifications in nv50 and vmm to unbind the driver from this hierarchy, and modified gf100 assuming it will have the same issue. 1/4 also includes a fix where nv50 doesn't look like it checks the return value for nvkm_vmm_new for bar1. I don't know if this was intentional (eg, it could work without it). I'm wholly unfamiliar with linux graphics drivers so let me know if there's a better place for this. Jon Derrick (4): drm/nouveau/bar/nv50: check bar1 vmm return value drm/nouveau/bar/nv50: ensure BAR i...

...r->mem); @@ -127,7 +127,10 @@ nv50_bar_oneinit(struct nvkm_bar *base) /* BAR2 */ start = 0x0100000000ULL; - limit = start + device->func->resource_size(device, 3); + size = device->func->resource_size(device, 3); + if (!size) + return -ENOMEM; + limit = start + size; ret = nvkm_vmm_new(device, start, limit-- - start, NULL, 0, &bar2_lock, "bar2", &bar->bar2_vmm); @@ -164,7 +167,10 @@ nv50_bar_oneinit(struct nvkm_bar *base) /* BAR1 */ start = 0x0000000000ULL; - limit = start + device->func->resource_size(device, 1); + size = device->func-&...

...r->mem); @@ -127,7 +127,10 @@ nv50_bar_oneinit(struct nvkm_bar *base) /* BAR2 */ start = 0x0100000000ULL; - limit = start + device->func->resource_size(device, 3); + size = device->func->resource_size(device, 3); + if (!size) + return -ENOMEM; + limit = start + size; ret = nvkm_vmm_new(device, start, limit-- - start, NULL, 0, &bar2_lock, "bar2", &bar->bar2_vmm); @@ -164,7 +167,10 @@ nv50_bar_oneinit(struct nvkm_bar *base) /* BAR1 */ start = 0x0000000000ULL; - limit = start + device->func->resource_size(device, 1); + size = device->func-&...

...r->mem); @@ -127,7 +127,10 @@ nv50_bar_oneinit(struct nvkm_bar *base) /* BAR2 */ start = 0x0100000000ULL; - limit = start + device->func->resource_size(device, 3); + size = device->func->resource_size(device, 3); + if (!size) + return -ENOMEM; + limit = start + size; ret = nvkm_vmm_new(device, start, limit-- - start, NULL, 0, &bar2_lock, "bar2", &bar->bar2_vmm); @@ -164,7 +167,10 @@ nv50_bar_oneinit(struct nvkm_bar *base) /* BAR1 */ start = 0x0000000000ULL; - limit = start + device->func->resource_size(device, 1); + size = device->func-&...

...> > I've made modifications in nv50 and vmm to unbind the driver from this > hierarchy, and modified gf100 assuming it will have the same issue. It would have the same issue indeed. > > 1/4 also includes a fix where nv50 doesn't look like it checks the > return value for nvkm_vmm_new for bar1. I don't know if this was > intentional (eg, it could work without it). No, that's a good catch. It would have worked at one point in time, but would be a NULL-ptr deref since a rework that was done a while ago. > > I'm wholly unfamiliar with linux graphics drivers s...

With linux-next-2017-12-14, I get a crash when nouveau is loaded by systemd-udevd. [ 12.050625] Unable to handle kernel NULL pointer dereference at virtual address 00000058 [ 12.050627] Mem abort info: [ 12.050628] ESR = 0x96000004 [ 12.050630] Exception class = DABT (current EL), IL = 32 bits [ 12.050631] SET = 0, FnV = 0 [ 12.050632] EA = 0, S1PTW = 0 [ 12.050633] Data

...00000000000000 x4 : 0000000001000000 [ 12.021310] x3 : 0000000000000000 x2 : ffff8001c8be7000 [ 12.026612] x1 : ffff0000010cd3f0 x0 : 0000000000000000 [ 12.031916] Call trace: [ 12.034601] gf100_vmm_new_+0x60/0x128 [nouveau] [ 12.039415] gf100_vmm_new+0x70/0x98 [nouveau] [ 12.044053] nvkm_vmm_new+0x78/0xb0 [nouveau] [ 12.048597] gf100_bar_oneinit_bar+0x90/0x120 [nouveau] [ 12.054012] gf100_bar_oneinit+0x74/0x88 [nouveau] [ 12.058989] nvkm_bar_oneinit+0x28/0x38 [nouveau] [ 12.063880] nvkm_subdev_init+0x6c/0x278 [nouveau] [ 12.068865] nvkm_device_init+0x150/0x2b0 [nouveau] [...