search for: nvkm_nsec

...vers need to cease MMIO and > PCI config space access once a device is gone to avoid delaying device > teardown or accessing a newly attached replacement device. Also, MMIO > reads to removed devices return "all ones", which results in an infinite > loop e.g. in nouveau's nvkm_nsec(). > > The question is how to recognize device removal. One common method is to > read the vendor register with pci_device_is_present(), but this reports > a false positive if the device is present but in D3cold. A better method > is to let the PCIe hotplug driver recognize and ca...

...;> break; > >>> ) < 0) > >>> return -ETIMEDOUT; > >>> > >>> return 0; > >>> } > >>> > >>> nvkm_msec is #defined to nvkm_usec which in turn is #defined to nvkm_nsec where the loop that the break is related to > >>> appears > >> > >> I think someone who knows the code needs to look at this. What I can confirm is that after a freeze, I waited for 90 > >> seconds for a timeout to occur, but it didn't. > > Hey, >...

...> >>>>>> return -ETIMEDOUT; > >>>>>> > >>>>>> return 0; > >>>>>> } > >>>>>> > >>>>>> nvkm_msec is #defined to nvkm_usec which in turn is #defined to nvkm_nsec where the loop that the break is related to > >>>>>> appears > >>>>> > >>>>> I think someone who knows the code needs to look at this. What I can confirm is that after a freeze, I waited for 90 > >>>>> seconds for a timeout...

...(nvkm_falcon_rd32(falcon, 0x10c) & 0x00000006)) > > break; > > ) < 0) > > return -ETIMEDOUT; > > > > return 0; > > } > > > > nvkm_msec is #defined to nvkm_usec which in turn is #defined to nvkm_nsec where the loop that the break is related to > > appears > > I think someone who knows the code needs to look at this. What I can confirm is that after a freeze, I waited for 90 > seconds for a timeout to occur, but it didn't. Hey, Are you able to try the attached patch for me pl...

...se removal: DRM drivers need to cease MMIO and PCI config space access once a device is gone to avoid delaying device teardown or accessing a newly attached replacement device. Also, MMIO reads to removed devices return "all ones", which results in an infinite loop e.g. in nouveau's nvkm_nsec(). The question is how to recognize device removal. One common method is to read the vendor register with pci_device_is_present(), but this reports a false positive if the device is present but in D3cold. A better method is to let the PCIe hotplug driver recognize and cache device removal. Keith...