search for: nvdimms

Hi, I've found out that NVDIMM size and label size matter for regular (non-NV) DIMM hot plug. If the NVDIMM is not aligned correctly, the guest OS will not accept the hot plugged memory and will complain with messages such as Block size [0x8000000] unaligned hotplug range: start 0x225000000, size 0x10000000 The start address above is also reported within <memory> element of the hot

Peter Krempa <pkrempa@redhat.com> writes: > On Tue, Jun 16, 2020 at 12:54:29 +0200, Milan Zamazal wrote: >> Hi, >> > >> I've found out that NVDIMM size and label size matter for regular >> (non-NV) DIMM hot plug. If the NVDIMM is not aligned correctly, the >> guest OS will not accept the hot plugged memory and will complain with >> messages

Hi, I've met two situations with NVDIMM support in libvirt where I'm not sure all the parties (libvirt & I) do the things correctly. The first problem is with memory alignment and size changes. In addition to the size changes applied to NVDIMMs by QEMU, libvirt also makes some NVDIMM size changes for better alignments, in qemuDomainMemoryDeviceAlignSize. This can lead to the size being rounded up, exceeding the size of the backing device and QEMU failing to start the VM for that reason (I've experienced that actually). I work with e...

On Tue, May 14, 2019 at 7:55 AM Pankaj Gupta <pagupta at redhat.com> wrote: > > This patch adds functionality to perform flush from guest > to host over VIRTIO. We are registering a callback based > on 'nd_region' type. virtio_pmem driver requires this special > flush function. For rest of the region types we are registering > existing flush function. Report error

On Tue, Jun 16, 2020 at 12:54:29 +0200, Milan Zamazal wrote: > Hi, > > I've found out that NVDIMM size and label size matter for regular > (non-NV) DIMM hot plug. If the NVDIMM is not aligned correctly, the > guest OS will not accept the hot plugged memory and will complain with > messages such as > > Block size [0x8000000] unaligned hotplug range: start

Milan Zamazal <mzamazal@redhat.com> writes: > Daniel P. Berrangé <berrange@redhat.com> writes: > >> On Thu, Jul 02, 2020 at 01:21:15PM +0200, Milan Zamazal wrote: >>> The second problem is that a VM fails to start with a backing NVDIMM in >>> devdax mode due to SELinux preventing access to the /dev/dax* device (it >>> doesn't happen with any

On Tue, 11 Jun 2019 22:07:57 +0530 Pankaj Gupta <pagupta at redhat.com> wrote: > This patch adds virtio-pmem driver for KVM guest. > > Guest reads the persistent memory range information from > Qemu over VIRTIO and registers it on nvdimm_bus. It also > creates a nd_region object with the persistent memory > range information so that existing 'nvdimm/pmem' driver

On Tue, 11 Jun 2019 22:07:57 +0530 Pankaj Gupta <pagupta at redhat.com> wrote: > This patch adds virtio-pmem driver for KVM guest. > > Guest reads the persistent memory range information from > Qemu over VIRTIO and registers it on nvdimm_bus. It also > creates a nd_region object with the persistent memory > range information so that existing 'nvdimm/pmem' driver

On Tue, Jun 16, 2020 at 12:54:29PM +0200, Milan Zamazal wrote: > Hi, > > I've found out that NVDIMM size and label size matter for regular > (non-NV) DIMM hot plug. If the NVDIMM is not aligned correctly, the > guest OS will not accept the hot plugged memory and will complain with > messages such as > > Block size [0x8000000] unaligned hotplug range: start

...; > >> I've met two situations with NVDIMM support in libvirt where I'm not >> sure all the parties (libvirt & I) do the things correctly. >> >> The first problem is with memory alignment and size changes. In >> addition to the size changes applied to NVDIMMs by QEMU, libvirt also >> makes some NVDIMM size changes for better alignments, in >> qemuDomainMemoryDeviceAlignSize. This can lead to the size being >> rounded up, exceeding the size of the backing device and QEMU failing to >> start the VM for that reason (I've experi...

This patch adds functionality to perform flush from guest to host over VIRTIO. We are registering a callback based on 'nd_region' type. virtio_pmem driver requires this special flush function. For rest of the region types we are registering existing flush function. Report error returned by host fsync failure to userspace. Signed-off-by: Pankaj Gupta <pagupta at redhat.com> ---

Hi Dan, Proposing the patch series to be merged via nvdimm tree as kindly agreed by you. We have ack/review on XFS, EXT4 & VIRTIO patches. Incorporated all the changes suggested in v8. This version added a new patch 4 for dax for device mapper change and some minor style changes in patch 2. Kept all the reviews. Request to please merge the series. --- This patch series has

...; > >> I've met two situations with NVDIMM support in libvirt where I'm not >> sure all the parties (libvirt & I) do the things correctly. >> >> The first problem is with memory alignment and size changes. In >> addition to the size changes applied to NVDIMMs by QEMU, libvirt also >> makes some NVDIMM size changes for better alignments, in >> qemuDomainMemoryDeviceAlignSize. This can lead to the size being >> rounded up, exceeding the size of the backing device and QEMU failing to >> start the VM for that reason (I've experi...

Hi Pankaj, On Tue, 11 Jun 2019 23:34:50 -0400 (EDT) Pankaj Gupta <pagupta at redhat.com> wrote: > Hi Cornelia, > > > On Tue, 11 Jun 2019 22:07:57 +0530 > > Pankaj Gupta <pagupta at redhat.com> wrote: > > > + err1 = virtqueue_kick(vpmem->req_vq); > > > + spin_unlock_irqrestore(&vpmem->pmem_lock, flags); > > > + /* > >

On Wed, 12 Jun 2019 18:15:22 +0530 Pankaj Gupta <pagupta at redhat.com> wrote: > This patch adds virtio-pmem driver for KVM guest. > > Guest reads the persistent memory range information from > Qemu over VIRTIO and registers it on nvdimm_bus. It also > creates a nd_region object with the persistent memory > range information so that existing 'nvdimm/pmem' driver

This patch series is ready to be merged via nvdimm tree as discussed with Dan. We have ack/review on XFS, EXT4 device mapper & VIRTIO patches. This version has minor changes in patch 2. Keeping all the existing r-o-bs. Jakob CCed also tested the patch series and confirmed the working of v9. --- This patch series has implementation for "virtio pmem". "virtio pmem"

This patch adds functionality to perform flush from guest to host over VIRTIO. We are registering a callback based on 'nd_region' type. virtio_pmem driver requires this special flush function. For rest of the region types we are registering existing flush function. Report error returned by host fsync failure to userspace. This also handles asynchronous flush requests from the block layer

...mazal wrote: > Hi, > > I've met two situations with NVDIMM support in libvirt where I'm not > sure all the parties (libvirt & I) do the things correctly. > > The first problem is with memory alignment and size changes. In > addition to the size changes applied to NVDIMMs by QEMU, libvirt also > makes some NVDIMM size changes for better alignments, in > qemuDomainMemoryDeviceAlignSize. This can lead to the size being > rounded up, exceeding the size of the backing device and QEMU failing to > start the VM for that reason (I've experienced that actua...

Hi Michael & Dan, Please review/ack the patch series from LIBNVDIMM & VIRTIO side. We have ack on ext4, xfs patches(4, 5 & 6) patch 2. Still need your ack on nvdimm patches(1 & 3) & virtio patch 2. Changes done from v7 are only in patch(2 & 3) and not affecting existing reviews. Request to please review. ---- This patch series has implementation for "virtio

Hi Michael & Dan, Please review/ack the patch series from LIBNVDIMM & VIRTIO side. We have ack on ext4, xfs patches(4, 5 & 6) patch 2. Still need your ack on nvdimm patches(1 & 3) & virtio patch 2. Changes done from v7 are only in patch(2 & 3) and not affecting existing reviews. Request to please review. ---- This patch series has implementation for "virtio