search for: nvdimm

Hi, I've found out that NVDIMM size and label size matter for regular (non-NV) DIMM hot plug. If the NVDIMM is not aligned correctly, the guest OS will not accept the hot plugged memory and will complain with messages such as Block size [0x8000000] unaligned hotplug range: start 0x225000000, size 0x10000000 The start addres...

Peter Krempa <pkrempa@redhat.com> writes: > On Tue, Jun 16, 2020 at 12:54:29 +0200, Milan Zamazal wrote: >> Hi, >> > >> I've found out that NVDIMM size and label size matter for regular >> (non-NV) DIMM hot plug. If the NVDIMM is not aligned correctly, the >> guest OS will not accept the hot plugged memory and will complain with >> messages such as >> >> Block size [0x8000000] unaligned hotplug range: start 0...

Hi, I've met two situations with NVDIMM support in libvirt where I'm not sure all the parties (libvirt & I) do the things correctly. The first problem is with memory alignment and size changes. In addition to the size changes applied to NVDIMMs by QEMU, libvirt also makes some NVDIMM size changes for better alignments, in qemuD...

...l > flush function. For rest of the region types we are registering > existing flush function. Report error returned by host fsync > failure to userspace. > > Signed-off-by: Pankaj Gupta <pagupta at redhat.com> > --- > drivers/acpi/nfit/core.c | 4 ++-- > drivers/nvdimm/claim.c | 6 ++++-- > drivers/nvdimm/nd.h | 1 + > drivers/nvdimm/pmem.c | 13 ++++++++----- > drivers/nvdimm/region_devs.c | 26 ++++++++++++++++++++++++-- > include/linux/libnvdimm.h | 8 +++++++- > 6 files changed, 46 insertions(+), 12 deletions(-) >...

On Tue, Jun 16, 2020 at 12:54:29 +0200, Milan Zamazal wrote: > Hi, > > I've found out that NVDIMM size and label size matter for regular > (non-NV) DIMM hot plug. If the NVDIMM is not aligned correctly, the > guest OS will not accept the hot plugged memory and will complain with > messages such as > > Block size [0x8000000] unaligned hotplug range: start 0x225000000, size 0x1...

Milan Zamazal <mzamazal@redhat.com> writes: > Daniel P. Berrangé <berrange@redhat.com> writes: > >> On Thu, Jul 02, 2020 at 01:21:15PM +0200, Milan Zamazal wrote: >>> The second problem is that a VM fails to start with a backing NVDIMM in >>> devdax mode due to SELinux preventing access to the /dev/dax* device (it >>> doesn't happen with any other NVDIMM modes). Who should be responsible >>> for handling the SELinux label appropriately in that case? libvirt, the >>> system administrator,...

On Tue, 11 Jun 2019 22:07:57 +0530 Pankaj Gupta <pagupta at redhat.com> wrote: > This patch adds virtio-pmem driver for KVM guest. > > Guest reads the persistent memory range information from > Qemu over VIRTIO and registers it on nvdimm_bus. It also > creates a nd_region object with the persistent memory > range information so that existing 'nvdimm/pmem' driver > can reserve this into system memory map. This way > 'virtio-pmem' driver uses existing functionality of pmem > driver to register persisten...

On Tue, 11 Jun 2019 22:07:57 +0530 Pankaj Gupta <pagupta at redhat.com> wrote: > This patch adds virtio-pmem driver for KVM guest. > > Guest reads the persistent memory range information from > Qemu over VIRTIO and registers it on nvdimm_bus. It also > creates a nd_region object with the persistent memory > range information so that existing 'nvdimm/pmem' driver > can reserve this into system memory map. This way > 'virtio-pmem' driver uses existing functionality of pmem > driver to register persisten...

On Tue, Jun 16, 2020 at 12:54:29PM +0200, Milan Zamazal wrote: > Hi, > > I've found out that NVDIMM size and label size matter for regular > (non-NV) DIMM hot plug. If the NVDIMM is not aligned correctly, the > guest OS will not accept the hot plugged memory and will complain with > messages such as > > Block size [0x8000000] unaligned hotplug range: start 0x225000000, size 0x1...

Daniel P. Berrangé <berrange@redhat.com> writes: > On Thu, Jul 02, 2020 at 01:21:15PM +0200, Milan Zamazal wrote: >> Hi, >> > >> I've met two situations with NVDIMM support in libvirt where I'm not >> sure all the parties (libvirt & I) do the things correctly. >> >> The first problem is with memory alignment and size changes. In >> addition to the size changes applied to NVDIMMs by QEMU, libvirt also >> makes some NVDIMM...

...virtio_pmem driver requires this special flush function. For rest of the region types we are registering existing flush function. Report error returned by host fsync failure to userspace. Signed-off-by: Pankaj Gupta <pagupta at redhat.com> --- drivers/acpi/nfit/core.c | 4 ++-- drivers/nvdimm/claim.c | 6 ++++-- drivers/nvdimm/nd.h | 1 + drivers/nvdimm/pmem.c | 13 ++++++++----- drivers/nvdimm/region_devs.c | 26 ++++++++++++++++++++++++-- include/linux/libnvdimm.h | 8 +++++++- 6 files changed, 46 insertions(+), 12 deletions(-) diff --git a/drivers/acpi/nf...

Hi Dan, Proposing the patch series to be merged via nvdimm tree as kindly agreed by you. We have ack/review on XFS, EXT4 & VIRTIO patches. Incorporated all the changes suggested in v8. This version added a new patch 4 for dax for device mapper change and some minor style changes in patch 2. Kept all the reviews. Request to please merge the seri...

Daniel P. Berrangé <berrange@redhat.com> writes: > On Thu, Jul 02, 2020 at 01:21:15PM +0200, Milan Zamazal wrote: >> Hi, >> > >> I've met two situations with NVDIMM support in libvirt where I'm not >> sure all the parties (libvirt & I) do the things correctly. >> >> The first problem is with memory alignment and size changes. In >> addition to the size changes applied to NVDIMMs by QEMU, libvirt also >> makes some NVDIMM...

...know if these are okay and then will send official > v13 to for upstream merging. Looks good to me, except for one change. [Again sorry for the late review, did not want to get the version numbers up :)] > > Thanks, > Pankaj > > =============== > > diff --git a/drivers/nvdimm/nd_virtio.c b/drivers/nvdimm/nd_virtio.c > index efc535723517..5b8d2367da0b 100644 > --- a/drivers/nvdimm/nd_virtio.c > +++ b/drivers/nvdimm/nd_virtio.c > @@ -10,7 +10,7 @@ > #include "nd.h" > > /* The interrupt handler */ > -void host_ack(struct virtqueue *vq...

On Wed, 12 Jun 2019 18:15:22 +0530 Pankaj Gupta <pagupta at redhat.com> wrote: > This patch adds virtio-pmem driver for KVM guest. > > Guest reads the persistent memory range information from > Qemu over VIRTIO and registers it on nvdimm_bus. It also > creates a nd_region object with the persistent memory > range information so that existing 'nvdimm/pmem' driver > can reserve this into system memory map. This way > 'virtio-pmem' driver uses existing functionality of pmem > driver to register persisten...

This patch series is ready to be merged via nvdimm tree as discussed with Dan. We have ack/review on XFS, EXT4 device mapper & VIRTIO patches. This version has minor changes in patch 2. Keeping all the existing r-o-bs. Jakob CCed also tested the patch series and confirmed the working of v9. --- This patch series has implementation for...

...ion. Report error returned by host fsync failure to userspace. This also handles asynchronous flush requests from the block layer by creating a child bio and chaining it with parent bio. Signed-off-by: Pankaj Gupta <pagupta at redhat.com> --- drivers/acpi/nfit/core.c | 4 ++-- drivers/nvdimm/claim.c | 6 ++++-- drivers/nvdimm/nd.h | 1 + drivers/nvdimm/pmem.c | 14 ++++++++----- drivers/nvdimm/region_devs.c | 38 ++++++++++++++++++++++++++++++++++-- include/linux/libnvdimm.h | 8 +++++++- 6 files changed, 59 insertions(+), 12 deletions(-) diff --git a/drive...

On Thu, Jul 02, 2020 at 01:21:15PM +0200, Milan Zamazal wrote: > Hi, > > I've met two situations with NVDIMM support in libvirt where I'm not > sure all the parties (libvirt & I) do the things correctly. > > The first problem is with memory alignment and size changes. In > addition to the size changes applied to NVDIMMs by QEMU, libvirt also > makes some NVDIMM size changes for be...

Hi Michael & Dan, Please review/ack the patch series from LIBNVDIMM & VIRTIO side. We have ack on ext4, xfs patches(4, 5 & 6) patch 2. Still need your ack on nvdimm patches(1 & 3) & virtio patch 2. Changes done from v7 are only in patch(2 & 3) and not affecting existing reviews. Request to please review. ---- This patch series has imple...

Hi Michael & Dan, Please review/ack the patch series from LIBNVDIMM & VIRTIO side. We have ack on ext4, xfs patches(4, 5 & 6) patch 2. Still need your ack on nvdimm patches(1 & 3) & virtio patch 2. Changes done from v7 are only in patch(2 & 3) and not affecting existing reviews. Request to please review. ---- This patch series has imple...