search for: nvdimm_bus_unregist

...mp;ndr_desc); > + if (!nd_region) { > + dev_err(&vdev->dev, "failed to create nvdimm region\n"); > + err = -ENXIO; > + goto out_nd; > + } > + nd_region->provider_data = dev_to_virtio(nd_region->dev.parent->parent); > + return 0; > +out_nd: > + nvdimm_bus_unregister(vpmem->nvdimm_bus); > +out_vq: > + vdev->config->del_vqs(vdev); > +out_err: > + return err; > +} > + > +static void virtio_pmem_remove(struct virtio_device *vdev) > +{ > + struct nvdimm_bus *nvdimm_bus = dev_get_drvdata(&vdev->dev); > + > + nvdimm_...

...mp;ndr_desc); > + if (!nd_region) { > + dev_err(&vdev->dev, "failed to create nvdimm region\n"); > + err = -ENXIO; > + goto out_nd; > + } > + nd_region->provider_data = dev_to_virtio(nd_region->dev.parent->parent); > + return 0; > +out_nd: > + nvdimm_bus_unregister(vpmem->nvdimm_bus); > +out_vq: > + vdev->config->del_vqs(vdev); > +out_err: > + return err; > +} > + > +static void virtio_pmem_remove(struct virtio_device *vdev) > +{ > + struct nvdimm_bus *nvdimm_bus = dev_get_drvdata(&vdev->dev); > + > + nvdimm_...

...set ->provider_data to vdev directly? (Does it need to grab a reference count of the device, BTW?) > + > + if (!nd_region) > + goto out_nd; Probably better to do this check before you access nd_region's members :) > + > + return 0; > +out_nd: > + err = -ENXIO; > + nvdimm_bus_unregister(nvdimm_bus); > +out_vq: > + vdev->config->del_vqs(vdev); > +out_err: > + dev_err(&vdev->dev, "failed to register virtio pmem memory\n"); > + return err; > +} > + > +static void virtio_pmem_remove(struct virtio_device *vdev) > +{ > + struct virt...

...set ->provider_data to vdev directly? (Does it need to grab a reference count of the device, BTW?) > + > + if (!nd_region) > + goto out_nd; Probably better to do this check before you access nd_region's members :) > + > + return 0; > +out_nd: > + err = -ENXIO; > + nvdimm_bus_unregister(nvdimm_bus); > +out_vq: > + vdev->config->del_vqs(vdev); > +out_err: > + dev_err(&vdev->dev, "failed to register virtio pmem memory\n"); > + return err; > +} > + > +static void virtio_pmem_remove(struct virtio_device *vdev) > +{ > + struct virt...

...ion) { >> + dev_err(&vdev->dev, "failed to create nvdimm region\n"); >> + err = -ENXIO; >> + goto out_nd; >> + } >> + nd_region->provider_data = dev_to_virtio(nd_region->dev.parent->parent); >> + return 0; >> +out_nd: >> + nvdimm_bus_unregister(vpmem->nvdimm_bus); >> +out_vq: >> + vdev->config->del_vqs(vdev); >> +out_err: >> + return err; >> +} >> + >> +static void virtio_pmem_remove(struct virtio_device *vdev) >> +{ >> + struct nvdimm_bus *nvdimm_bus = dev_get_drvdata(&...

...gt; > + dev_err(&vdev->dev, "failed to create nvdimm region\n"); > > + err = -ENXIO; > > + goto out_nd; > > + } > > + nd_region->provider_data = dev_to_virtio(nd_region->dev.parent->parent); > > + return 0; > > +out_nd: > > + nvdimm_bus_unregister(vpmem->nvdimm_bus); > > +out_vq: > > + vdev->config->del_vqs(vdev); > > +out_err: > > + return err; > > +} > > + > > +static void virtio_pmem_remove(struct virtio_device *vdev) > > +{ > > + struct nvdimm_bus *nvdimm_bus = dev_get_drvd...

...;parent); Does it make sense to move some parts into separate functions for readability? E.g., virtio_pmem_init_nvdimm_bus() > + return 0; > +out_nd: > + err = -ENXIO; I'd always initialize "err" along with the goto statement for readability, especially because ... > + nvdimm_bus_unregister(vpmem->nvdimm_bus); > +out_vq: ... you don't initialize err in this case. Err is here 0 if I am not wrong. > + vdev->config->del_vqs(vdev); > +out_err: > + dev_err(&vdev->dev, "failed to register virtio pmem memory\n"); Should we try to give more meani...

...;parent); Does it make sense to move some parts into separate functions for readability? E.g., virtio_pmem_init_nvdimm_bus() > + return 0; > +out_nd: > + err = -ENXIO; I'd always initialize "err" along with the goto statement for readability, especially because ... > + nvdimm_bus_unregister(vpmem->nvdimm_bus); > +out_vq: ... you don't initialize err in this case. Err is here 0 if I am not wrong. > + vdev->config->del_vqs(vdev); > +out_err: > + dev_err(&vdev->dev, "failed to register virtio pmem memory\n"); Should we try to give more meani...

...> > > + if (!nd_region) > > > + goto out_nd; > > > > Probably better to do this check before you access nd_region's > > members :) > > > > > + > > > + return 0; > > > +out_nd: > > > + err = -ENXIO; > > > + nvdimm_bus_unregister(nvdimm_bus); > > > +out_vq: > > > + vdev->config->del_vqs(vdev); > > > +out_err: > > > + dev_err(&vdev->dev, "failed to register virtio pmem memory\n"); > > > + return err; > > > +} > > > + > > > +stati...

...reference count of the device, BTW?) > > > + > > + if (!nd_region) > > + goto out_nd; > > Probably better to do this check before you access nd_region's > members :) > > > + > > + return 0; > > +out_nd: > > + err = -ENXIO; > > + nvdimm_bus_unregister(nvdimm_bus); > > +out_vq: > > + vdev->config->del_vqs(vdev); > > +out_err: > > + dev_err(&vdev->dev, "failed to register virtio pmem memory\n"); > > + return err; > > +} > > + > > +static void virtio_pmem_remove(struct virtio_...

...ndr_desc); > + > + if (!nd_region) > + goto out_nd; > + nd_region->provider_data = dev_to_virtio > + (nd_region->dev.parent->parent); > + return 0; > +out_nd: > + err = -ENXIO; > + nvdimm_bus_unregister(vpmem->nvdimm_bus); > +out_vq: > + vdev->config->del_vqs(vdev); > +out_err: > + dev_err(&vdev->dev, "failed to register virtio pmem memory\n"); > + return err; > +} > + > +static void virtio_pmem_remove(struct virtio_device *vdev...

...ndr_desc); > + > + if (!nd_region) > + goto out_nd; > + nd_region->provider_data = dev_to_virtio > + (nd_region->dev.parent->parent); > + return 0; > +out_nd: > + err = -ENXIO; > + nvdimm_bus_unregister(vpmem->nvdimm_bus); > +out_vq: > + vdev->config->del_vqs(vdev); > +out_err: > + dev_err(&vdev->dev, "failed to register virtio pmem memory\n"); > + return err; > +} > + > +static void virtio_pmem_remove(struct virtio_device *vdev...

...goto out_nd; > > > + nd_region->provider_data = dev_to_virtio > > > + (nd_region->dev.parent->parent); > > > + return 0; > > > +out_nd: > > > + err = -ENXIO; > > > + nvdimm_bus_unregister(vpmem->nvdimm_bus); > > > +out_vq: > > > + vdev->config->del_vqs(vdev); > > > +out_err: > > > + dev_err(&vdev->dev, "failed to register virtio pmem memory\n"); > > > + return err; > > > +} > >...

...eate(nvdimm_bus, &ndr_desc); > + nd_region->provider_data = dev_to_virtio > + (nd_region->dev.parent->parent); > + > + if (!nd_region) > + goto out_nd; > + > + //virtio_device_ready(vdev); Left over > + return 0; > +out_nd: > + err = -ENXIO; > + nvdimm_bus_unregister(nvdimm_bus); > +out_vq: > + vdev->config->del_vqs(vdev); > +out_err: > + dev_err(&vdev->dev, "failed to register virtio pmem memory\n"); > + return err; > +} > + > +static void virtio_pmem_remove(struct virtio_device *vdev) > +{ > + struct virt...

...eate(nvdimm_bus, &ndr_desc); > + nd_region->provider_data = dev_to_virtio > + (nd_region->dev.parent->parent); > + > + if (!nd_region) > + goto out_nd; > + > + //virtio_device_ready(vdev); Left over > + return 0; > +out_nd: > + err = -ENXIO; > + nvdimm_bus_unregister(nvdimm_bus); > +out_vq: > + vdev->config->del_vqs(vdev); > +out_err: > + dev_err(&vdev->dev, "failed to register virtio pmem memory\n"); > + return err; > +} > + > +static void virtio_pmem_remove(struct virtio_device *vdev) > +{ > + struct virt...

...lloon.c: static void virtballoon_remove(struct virtio_device *vdev) { struct virtio_balloon *vb = vdev->priv; ... kfree(vb); } I think you should do the same here, vdev->priv is allocated in virtio_pmem_probe. But maybe I am missing something important here :) >> >>> + nvdimm_bus_unregister(nvdimm_bus); >>> + vdev->config->del_vqs(vdev); >>> + vdev->config->reset(vdev); >>> +} >>> + -- Thanks, David / dhildenb

...lloon.c: static void virtballoon_remove(struct virtio_device *vdev) { struct virtio_balloon *vb = vdev->priv; ... kfree(vb); } I think you should do the same here, vdev->priv is allocated in virtio_pmem_probe. But maybe I am missing something important here :) >> >>> + nvdimm_bus_unregister(nvdimm_bus); >>> + vdev->config->del_vqs(vdev); >>> + vdev->config->reset(vdev); >>> +} >>> + -- Thanks, David / dhildenb

...); > + > + if (!nd_region) > + goto out_nd; > + nd_region->provider_data = dev_to_virtio Delete extra space here ----------^^ I think this will let you join the two lines. > + (nd_region->dev.parent->parent); > + return 0; > +out_nd: > + err = -ENXIO; > + nvdimm_bus_unregister(vpmem->nvdimm_bus); > +out_vq: > + vdev->config->del_vqs(vdev); > +out_err: > + dev_err(&vdev->dev, "failed to register virtio pmem memory\n"); > + return err; > +} > + > +static void virtio_pmem_remove(struct virtio_device *vdev) > +{ > + s...

...;ndr_desc.flags); > + nd_region = nvdimm_pmem_region_create(vpmem->nvdimm_bus, &ndr_desc); > + > + if (!nd_region) > + goto out_nd; > + nd_region->provider_data = dev_to_virtio(nd_region->dev.parent->parent); > + return 0; > +out_nd: > + err = -ENXIO; > + nvdimm_bus_unregister(vpmem->nvdimm_bus); > +out_vq: > + vdev->config->del_vqs(vdev); > +out_err: > + dev_err(&vdev->dev, "failed to register virtio pmem memory\n"); > + return err; > +} > + > +static void virtio_pmem_remove(struct virtio_device *vdev) > +{ > + s...

...flags); > + nd_region = nvdimm_pmem_region_create(nvdimm_bus, &ndr_desc); > + nd_region->provider_data = dev_to_virtio > + (nd_region->dev.parent->parent); > + > + if (!nd_region) > + goto out_nd; > + > + return 0; > +out_nd: > + err = -ENXIO; > + nvdimm_bus_unregister(nvdimm_bus); > +out_vq: > + vdev->config->del_vqs(vdev); > +out_err: > + dev_err(&vdev->dev, "failed to register virtio pmem memory\n"); > + return err; > +} > + > +static void virtio_pmem_remove(struct virtio_device *vdev) > +{ > + struct virt...