search for: niptick

...Guestfs.guestfs () in > > (* Create a raw-format sparse disk image, 512 MB in size. *) > - let fd = openfile output [O_WRONLY;O_CREAT;O_TRUNC;O_NOCTTY] 0o666 in > - ftruncate fd (512 * 1024 * 1024); > - close fd; > + g#disk_create output "raw" 536870912L; Minor niptick: I'd leave the multiplication, as it was before and as the other examples do (easier to spot and to change). -- Pino Toscano

Don't use "default", choose a better default name if <Name> is not present in the OVF. Rich.

...ines); > + for (i = 0; i < nlines; i++) > + if (strstr(lines[i], "\tdevid")) > + nr_filesystem_show++; The logic here should match what is being done later, i.e. using STRPREFIX. > + guestfs_int_btrfsfsshow_list *ret = NULL; > + ret = malloc(sizeof *ret); Niptick: remember spaces between function name and bracket (also in other parts of this patch). > + if (ret == NULL) { > + reply_with_perror ("malloc"); > + return NULL; > + } > + > + /* No btrfs fs found, return directly */ > + if (nr_filesystem_show == 0) { >...

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com> --- daemon/btrfs.c | 176 +++++++++++++++++++++++++++++++++++++++++++++++++++ generator/actions.ml | 19 ++++++ generator/structs.ml | 13 ++++ src/MAX_PROC_NR | 2 +- 4 files changed, 209 insertions(+), 1 deletion(-) diff --git a/daemon/btrfs.c b/daemon/btrfs.c index 39392f7..09f7615 100644 --- a/daemon/btrfs.c +++

...; > + if (strstr(lines[i], "\tdevid")) > > + nr_filesystem_show++; > > The logic here should match what is being done later, i.e. using > STRPREFIX. > > > + guestfs_int_btrfsfsshow_list *ret = NULL; > > + ret = malloc(sizeof *ret); > > Niptick: remember spaces between function name and bracket (also in > other parts of this patch). > > > + if (ret == NULL) { > > + reply_with_perror ("malloc"); > > + return NULL; > > + } > > + > > + /* No btrfs fs found, return directly */ >...

This adds a customize option: virt-customize --ssh-inject USER[=KEY] virt-builder --ssh-inject USER[=KEY] virt-sysprep --ssh-inject USER[=KEY] In each case this either injects the current (host) user's ssh pubkey into the guest user USER (adding it to ~USER/.ssh/authorized_keys in the guest), or you can specify a particular key. For example: virt-builder fedora-20 --ssh-inject root

A lot of code runs 'qemu-img create' or 'truncate' to create blank disk images. In the past I resisted adding an API to do this, since it essentially duplicates what you can already do using other tools (ie. qemu-img). However this does simplify calling code quite a lot since qemu-img is somewhat error-prone to use (eg: don't try to create a disk called "foo:bar")