search for: neberg

> Oliver St?neberg wrote: > > > I finally got around to trying to update FLAC for the MAME/MESS > > project again. There were several issues I was able to fix and will > > submit patches later, but I hit one roadblock with GCC and clang: > > > > src/lib/libflac/libFLAC/stream_enco...

> Oliver St?neberg wrote: > > > Copying my report from sf.net: > > > > The source uses a mixture of "#ifdef HAVE_CONFIG_H" and "#if HAVE_CONFIG_H" > > checks. Judging from > > > > DEFS=-DHAVE_CONFIG_H > > > > in the configure I supposed it sho...

> Oliver St?neberg wrote: > > > This is simply fixed by putting those unused constants into the > > proper defines. I attached a patch against git 70b078c. > > Unfortunately it breaks x86_64 build (where FLAC__CPU_X86_64 is defined, and > FLAC__CPU_IA32 isn't). Maybe it's simpler to...

> Oliver St?neberg wrote: > > > > > > Oliver St?neberg wrote: > > > > > > > I finally got around to trying to update FLAC for the MAME/MESS > > > > project again. There were several issues I was able to fix and will > > > > submit patches later, but...

Copying my report from sf.net: The source uses a mixture of "#ifdef HAVE_CONFIG_H" and "#if HAVE_CONFIG_H" checks. Judging from DEFS=-DHAVE_CONFIG_H in the configure I supposed it should be "#ifdef" in all cases. These incorrect checks cause build errors since it tries to include the config.h on a custom configuration, that doesn't provide one. I can provide a

Oliver St?neberg wrote: > > > Oliver St?neberg wrote: > > > > > I finally got around to trying to update FLAC for the MAME/MESS > > > project again. There were several issues I was able to fix and will > > > submit patches later, but I hit one roadblock with GCC and cl...

Hi, after having some discussion of the FPU/SSE behavior on the sf.net bug tracker as well as having some other changes we made for the MAME/MESS project sitting around I thought about joining this list to make things easier. First one is the latest modification we had to make to compile with clang 3.4 x64. Here are the warnings the 1.2.1 source will give with it:

Hi, I finally got around to trying to update FLAC for the MAME/MESS project again. There were several issues I was able to fix and will submit patches later, but I hit one roadblock with GCC and clang: src/lib/libflac/libFLAC/stream_encoder.c:1696:43: error: cast from function call of type 'double' to non-matching type 'FLAC__int32' (aka 'int')

> I don't know, its your build system and I haven't seen it, nor do > I have the time and motivation to look at it (unless of course you > were paying me for my time). I willing give my time to maintain > FLAC. I have not signed up to spend my time on your project. And I am willing to looking at FLAC and spent my time to fix compiler warnings to make it more portable and

Oliver St?neberg wrote: >> Unfortunately it breaks x86_64 build (where FLAC__CPU_X86_64 is defined, and >> FLAC__CPU_IA32 isn't). Maybe it's simpler to turn them into #defines such as >> >> #define FLAC__CPUINFO_IA32_CPUID_CMOV 0x00008000U >> #define FLAC__CPUINFO_IA...

Oliver St?neberg wrote: > I finally got around to trying to update FLAC for the MAME/MESS > project again. There were several issues I was able to fix and will > submit patches later, but I hit one roadblock with GCC and clang: > > src/lib/libflac/libFLAC/stream_encoder.c:1696:43: error: cast fro...

Oliver St?neberg wrote: > Sorry...overlooked that. > > Yes, it is a custom build system, but what does have to do with the > code causing a warning with GCC/clang, that is enabled by default? I don't know, its your build system and I haven't seen it, nor do I have the time and motivation to...