search for: msg00253

When we introduced valid_flags, there was an incentive to do as few callbacks as possible, favoring cb(VALID|FREE) calls over the sequence cb(VALID);cb(FREE). To make it work, we set .callback=NULL after an early free, so that the later check during retirement didn't free again. But now that our .free callback is distinct from our other callbacks, there is no longer an advantage to bundling

...he ‘test-ipv4.sh’ test. Instead of merely connecting to the server using socat, use ‘qemu-img info’ so that the test is slightly more realistic. Also clean up old PID and log files before starting the test. Previous version was posted here: https://www.redhat.com/archives/libguestfs/2018-January/msg00253.html Rich.

...asically reverts 9c8fccdf (which had slightly-questionable C > type-punning anyway) and 57150880. I didn't see this one before implementing an alternate version here: https://www.redhat.com/archives/libguestfs/2019-August/msg00251.html https://www.redhat.com/archives/libguestfs/2019-August/msg00253.html They're fairly similar, but I didn't get rid of the FREE_CALLBACK macro for reasons which are clearer later in the series. Rich. > --- > lib/internal.h | 14 -------------- > generator/states-reply-simple.c | 1 - > generator/states-reply-struc...

On Thu, Oct 10, 2019 at 03:33:25PM +0100, Richard W.M. Jones wrote: >On Wed, Oct 09, 2019 at 02:19:46PM +0200, Martin Kletzander wrote: >> Even though this option is not to be used according to the manual, it: >> >> a) still might be useful even for machine-readable logs >> >> b) should not break the machine-readable output > >I'm a bit confused what