search for: movablecor

...e this much more efficient by not checking every >>>> - * page in the range if we know all of them are in MOVABLE_ZONE and >>>> - * that the movable zone guarantees that pages are migratable but >>>> - * the later is not the case right now unfortunatelly. E.g. movablecore >>>> - * can still lead to having bootmem allocations in zone_movable. >>>> - */ >>>> - >>>> if (is_migrate_cma_page(page)) { >>>> /* >>>> * CMA allocations (alloc_contig_range) really need to mark >>>>...

...; - * TODO we could make this much more efficient by not checking every >> - * page in the range if we know all of them are in MOVABLE_ZONE and >> - * that the movable zone guarantees that pages are migratable but >> - * the later is not the case right now unfortunatelly. E.g. movablecore >> - * can still lead to having bootmem allocations in zone_movable. >> - */ >> - >> if (is_migrate_cma_page(page)) { >> /* >> * CMA allocations (alloc_contig_range) really need to mark >> @@ -8233,6 +8225,12 @@ struct page *has_unmovable_pages(...

Currently, virtio-mem does not really support ZONE_MOVABLE. While it allows to online fully plugged memory blocks to ZONE_MOVABLE, it does not allow to online partially-plugged memory blocks to ZONE_MOVABLE and will never consider such memory blocks when unplugging memory. This might be surprising for users (especially, if onlining suddenly fails). Let's support partially plugged memory

Currently, virtio-mem does not really support ZONE_MOVABLE. While it allows to online fully plugged memory blocks to ZONE_MOVABLE, it does not allow to online partially-plugged memory blocks to ZONE_MOVABLE and will never consider such memory blocks when unplugging memory. This might be surprising for users (especially, if onlining suddenly fails). Let's support partially plugged memory

...quot; as I was messing up things while reshuffling patches (dump_page(NULL) could never happen, only the WARN_ON_ONCE()) -- Clarify in the description that this is currently a cleanup only - "mm: document semantics of ZONE_MOVABLE" -- Clarified in the memory hole case, that kernelcore/movablecore is required to create such rare special cases v3 -> v4: - "mm/page_isolation: drop WARN_ON_ONCE() in set_migratetype_isolate()" -- Fix typo in description - "virtio-mem: don't special-case ZONE_MOVABLE" -- Add more details why we initialli special-cased ZONE_MOVABLE...

...quot; as I was messing up things while reshuffling patches (dump_page(NULL) could never happen, only the WARN_ON_ONCE()) -- Clarify in the description that this is currently a cleanup only - "mm: document semantics of ZONE_MOVABLE" -- Clarified in the memory hole case, that kernelcore/movablecore is required to create such rare special cases v3 -> v4: - "mm/page_isolation: drop WARN_ON_ONCE() in set_migratetype_isolate()" -- Fix typo in description - "virtio-mem: don't special-case ZONE_MOVABLE" -- Add more details why we initialli special-cased ZONE_MOVABLE...

@Andrew can we give this a churn and consider it for v5.9 in case there are no more comments? Patch #1-#4 have RB's, patch #5 is virtio-mem stuff maintained by me, patch #6 is just a doc update. --- Currently, virtio-mem does not really support ZONE_MOVABLE. While it allows to online fully plugged memory blocks to ZONE_MOVABLE, it does not allow to online partially-plugged memory blocks to

@Andrew can we give this a churn and consider it for v5.9 in case there are no more comments? Patch #1-#4 have RB's, patch #5 is virtio-mem stuff maintained by me, patch #6 is just a doc update. --- Currently, virtio-mem does not really support ZONE_MOVABLE. While it allows to online fully plugged memory blocks to ZONE_MOVABLE, it does not allow to online partially-plugged memory blocks to

@Andrew can we give this a churn and consider it for v5.9 in case there are no more comments? Patch #1-#4,#6 have RBss or ACKs, patch #5 is virtio-mem stuff maintained by me (and MST is aware). --- When introducing virtio-mem, the semantics of ZONE_MOVABLE were rather unclear, which is why we special-cased ZONE_MOVABLE such that partially plugged blocks would never end up in ZONE_MOVABLE. Now

@Andrew can we give this a churn and consider it for v5.9 in case there are no more comments? Patch #1-#4,#6 have RBss or ACKs, patch #5 is virtio-mem stuff maintained by me (and MST is aware). --- When introducing virtio-mem, the semantics of ZONE_MOVABLE were rather unclear, which is why we special-cased ZONE_MOVABLE such that partially plugged blocks would never end up in ZONE_MOVABLE. Now

@Andrew, @Mst, I suggest the whole series (including the virtio-mem change) goes via the -mm tree. Currently, virtio-mem does not really support ZONE_MOVABLE. While it allows to online fully plugged memory blocks to ZONE_MOVABLE, it does not allow to online partially-plugged memory blocks to ZONE_MOVABLE and will never consider such memory blocks when unplugging memory. This might be surprising

On 29.07.20 15:24, Baoquan He wrote: > On 06/30/20 at 04:26pm, David Hildenbrand wrote: >> Inside has_unmovable_pages(), we have a comment describing how unmovable >> data could end up in ZONE_MOVABLE - via "movable_core". Also, besides > ~~~ 'movablecore' >> checking if the first page in the pageblock is reserved, we don't >> perform any further checks in case of ZONE_MOVABLE. >> >> In case of memory offlining, we set REPORT_FAILURE, properly >> dump_page() the page and handle the error gracefully. >> al...

...ed pages: (Long-term) pinning of movable pages might > > ^long, capital L looked out of place for me Ack! > >> + * essentially turn such pages unmovable. Memory offlining might >> + * retry a long time. >> + * 2. memblock allocations: kernelcore/movablecore setups might create >> + * situations where ZONE_MOVABLE contains unmovable allocations >> + * after boot. Memory offlining and allocations fail early. >> + * 3. Memory holes: Such pages cannot be allocated. Applies only to >> + * boot memory, not hotplugged me...

...gt;> ^long, capital L looked out of place for me >> >> Ack! >> >>> >>>> + * essentially turn such pages unmovable. Memory offlining might >>>> + * retry a long time. >>>> + * 2. memblock allocations: kernelcore/movablecore setups might create >>>> + * situations where ZONE_MOVABLE contains unmovable allocations >>>> + * after boot. Memory offlining and allocations fail early. >>>> + * 3. Memory holes: Such pages cannot be allocated. Applies only to >>>> + *...

The original goal of this patchset is to fix the bug reported by https://bugzilla.kernel.org/show_bug.cgi?id=53501 Now it has also been expanded to reduce common code used by memory initializion. This is the first part, which applies to v3.9-rc1. It introduces following common helper functions to simplify free_initmem() and free_initrd_mem() on different architectures:

The original goal of this patchset is to fix the bug reported by https://bugzilla.kernel.org/show_bug.cgi?id=53501 Now it has also been expanded to reduce common code used by memory initializion. This is the first part, which applies to v3.9-rc1. It introduces following common helper functions to simplify free_initmem() and free_initrd_mem() on different architectures:

.../Documentation/memory-hotplug.txt +++ b/Documentation/memory-hotplug.txt @@ -324,7 +324,7 @@ guarantee that the memory block contains only migratable pages. Now, a boot option for making a memory block which consists of migratable pages is supported. By specifying "kernelcore=" or "movablecore=" boot option, you can create ZONE_MOVABLE...a zone which is just used for movable pages. -(See also Documentation/kernel-parameters.txt) +(See also Documentation/admin-guide/kernel-parameters.rst) Assume the system has "TOTAL" amount of memory at boot time, this boot option cr...

.../Documentation/memory-hotplug.txt +++ b/Documentation/memory-hotplug.txt @@ -324,7 +324,7 @@ guarantee that the memory block contains only migratable pages. Now, a boot option for making a memory block which consists of migratable pages is supported. By specifying "kernelcore=" or "movablecore=" boot option, you can create ZONE_MOVABLE...a zone which is just used for movable pages. -(See also Documentation/kernel-parameters.txt) +(See also Documentation/admin-guide/kernel-parameters.rst) Assume the system has "TOTAL" amount of memory at boot time, this boot option cr...

.../Documentation/memory-hotplug.txt +++ b/Documentation/memory-hotplug.txt @@ -324,7 +324,7 @@ guarantee that the memory block contains only migratable pages. Now, a boot option for making a memory block which consists of migratable pages is supported. By specifying "kernelcore=" or "movablecore=" boot option, you can create ZONE_MOVABLE...a zone which is just used for movable pages. -(See also Documentation/kernel-parameters.txt) +(See also Documentation/admin-guide/kernel-parameters.rst) Assume the system has "TOTAL" amount of memory at boot time, this boot option cr...

.../Documentation/memory-hotplug.txt +++ b/Documentation/memory-hotplug.txt @@ -324,7 +324,7 @@ guarantee that the memory block contains only migratable pages. Now, a boot option for making a memory block which consists of migratable pages is supported. By specifying "kernelcore=" or "movablecore=" boot option, you can create ZONE_MOVABLE...a zone which is just used for movable pages. -(See also Documentation/kernel-parameters.txt) +(See also Documentation/admin-guide/kernel-parameters.rst) Assume the system has "TOTAL" amount of memory at boot time, this boot option cr...