Jiang Liu
2013-Mar-10 06:26 UTC
[PATCH v2, part1 00/29] Use helper functions to simplify memory intialization code
The original goal of this patchset is to fix the bug reported by
https://bugzilla.kernel.org/show_bug.cgi?id=53501
Now it has also been expanded to reduce common code used by memory
initializion.
This is the first part, which applies to v3.9-rc1.
It introduces following common helper functions to simplify
free_initmem() and free_initrd_mem() on different architectures:
adjust_managed_page_count():
will be used to adjust totalram_pages, totalhigh_pages,
zone->managed_pages when reserving/unresering a page.
__free_reserved_page():
free a reserved page into the buddy system without adjusting
page statistics info
free_reserved_page():
free a reserved page into the buddy system and adjust page
statistics info
mark_page_reserved():
mark a page as reserved and adjust page statistics info
free_reserved_area():
free a continous ranges of pages by calling free_reserved_page()
free_initmem_default():
default method to free __init pages.
We have only tested these patchset on x86 platforms, and have done basic
compliation tests using cross-compilers from ftp.kernel.org. That means
some code may not pass compilation on some architectures. So any help
to test this patchset are welcomed!
There are several other parts still under development:
Part2: introduce free_highmem_page() to simplify freeing highmem pages
Part3: refine code to manage totalram_pages, totalhigh_pages and
zone->managed_pages
Part4: introduce helper functions to simplify mem_init() and remove the
global variable num_physpages.
Jiang Liu (29):
mm: introduce common help functions to deal with reserved/managed
pages
mm/alpha: use common help functions to free reserved pages
mm/ARM: use common help functions to free reserved pages
mm/avr32: use common help functions to free reserved pages
mm/blackfin: use common help functions to free reserved pages
mm/c6x: use common help functions to free reserved pages
mm/cris: use common help functions to free reserved pages
mm/FRV: use common help functions to free reserved pages
mm/h8300: use common help functions to free reserved pages
mm/IA64: use common help functions to free reserved pages
mm/m32r: use common help functions to free reserved pages
mm/m68k: use common help functions to free reserved pages
mm/microblaze: use common help functions to free reserved pages
mm/MIPS: use common help functions to free reserved pages
mm/mn10300: use common help functions to free reserved pages
mm/openrisc: use common help functions to free reserved pages
mm/parisc: use common help functions to free reserved pages
mm/ppc: use common help functions to free reserved pages
mm/s390: use common help functions to free reserved pages
mm/score: use common help functions to free reserved pages
mm/SH: use common help functions to free reserved pages
mm/SPARC: use common help functions to free reserved pages
mm/um: use common help functions to free reserved pages
mm/unicore32: use common help functions to free reserved pages
mm/x86: use common help functions to free reserved pages
mm/xtensa: use common help functions to free reserved pages
mm/arc: use common help functions to free reserved pages
mm/metag: use common help functions to free reserved pages
mm,kexec: use common help functions to free reserved pages
arch/alpha/kernel/sys_nautilus.c | 5 ++-
arch/alpha/mm/init.c | 24 ++-----------
arch/alpha/mm/numa.c | 3 +-
arch/arc/mm/init.c | 23 ++----------
arch/arm/mm/init.c | 48 +++++++++-----------------
arch/arm64/mm/init.c | 26 ++------------
arch/avr32/mm/init.c | 24 ++-----------
arch/blackfin/mm/init.c | 22 ++----------
arch/c6x/mm/init.c | 30 ++--------------
arch/cris/mm/init.c | 16 ++-------
arch/frv/mm/init.c | 34 +++---------------
arch/h8300/mm/init.c | 30 ++--------------
arch/ia64/mm/init.c | 23 +++---------
arch/m32r/mm/init.c | 26 ++------------
arch/m68k/mm/init.c | 24 ++-----------
arch/metag/mm/init.c | 21 ++---------
arch/microblaze/include/asm/setup.h | 1 -
arch/microblaze/mm/init.c | 28 ++-------------
arch/mips/mm/init.c | 31 +++++------------
arch/mips/sgi-ip27/ip27-memory.c | 4 +--
arch/mn10300/mm/init.c | 23 ++----------
arch/openrisc/mm/init.c | 27 ++-------------
arch/parisc/mm/init.c | 23 ++----------
arch/powerpc/kernel/crash_dump.c | 5 +--
arch/powerpc/kernel/fadump.c | 5 +--
arch/powerpc/kernel/kvm.c | 7 +---
arch/powerpc/mm/mem.c | 29 ++--------------
arch/powerpc/platforms/512x/mpc512x_shared.c | 5 +--
arch/s390/mm/init.c | 35 ++++---------------
arch/score/mm/init.c | 33 +++---------------
arch/sh/mm/init.c | 26 ++------------
arch/sparc/kernel/leon_smp.c | 15 ++------
arch/sparc/mm/init_32.c | 37 ++------------------
arch/sparc/mm/init_64.c | 26 +++-----------
arch/um/kernel/mem.c | 10 +-----
arch/unicore32/mm/init.c | 28 ++-------------
arch/x86/mm/init.c | 5 +--
arch/x86/mm/init_64.c | 5 ++-
arch/xtensa/mm/init.c | 21 ++---------
include/linux/mm.h | 48 ++++++++++++++++++++++++++
kernel/kexec.c | 8 ++---
mm/page_alloc.c | 20 +++++++++++
42 files changed, 184 insertions(+), 700 deletions(-)
--
1.7.9.5
Jiang Liu
2013-Mar-10 06:26 UTC
[PATCH v2, part1 01/29] mm: introduce common help functions to deal with reserved/managed pages
Code to deal with reserved/managed pages are duplicated by many
architectures, so introduce common help functions to reduce duplicated
code. These common help functions will also be used to concentrate code
to modify totalram_pages and zone->managed_pages, which makes the code
much more clear.
Signed-off-by: Jiang Liu <jiang.liu at huawei.com>
---
include/linux/mm.h | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
mm/page_alloc.c | 20 ++++++++++++++++++++
2 files changed, 68 insertions(+)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 7acc9dc..d75c14b 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -1295,6 +1295,54 @@ extern void free_area_init_node(int nid, unsigned long *
zones_size,
unsigned long zone_start_pfn, unsigned long *zholes_size);
extern void free_initmem(void);
+/*
+ * Free reserved pages within range [PAGE_ALIGN(start), end & PAGE_MASK)
+ * into the buddy system. The freed pages will be poisoned with pattern
+ * "poison" if it's non-zero.
+ * Return pages freed into the buddy system.
+ */
+extern unsigned long free_reserved_area(unsigned long start, unsigned long end,
+ int poison, char *s);
+
+static inline void adjust_managed_page_count(struct page *page, long count)
+{
+ totalram_pages += count;
+}
+
+/* Free the reserved page into the buddy system, so it gets managed. */
+static inline void __free_reserved_page(struct page *page)
+{
+ ClearPageReserved(page);
+ init_page_count(page);
+ __free_page(page);
+}
+
+static inline void free_reserved_page(struct page *page)
+{
+ __free_reserved_page(page);
+ adjust_managed_page_count(page, 1);
+}
+
+static inline void mark_page_reserved(struct page *page)
+{
+ SetPageReserved(page);
+ adjust_managed_page_count(page, -1);
+}
+
+/*
+ * Default method to free all the __init memory into the buddy system.
+ * The freed pages will be poisoned with pattern "poison" if it is
+ * non-zero. Return pages freed into the buddy system.
+ */
+static inline unsigned long free_initmem_default(int poison)
+{
+ extern char __init_begin[], __init_end[];
+
+ return free_reserved_area(PAGE_ALIGN((unsigned long)&__init_begin) ,
+ ((unsigned long)&__init_end) & PAGE_MASK,
+ poison, "unused kernel");
+}
+
#ifdef CONFIG_HAVE_MEMBLOCK_NODE_MAP
/*
* With CONFIG_HAVE_MEMBLOCK_NODE_MAP set, an architecture may initialise its
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 8fcced7..0fadb09 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5113,6 +5113,26 @@ early_param("movablecore",
cmdline_parse_movablecore);
#endif /* CONFIG_HAVE_MEMBLOCK_NODE_MAP */
+unsigned long free_reserved_area(unsigned long start, unsigned long end,
+ int poison, char *s)
+{
+ unsigned long pages, pos;
+
+ pos = start = PAGE_ALIGN(start);
+ end &= PAGE_MASK;
+ for (pages = 0; pos < end; pos += PAGE_SIZE, pages++) {
+ if (poison)
+ memset((void *)pos, poison, PAGE_SIZE);
+ free_reserved_page(virt_to_page(pos));
+ }
+
+ if (pages && s)
+ pr_info("Freeing %s memory: %ldK (%lx - %lx)\n",
+ s, pages << (PAGE_SHIFT - 10), start, end);
+
+ return pages;
+}
+
/**
* set_dma_reserve - set the specified number of pages reserved in the first
zone
* @new_dma_reserve: The number of pages to mark reserved
--
1.7.9.5
Reasonably Related Threads
- [PATCH v2, part1 00/29] Use helper functions to simplify memory intialization code
- [PATCH v8, part3 12/14] mm: correctly update zone->mamaged_pages
- [PATCH v8, part3 12/14] mm: correctly update zone->mamaged_pages
- [PATCH v8, part3 12/14] mm: correctly update zone->mamaged_pages
- [PATCH v6, part3 13/16] mm: correctly update zone->mamaged_pages