search for: mlv2v

While there is only one OCaml source, build it as small library: this way it is easier to use, and there is no need to copy the sources from here. --- .gitignore | 1 + mlv2v/Makefile.am | 71 ++++++++++++++++++++++++++++++++++++++++++++--- mlv2v/dummy.c | 2 ++ 3 files changed, 70 insertions(+), 4 deletions(-) create mode 100644 mlv2v/dummy.c diff --git a/.gitignore b/.gitignore index 88c1c63..a788c55 100644 --- a/.gitignore +++ b/.gitignore @@ -60,6 +60,7 @@ Ma...

...irt-v2v, with additional fixes for the builddir!=srcdir case. This will also need the fix to subdir-rules.mk. [1] https://www.redhat.com/archives/libguestfs/2019-December/msg00062.html Pino Toscano (7): Update common to latest build: stop shipping files generated by configure build: use the mlv2v library build: do not ship generated sources build: drop HAVE_OCAML conditionals build: actually require libvirt build: hopefully fix dependencies on generated files .gitignore | 2 -- common | 2 +- m4/guestfs-libraries.m4 | 22 ++------------------- oc...

...f --git a/Makefile.am b/Makefile.am index 1def6e0a3..d3cf64cc1 100644 --- a/Makefile.am +++ b/Makefile.am @@ -580,6 +580,7 @@ maintainer-check-extra-dist: ( git ls-files ; \ cd common; git ls-files | sed 's,^,common/,' ) | \ grep -v '^common$$' | \ + grep -v '^common/mlv2v/' | \ grep -v '^intltool-.*\.in' | \ grep -v '^\.gitmodules' | \ grep -v '^\.gnulib' | \ @@ -589,7 +590,7 @@ maintainer-check-extra-dist: cat tmp/comm-out [ ! -s tmp/comm-out ] @echo Checking for generated files missing from the tarball ... - @for f in...

*** BLURB HERE? *** Pino Toscano (4): build: stop shipping files generated by configure docs: fix out-of-source documentation build generator: do not generate mlv2v files when not needed perl: fix path to Build.PL docs/Makefile.am | 4 ++-- generator/main.ml | 11 +++++++---- perl/Makefile.am | 2 +- python/Makefile.am | 3 ++- tests/daemon/Makefile.am | 1 - 5 files changed, 12 insertions(+), 9 deletions(-) -- 2.23.0

*** BLURB HERE? *** Pino Toscano (6): build: stop shipping files generated by configure docs: fix out-of-source documentation build generator: do not generate mlv2v files when not needed perl: fix path to Build.PL rust: fix path to lib.rs rust: fix list of generator-built files daemon/Makefile.am | 8 ++++++-- docs/Makefile.am | 4 ++-- generator/main.ml | 11 +++++++---- perl/Makefile.am | 2 +- python/Makefile.am...

...š Golembiovský <tgolembi@redhat.com> --- v2v/Makefile.am | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/v2v/Makefile.am b/v2v/Makefile.am index 64703c36..1c10d07b 100644 --- a/v2v/Makefile.am +++ b/v2v/Makefile.am @@ -248,9 +248,9 @@ OCAMLLINKFLAGS = \ mlv2v.$(MLARCHIVE) \ $(LINK_CUSTOM_OCAMLC_ONLY) -virt_v2v_DEPENDENCIES = $(OBJECTS) $(top_srcdir)/ocaml-link.sh +virt_v2v_DEPENDENCIES = $(OBJECTS) $(top_builddir)/ocaml-link.sh virt_v2v_LINK = \ - $(top_srcdir)/ocaml-link.sh -cclib '$(OCAMLCLIBS)' -- \ + $(top_builddir)/ocaml-link.sh -cclib...

Building virt-v2v out-of-tree does not work and requires several small fixes here and there. Tomáš Golembiovský (3): build: perform gnulib check from source directory build: run ocaml-link.sh from build directory docs: don't perform lookup on absolute paths cfg.mk | 1 + podwrapper.pl.in | 2 ++ v2v/Makefile.am | 16 ++++++++-------- 3 files changed, 11 insertions(+), 8

...autom4te.cache/ > /build-aux/ > diff --git a/Makefile.am b/Makefile.am > index 039921c2..72b78769 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -41,7 +41,7 @@ SUBDIRS += common/mlxml > SUBDIRS += common/mltools > SUBDIRS += common/mlcustomize > SUBDIRS += common/mlv2v > -SUBDIRS += common/mllibvirt > +SUBDIRS += 3rdparty/libvirt-ocaml It's bikeshedding but how about calling it "bundled"? Anyway, ACK series, and also the patch to remove from common. Rich. > SUBDIRS += v2v > SUBDIRS += test-harness > > diff --git a/configure...

...irt-ocaml/libvirt_generated.c /aclocal.m4 /autom4te.cache/ /build-aux/ diff --git a/Makefile.am b/Makefile.am index 039921c2..72b78769 100644 --- a/Makefile.am +++ b/Makefile.am @@ -41,7 +41,7 @@ SUBDIRS += common/mlxml SUBDIRS += common/mltools SUBDIRS += common/mlcustomize SUBDIRS += common/mlv2v -SUBDIRS += common/mllibvirt +SUBDIRS += 3rdparty/libvirt-ocaml SUBDIRS += v2v SUBDIRS += test-harness diff --git a/configure.ac b/configure.ac index 065c6289..00246f29 100644 --- a/configure.ac +++ b/configure.ac @@ -100,11 +100,11 @@ AC_CONFIG_FILES([run], dnl NB: Remove common/mlstdutils/...

...quired file 'common/mlcustomize/Makefile.in' not found configure.ac:221: error: required file 'common/mllibvirt/Makefile.in' not found configure.ac:221: error: required file 'common/mlstdutils/guestfs_config.ml.in' not found configure.ac:221: error: required file 'common/mlv2v/Makefile.in' not found Makefile.am:161: error: required directory ./common/mlcustomize does not exist Makefile.am:161: error: required directory ./common/mlv2v does not exist Makefile.am:169: error: required directory ./common/mllibvirt does not exist parallel-tests: installing 'build-aux/t...

Do not build the mlv2v, and mllibvirt submodules, as they are not used. --- Makefile.am | 4 ---- configure.ac | 2 -- 2 files changed, 6 deletions(-) diff --git a/Makefile.am b/Makefile.am index 28f542765..b1e88a42b 100644 --- a/Makefile.am +++ b/Makefile.am @@ -164,10 +164,6 @@ SUBDIRS += common/mlvisit SUBDIRS +=...

I got a little way into this. The two attached patches are preliminary work. My proposed split is: libguestfs.git common -> git submodule libguestfs-common.git generator/ lib/ all language bindings C based tools (eg. virt-df, virt-edit, guestfish) guestfs-tools.git common -> git submodule libguestfs-common.git

This is an extended version of: https://www.redhat.com/archives/libguestfs/2019-September/msg00288.html Apparently I forgot it on my tree, so I'm posting that series again, adding an extra cleanup more due to the v2v/common splits. Pino Toscano (6): tests: switch away from xgetcwd daemon: move read_whole_file to common utils daemon: switch from read_file to read_whole_file daemon:

...common/mltools/registry.ml -common/mltools/tools_messages_tests.ml common/mltools/tools_utils.ml -common/mltools/tools_utils_tests.ml common/mltools/urandom.ml common/mltools/xpath_helpers.ml common/mlutils/c_utils.ml -common/mlutils/c_utils_unit_tests.ml common/mlutils/unix_utils.ml common/mlv2v/uefi.ml common/mlxml/xml.ml @@ -86,9 +77,7 @@ v2v/target_bus_assignment.ml v2v/types.ml v2v/utils.ml v2v/v2v.ml -v2v/v2v_unit_tests.ml v2v/vCenter.ml v2v/var_expander.ml -v2v/var_expander_tests.ml v2v/windows.ml v2v/windows_virtio.ml -- 2.24.1

...ools/tools_messages_tests.ml > common/mltools/tools_utils.ml > -common/mltools/tools_utils_tests.ml > common/mltools/urandom.ml > common/mltools/xpath_helpers.ml > common/mlutils/c_utils.ml > -common/mlutils/c_utils_unit_tests.ml > common/mlutils/unix_utils.ml > common/mlv2v/uefi.ml > common/mlxml/xml.ml > @@ -86,9 +77,7 @@ v2v/target_bus_assignment.ml > v2v/types.ml > v2v/utils.ml > v2v/v2v.ml > -v2v/v2v_unit_tests.ml > v2v/vCenter.ml > v2v/var_expander.ml > -v2v/var_expander_tests.ml > v2v/windows.ml > v2v/windows_virtio.ml I...

...common/mltools/registry.ml -common/mltools/tools_messages_tests.ml common/mltools/tools_utils.ml -common/mltools/tools_utils_tests.ml common/mltools/urandom.ml common/mltools/xpath_helpers.ml common/mlutils/c_utils.ml -common/mlutils/c_utils_unit_tests.ml common/mlutils/unix_utils.ml common/mlv2v/uefi.ml common/mlvisit/visit.ml -common/mlvisit/visit_tests.ml common/mlxml/xml.ml customize/append_line.ml customize/crypt.ml -- 2.24.1

Fix one dist issue, and various builddir!=srcdir issues, also with the patch proposed in the Debian bug #946594. Patch #3 applies also to the virt-v2v repository, and will be committed there too (with references to the libguestfs commit). Pino Toscano (3): inspector: ship the actual test script tests: fix srcdir references build: fix make implicit dependencies on ml/mli files

libvirt-ocaml is used only by virt-v2v, so move it to this repository, instead of having it around in the common submodule. The removal from common will happen later. Pino Toscano (2): common: Bundle the libvirt-ocaml library for use by virt-v2v build: switch embedded copy of libvirt-ocaml .gitignore | 2 + 3rdparty/libvirt-ocaml/Makefile.am |