search for: missingvalu

Applied as r78477. I do have a few comments on the patch, below, but I'll wait to see where things are going before acting on them. :) -- > Index: include/llvm/Analysis/ProfileInfo.h > =================================================================== > + // MissingValue - The value that is returned for execution counts in case > + // no value is available. > + static const int MissingValue = -1; This should be a double? > + // getFunction() - Returns the Function for an Edge, checking for validity. > + static const Function* getFunction(...

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Daniel Dunbar wrote: > Thanks, applied as r78247. Next? :) Oh my, first he is lagging and now it's all a hurry :-) Okay, here comes the next one. I'm taking a short vacation next week so I will try to prepare 1 or 2 of the next patches so that you can work on them as you have time. Greetings, Andi - --

...t; I do have a few comments on the patch, below, but I'll wait to see > where things are going before acting on them. :) > > -- > >> Index: include/llvm/Analysis/ProfileInfo.h >> =================================================================== > >> + // MissingValue - The value that is returned for execution counts in case >> + // no value is available. >> + static const int MissingValue = -1; > > This should be a double? Yes it should be. Since C++ (for some reason I can not fathom) does not allow to use a static const float this wa...

...nu99 -c 42A-3RegressionModelling.c -o 42A-3RegressionModelling.o g77 -fpic -g -O2 -c 42B-RegressionTests.f -o 42B-RegressionTests.o g77 -fpic -g -O2 -c 46A-VectorMatrixAddon.f -o 46A-VectorMatrixAddon.o gcc -I/usr/share/R/include -I/usr/share/R/include -fpic -g -O2 -std=gnu99 -c 46B-MissingValues.c -o 46B-MissingValues.og77 -fpic -g -O2 -c 47B-MultivariateDistribution.f -o 47B-MultivariateDistribution.o gcc -I/usr/share/R/include -I/usr/share/R/include -fpic -g -O2 -std=gnu99 -c runfunc.c -o runfunc.o gcc -shared -o fMultivar.so 00A-randomF77.o 00B-GarchBEKK.o 42A-1Reggress...

...e that the important changes which are worth reflecting in the API are >> changed the weights to return a double instead of an int, and defining -1 as a >> sentinel, "don't know", value. > So you want the ProfileInfo to be untouched except for the double weights and the MissingValue? Then mark all methods virtual and do a subclass that has this sort of heavy implementation that I am using? Exactly. > Do you have any name suggestions for this subclass? Not really. As with other interfaces, the actual implementation will be completely hidden, so the only public part of th...

...I > believe that the important changes which are worth reflecting in the API are > changed the weights to return a double instead of an int, and defining -1 as a > sentinel, "don't know", value. So you want the ProfileInfo to be untouched except for the double weights and the MissingValue? Then mark all methods virtual and do a subclass that has this sort of heavy implementation that I am using? Do you have any name suggestions for this subclass? One thing I would like to patch in the current ProfileInfo implementation is the consistent use of the (0,entry) edge which is necessary...

Dear R helpers, I have a data frame where missing values for numeric variables are coded as 999. I want to recode those as NAs. The following only partially succeeds because numeric variables are converted to character in the process: df <- data.frame(a=c(999,1,999,2), b=LETTERS[1:4]) is.na(df[2,1]) <- TRUE df a b 1 999 A 2 NA B 3 999 C 4 2 D is.numeric(df$a) [1] TRUE

Hi Andreas, First, thanks again for undertaking this work and submitting it back. There is a lot of good stuff here and it would be great to see it get back into the tree. I have a few major high-level comments on the patch. First off, the patch is quite large and should be broken down into separate incremental changes which are easier to review and apply. I think the patches should more or less

Hi all, as proposed in http://lists.cs.uiuc.edu/pipermail/llvmdev/2009-February/020396.html I implemented the algorithm presented in [Ball94]. It only instruments the minimal number of edges necessary for edge profiling. The main changes introduced by this patch are: *) a interface compatible rewrite of ProfileInfo *) a cleanup of ProfileInfoLoader (some functionality in ProfileInfoLoader